pg.ddx.io pgsql-hackers@postgresql.org mailing list archive
help / color / mirror / Atom feedbroken master regress tests
24+ messages / 9 participants
[nested] [flat]
Commits from this thread:
2023-12-29 2c321ceaa9 Fix collate.windows.win1252 test.
2023-12-21 8793c60051 Initialize data directories with --lc-messages=C for tests.
2023-08-29 db6d9891e8 Generate a locale-agnostic initdb template
* broken master regress tests
@ 2023-08-25 03:53 Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 05:37 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
0 siblings, 2 replies; 24+ messages in thread
From: Pavel Stehule @ 2023-08-25 03:53 UTC (permalink / raw)
To: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Hi
today build is broken on my Fedora 39
Regards
Pavel
make[2]: Opouští se adresář
„/home/pavel/src/postgresql.master/src/bin/initdb“
make -C pg_amcheck check
make[2]: Vstupuje se do adresáře
„/home/pavel/src/postgresql.master/src/bin/pg_amcheck“
echo "# +++ tap check in src/bin/pg_amcheck +++" && rm -rf
'/home/pavel/src/postgresql.master/src/bin/pg_amcheck'/tmp_check &&
/usr/bin/mkdir -p
'/home/pavel/src/postgresql.master/src/bin/pg_amcheck'/tmp_check && cd . &&
TESTLOGDIR='/home/pavel/src/postgresql.master/src/bin/pg_amcheck/tmp_check/log'
TESTDATADIR='/home/pavel/src/postgresql.master/src/bin/pg_amcheck/tmp_check'
PATH="/home/pavel/src/postgresql.master/tmp_install/usr/local/pgsql/master/bin:/home/pavel/src/postgresql.master/src/bin/pg_amcheck:$PATH"
LD_LIBRARY_PATH="/home/pavel/src/postgresql.master/tmp_install/usr/local/pgsql/master/lib"
INITDB_TEMPLATE='/home/pavel/src/postgresql.master'/tmp_install/initdb-template
PGPORT='65432'
top_builddir='/home/pavel/src/postgresql.master/src/bin/pg_amcheck/../../..'
PG_REGRESS='/home/pavel/src/postgresql.master/src/bin/pg_amcheck/../../../src/test/regress/pg_regress'
/usr/bin/prove -I ../../../src/test/perl/ -I . t/*.pl
# +++ tap check in src/bin/pg_amcheck +++
t/001_basic.pl ........... ok
t/002_nonesuch.pl ........ ok
t/003_check.pl ........... 1/?
# Failed test 'pg_amcheck all schemas, tables and indexes in database db1
stdout /(?^:could not open file ".*": No such file or directory)/'
# at t/003_check.pl line 345.
# 'btree index "db1.s1.t1_btree":
# ERROR: index "t1_btree" lacks a main relation fork
# btree index "db1.s1.t2_btree":
# ERROR: could not open file "base/16384/16477.1" (target block
2862699856): previous segment is only 2 blocks
# btree index "db1.s3.t1_btree":
# ERROR: index "t1_btree" lacks a main relation fork
# btree index "db1.s3.t2_btree":
# ERROR: could not open file "base/16384/16601.1" (target block
2862699856): previous segment is only 2 blocks
# heap table "db1.s2.t1":
# ERROR: could not open file "base/16384/16491": Adresář nebo soubor
neexistuje
# heap table "db1.s2.t2", block 0, offset 3:
# line pointer redirection to item at offset 21840 exceeds maximum
offset 4
# heap table "db1.s2.t2", block 0, offset 4:
# line pointer to page offset 21840 with length 21840 ends beyond
maximum page offset 8192
# heap table "db1.s3.t1":
# ERROR: could not open file "base/16384/16553": Adresář nebo soubor
neexistuje
# heap table "db1.s3.t2", block 0, offset 3:
# line pointer redirection to item at offset 21840 exceeds maximum
offset 4
# heap table "db1.s3.t2", block 0, offset 4:
# line pointer to page offset 21840 with length 21840 ends beyond
maximum page offset 8192
# heap table "db1.s4.t2":
# ERROR: could not open file "base/16384/16623": Adresář nebo soubor
neexistuje
# heap table "db1.s3.t1_mv":
# ERROR: could not open file "base/16384/16570": Adresář nebo soubor
neexistuje
# heap table "db1.s3.t2_mv", block 0, offset 3:
# line pointer redirection to item at offset 21840 exceeds maximum
offset 4
# heap table "db1.s3.t2_mv", block 0, offset 4:
# line pointer to page offset 21840 with length 21840 ends beyond
maximum page offset 8192
# heap table "db1.s3.p1_1":
# ERROR: could not open file "base/16384/16588": Adresář nebo soubor
neexistuje
# heap table "db1.pg_toast.pg_toast_16620":
# ERROR: could not open file "base/16384/16623": Adresář nebo soubor
neexistuje
# '
# doesn't match '(?^:could not open file ".*": No such file or
directory)'
t/003_check.pl ........... 9/?
# Failed test 'pg_amcheck all schemas, tables and indexes in databases
db1, db2, and db3 stdout /(?^:could not open file ".*": No such file or
directory)/'
# at t/003_check.pl line 355.
# 'btree index "db1.s1.t1_btree":
# ERROR: index "t1_btree" lacks a main relation fork
# btree index "db1.s1.t2_btree":
# ERROR: could not open file "base/16384/16477.1" (target block
2862699856): previous segment is only 2 blocks
# btree index "db1.s3.t1_btree":
# ERROR: index "t1_btree" lacks a main relation fork
# btree index "db1.s3.t2_btree":
# ERROR: could not open file "base/16384/16601.1" (target block
2862699856): previous segment is only 2 blocks
# heap table "db1.s2.t1":
# ERROR: could not open file "base/16384/16491": Adresář nebo soubor
neexistuje
# heap table "db1.s2.t2", block 0, offset 3:
# line pointer redirection to item at offset 21840 exceeds maximum
offset 4
# heap table "db1.s2.t2", block 0, offset 4:
# line pointer to page offset 21840 with length 21840 ends beyond
maximum page offset 8192
# heap table "db1.s3.t1":
# ERROR: could not open file "base/16384/16553": Adresář nebo soubor
neexistuje
# heap table "db1.s3.t2", block 0, offset 3:
# line pointer redirection to item at offset 21840 exceeds maximum
offset 4
# heap table "db1.s3.t2", block 0, offset 4:
# line pointer to page offset 21840 with length 21840 ends beyond
maximum page offset 8192
# heap table "db1.s4.t2":
# ERROR: could not open file "base/16384/16623": Adresář nebo soubor
neexistuje
# heap table "db1.s3.t1_mv":
# ERROR: could not open file "base/16384/16570": Adresář nebo soubor
neexistuje
# heap table "db1.s3.t2_mv", block 0, offset 3:
# line pointer redirection to item at offset 21840 exceeds maximum
offset 4
# heap table "db1.s3.t2_mv", block 0, offset 4:
# line pointer to page offset 21840 with length 21840 ends beyond
maximum page offset 8192
# heap table "db1.s3.p1_1":
# ERROR: could not open file "base/16384/16588": Adresář nebo soubor
neexistuje
# heap table "db1.pg_toast.pg_toast_16620":
# ERROR: could not open file "base/16384/16623": Adresář nebo soubor
neexistuje
# btree index "db2.s1.t1_btree":
# ERROR: index "t1_btree" lacks a main relation fork
# heap table "db2.s1.t1":
# ERROR: could not open file "base/16736/16781": Adresář nebo soubor
neexistuje
# '
# doesn't match '(?^:could not open file ".*": No such file or
directory)'
# Failed test 'pg_amcheck of db2.s1 excluding indexes stdout /(?^:could
not open file ".*": No such file or directory)/'
# at t/003_check.pl line 402.
# 'heap table "db2.s1.t1":
# ERROR: could not open file "base/16736/16781": Adresář nebo soubor
neexistuje
# '
# doesn't match '(?^:could not open file ".*": No such file or
directory)'
# Failed test 'pg_amcheck schema s3 reports table and index errors stdout
/(?^:could not open file ".*": No such file or directory)/'
# at t/003_check.pl line 410.
# 'btree index "db1.s3.t1_btree":
# ERROR: index "t1_btree" lacks a main relation fork
# btree index "db1.s3.t2_btree":
# ERROR: could not open file "base/16384/16601.1" (target block
2862699856): previous segment is only 2 blocks
# heap table "db1.s3.t1":
# ERROR: could not open file "base/16384/16553": Adresář nebo soubor
neexistuje
# heap table "db1.s3.t2", block 0, offset 3:
# line pointer redirection to item at offset 21840 exceeds maximum
offset 4
# heap table "db1.s3.t2", block 0, offset 4:
# line pointer to page offset 21840 with length 21840 ends beyond
maximum page offset 8192
# heap table "db1.s3.t1_mv":
# ERROR: could not open file "base/16384/16570": Adresář nebo soubor
neexistuje
# heap table "db1.s3.t2_mv", block 0, offset 3:
# line pointer redirection to item at offset 21840 exceeds maximum
offset 4
# heap table "db1.s3.t2_mv", block 0, offset 4:
# line pointer to page offset 21840 with length 21840 ends beyond
maximum page offset 8192
# heap table "db1.s3.p1_1":
# ERROR: could not open file "base/16384/16588": Adresář nebo soubor
neexistuje
# '
# doesn't match '(?^:could not open file ".*": No such file or
directory)'
# Failed test 'pg_amcheck in schema s4 reports toast corruption stdout
/(?^:could not open file ".*": No such file or directory)/'
# at t/003_check.pl line 423.
# 'heap table "db1.s4.t2":
# ERROR: could not open file "base/16384/16623": Adresář nebo soubor
neexistuje
# heap table "db1.pg_toast.pg_toast_16620":
# ERROR: could not open file "base/16384/16623": Adresář nebo soubor
neexistuje
# '
# doesn't match '(?^:could not open file ".*": No such file or
directory)'
t/003_check.pl ........... 40/? # Looks like you failed 5 tests of 63.
t/003_check.pl ........... Dubious, test returned 5 (wstat 1280, 0x500)
Failed 5/63 subtests
t/004_verify_heapam.pl ... ok
t/005_opclass_damage.pl .. ok
Test Summary Report
-------------------
t/003_check.pl (Wstat: 1280 (exited 5) Tests: 63 Failed: 5)
Failed tests: 7, 12, 24, 29, 32
Non-zero exit status: 5
Files=5, Tests=214, 9 wallclock secs ( 0.09 usr 0.01 sys + 1.65 cusr
1.59 csys = 3.34 CPU)
Result: FAIL
make[2]: *** [Makefile:48: check] Chyba 1
make[2]: Opouští se adresář
„/home/pavel/src/postgresql.master/src/bin/pg_amcheck“
make[1]: *** [Makefile:43: check-pg_amcheck-recurse] Chyba 2
make[1]: Opouští se adresář „/home/pavel/src/postgresql.master/src/bin“
make: *** [GNUmakefile:71: check-world-src/bin-recurse] Chyba 2
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
@ 2023-08-25 05:37 ` Thomas Munro <thomas.munro@gmail.com>
2023-08-25 06:10 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
1 sibling, 1 reply; 24+ messages in thread
From: Thomas Munro @ 2023-08-25 05:37 UTC (permalink / raw)
To: Pavel Stehule <pavel.stehule@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Fri, Aug 25, 2023 at 3:54 PM Pavel Stehule <pavel.stehule@gmail.com> wrote:
> today build is broken on my Fedora 39
Has commit 252dcb32 somehow upset some kind of bleeding edge btrfs
filesystem? That's a wild guess and I can't really imagine how but
apparently your database files are totally messed up...
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 05:37 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
@ 2023-08-25 06:10 ` Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:17 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
0 siblings, 1 reply; 24+ messages in thread
From: Pavel Stehule @ 2023-08-25 06:10 UTC (permalink / raw)
To: Thomas Munro <thomas.munro@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Hi
pá 25. 8. 2023 v 7:38 odesílatel Thomas Munro <thomas.munro@gmail.com>
napsal:
> On Fri, Aug 25, 2023 at 3:54 PM Pavel Stehule <pavel.stehule@gmail.com>
> wrote:
> > today build is broken on my Fedora 39
>
> Has commit 252dcb32 somehow upset some kind of bleeding edge btrfs
> filesystem? That's a wild guess and I can't really imagine how but
> apparently your database files are totally messed up...
>
I use only ext4
[pavel@nemesis ~]$ mount | grep home
/dev/mapper/luks-feb21fdf-c7aa-4373-b25e-fb26d4b28216 on /home type ext4
(rw,relatime,seclabel)
but the kernel is fresh
[pavel@nemesis ~]$ uname -a
Linux nemesis 6.5.0-0.rc6.43.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Mon Aug 14
17:17:41 UTC 2023 x86_64 GNU/Linux
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 05:37 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-25 06:10 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
@ 2023-08-25 06:17 ` Pavel Stehule <pavel.stehule@gmail.com>
0 siblings, 0 replies; 24+ messages in thread
From: Pavel Stehule @ 2023-08-25 06:17 UTC (permalink / raw)
To: Thomas Munro <thomas.munro@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
pá 25. 8. 2023 v 8:10 odesílatel Pavel Stehule <pavel.stehule@gmail.com>
napsal:
> Hi
>
> pá 25. 8. 2023 v 7:38 odesílatel Thomas Munro <thomas.munro@gmail.com>
> napsal:
>
>> On Fri, Aug 25, 2023 at 3:54 PM Pavel Stehule <pavel.stehule@gmail.com>
>> wrote:
>> > today build is broken on my Fedora 39
>>
>> Has commit 252dcb32 somehow upset some kind of bleeding edge btrfs
>> filesystem? That's a wild guess and I can't really imagine how but
>> apparently your database files are totally messed up...
>>
>
> I use only ext4
>
> [pavel@nemesis ~]$ mount | grep home
> /dev/mapper/luks-feb21fdf-c7aa-4373-b25e-fb26d4b28216 on /home type ext4
> (rw,relatime,seclabel)
>
> but the kernel is fresh
>
> [pavel@nemesis ~]$ uname -a
> Linux nemesis 6.5.0-0.rc6.43.fc39.x86_64 #1 SMP PREEMPT_DYNAMIC Mon Aug 14
> 17:17:41 UTC 2023 x86_64 GNU/Linux
>
>
I tested it on another comp with fresh fedora 38 installation with same
result
again I use only ext4 there
>
>
>
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
@ 2023-08-25 06:22 ` Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
1 sibling, 1 reply; 24+ messages in thread
From: Matthias van de Meent @ 2023-08-25 06:22 UTC (permalink / raw)
To: Pavel Stehule <pavel.stehule@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Fri, 25 Aug 2023, 05:54 Pavel Stehule, <pavel.stehule@gmail.com> wrote:
> Hi
>
> today build is broken on my Fedora 39
>
> Regards
>
> Pavel
>
> make[2]: Opouští se adresář
> „/home/pavel/src/postgresql.master/src/bin/initdb“
> make -C pg_amcheck check
> make[2]: Vstupuje se do adresáře
> „/home/pavel/src/postgresql.master/src/bin/pg_amcheck“
> [...]
> # ERROR: could not open file "base/16736/16781": Adresář nebo soubor
> neexistuje
> # '
> # doesn't match '(?^:could not open file ".*": No such file or
> directory)'
>
It looks like the error message matcher doesn't account for the localized
version of "No such file or directory", might that be the issue?
Kind regards,
Matthias van de Meent
Neon (https://neon.tech)
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
@ 2023-08-25 07:12 ` Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
0 siblings, 1 reply; 24+ messages in thread
From: Pavel Stehule @ 2023-08-25 07:12 UTC (permalink / raw)
To: Matthias van de Meent <boekewurm+postgres@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
pá 25. 8. 2023 v 8:22 odesílatel Matthias van de Meent <
boekewurm+postgres@gmail.com> napsal:
>
>
> On Fri, 25 Aug 2023, 05:54 Pavel Stehule, <pavel.stehule@gmail.com> wrote:
>
>> Hi
>>
>> today build is broken on my Fedora 39
>>
>> Regards
>>
>> Pavel
>>
>> make[2]: Opouští se adresář
>> „/home/pavel/src/postgresql.master/src/bin/initdb“
>> make -C pg_amcheck check
>> make[2]: Vstupuje se do adresáře
>> „/home/pavel/src/postgresql.master/src/bin/pg_amcheck“
>> [...]
>> # ERROR: could not open file "base/16736/16781": Adresář nebo soubor
>> neexistuje
>> # '
>> # doesn't match '(?^:could not open file ".*": No such file or
>> directory)'
>>
>
> It looks like the error message matcher doesn't account for the localized
> version of "No such file or directory", might that be the issue?
>
yes
LANG=C maje check-world
fixed this issue
Regards
Pavel
>
> Kind regards,
>
> Matthias van de Meent
> Neon (https://neon.tech)
>
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
@ 2023-08-26 15:02 ` Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
0 siblings, 1 reply; 24+ messages in thread
From: Pavel Stehule @ 2023-08-26 15:02 UTC (permalink / raw)
To: Matthias van de Meent <boekewurm+postgres@gmail.com>; +Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Hi
pá 25. 8. 2023 v 9:12 odesílatel Pavel Stehule <pavel.stehule@gmail.com>
napsal:
>
>
> pá 25. 8. 2023 v 8:22 odesílatel Matthias van de Meent <
> boekewurm+postgres@gmail.com> napsal:
>
>>
>>
>> On Fri, 25 Aug 2023, 05:54 Pavel Stehule, <pavel.stehule@gmail.com>
>> wrote:
>>
>>> Hi
>>>
>>> today build is broken on my Fedora 39
>>>
>>> Regards
>>>
>>> Pavel
>>>
>>> make[2]: Opouští se adresář
>>> „/home/pavel/src/postgresql.master/src/bin/initdb“
>>> make -C pg_amcheck check
>>> make[2]: Vstupuje se do adresáře
>>> „/home/pavel/src/postgresql.master/src/bin/pg_amcheck“
>>> [...]
>>> # ERROR: could not open file "base/16736/16781": Adresář nebo
>>> soubor neexistuje
>>> # '
>>> # doesn't match '(?^:could not open file ".*": No such file or
>>> directory)'
>>>
>>
>> It looks like the error message matcher doesn't account for the localized
>> version of "No such file or directory", might that be the issue?
>>
>
> yes
>
> LANG=C maje check-world
>
>
>
I tried to fix this issue, but there is some strange
regress tests are initialized with
<-->delete $ENV{LANGUAGE};
<-->delete $ENV{LC_ALL};
<-->$ENV{LC_MESSAGES} = 'C';
so the environment should be correct
I checked this setting before
<-->IPC::Run::run($cmd, '>', \$stdout, '2>', \$stderr);
and it looks correct. But the tests fails
Only when I use `LC_MESSAGES=C make check` the tests are ok
My environment has only `LANG=cs_CZ.UTF-8`
So it looks so IPC::Run::run is ignore parent environment
>
> Regards
>
> Pavel
>
>>
>> Kind regards,
>>
>> Matthias van de Meent
>> Neon (https://neon.tech)
>>
>
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
@ 2023-08-26 21:52 ` Thomas Munro <thomas.munro@gmail.com>
2023-08-27 03:37 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
0 siblings, 2 replies; 24+ messages in thread
From: Thomas Munro @ 2023-08-26 21:52 UTC (permalink / raw)
To: Pavel Stehule <pavel.stehule@gmail.com>; +Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Sun, Aug 27, 2023 at 3:03 AM Pavel Stehule <pavel.stehule@gmail.com> wrote:
> So it looks so IPC::Run::run is ignore parent environment
I guess the new initdb template captures lc_messages in
postgresql.conf, when it runs earlier? I guess if you put
$node->append_conf('postgresql.conf', 'lc_messages=C'); into
src/bin/pg_amcheck/t/003_check.pl then it will work. I'm not sure
what the correct fix should be, ie if the template mechanism should
notice this difference and not use the template, or if tests that
depend on the message locale should explicitly say so with
lc_messages=C or similar (why is this the only one?), or ...
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
@ 2023-08-27 03:37 ` Pavel Stehule <pavel.stehule@gmail.com>
1 sibling, 0 replies; 24+ messages in thread
From: Pavel Stehule @ 2023-08-27 03:37 UTC (permalink / raw)
To: Thomas Munro <thomas.munro@gmail.com>; +Cc: Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Hi
so 26. 8. 2023 v 23:52 odesílatel Thomas Munro <thomas.munro@gmail.com>
napsal:
> On Sun, Aug 27, 2023 at 3:03 AM Pavel Stehule <pavel.stehule@gmail.com>
> wrote:
> > So it looks so IPC::Run::run is ignore parent environment
>
> I guess the new initdb template captures lc_messages in
> postgresql.conf, when it runs earlier? I guess if you put
> $node->append_conf('postgresql.conf', 'lc_messages=C'); into
> src/bin/pg_amcheck/t/003_check.pl then it will work. I'm not sure
> what the correct fix should be, ie if the template mechanism should
> notice this difference and not use the template, or if tests that
> depend on the message locale should explicitly say so with
> lc_messages=C or similar (why is this the only one?), or ...
>
diff --git a/src/bin/pg_amcheck/t/003_check.pl b/src/bin/pg_amcheck/t/
003_check.pl
index d577cffa30..ba7c713adc 100644
inline patch 1: src/bin/pg_amcheck/t/003_check.pl (+1/-0 lines) download inline-1.patch
--- a/src/bin/pg_amcheck/t/003_check.pl
+++ b/src/bin/pg_amcheck/t/003_check.pl
@@ -122,6 +122,7 @@ sub perform_all_corruptions()
$node = PostgreSQL::Test::Cluster->new('test');
$node->init;
$node->append_conf('postgresql.conf', 'autovacuum=off');
+$node->append_conf('postgresql.conf', 'lc_messages=C');
$node->start;
$port = $node->port;
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
@ 2023-08-29 15:54 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-08-29 16:55 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-09-12 02:23 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
1 sibling, 2 replies; 24+ messages in thread
From: Alvaro Herrera @ 2023-08-29 15:54 UTC (permalink / raw)
To: Thomas Munro <thomas.munro@gmail.com>; +Cc: Pavel Stehule <pavel.stehule@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On 2023-Aug-27, Thomas Munro wrote:
> On Sun, Aug 27, 2023 at 3:03 AM Pavel Stehule <pavel.stehule@gmail.com> wrote:
> > So it looks so IPC::Run::run is ignore parent environment
>
> I guess the new initdb template captures lc_messages in
> postgresql.conf, when it runs earlier? I guess if you put
> $node->append_conf('postgresql.conf', 'lc_messages=C'); into
> src/bin/pg_amcheck/t/003_check.pl then it will work. I'm not sure
> what the correct fix should be, ie if the template mechanism should
> notice this difference and not use the template, or if tests that
> depend on the message locale should explicitly say so with
> lc_messages=C or similar (why is this the only one?), or ...
So I tried this technique, but it gest old pretty fast: apparently
there's a *ton* of tests that depend on the locale. I gave up after
patching the first five files, and noticing that in a second run there
another half a dozen failing tests that hadn't failed the first time
around. (Not sure why this happened.)
So I think injecting --no-locale to the initdb line that creates the
template is a better approach; something like the attached.
--
Álvaro Herrera PostgreSQL Developer — https://www.EnterpriseDB.com/
Attachments:
nolocale.patch (text/x-diff, 1.2K) download
diff --git a/meson.build b/meson.build
index 8b2b521a01..5422885b0a 100644
--- a/meson.build
+++ b/meson.build
@@ -3107,7 +3107,7 @@ sys.exit(sp.returncode)
''',
test_initdb_template,
temp_install_bindir / 'initdb',
- '-A', 'trust', '-N', '--no-instructions'
+ '-A', 'trust', '-N', '--no-instructions', '--no-locale'
],
priority: setup_tests_priority - 1,
timeout: 300,
diff --git a/src/Makefile.global.in b/src/Makefile.global.in
index 0b4ca0eb6a..765b60db02 100644
--- a/src/Makefile.global.in
+++ b/src/Makefile.global.in
@@ -425,7 +425,7 @@ ifeq ($(MAKELEVEL),0)
$(MAKE) -C '$(top_builddir)' DESTDIR='$(abs_top_builddir)'/tmp_install install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1
$(MAKE) -j1 $(if $(CHECKPREP_TOP),-C $(CHECKPREP_TOP),) checkprep >>'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1
- $(with_temp_install) initdb -A trust -N --no-instructions '$(abs_top_builddir)'/tmp_install/initdb-template >>'$(abs_top_builddir)'/tmp_install/log/initdb-template.log 2>&1
+ $(with_temp_install) initdb -A trust -N --no-instructions --no-locale '$(abs_top_builddir)'/tmp_install/initdb-template >>'$(abs_top_builddir)'/tmp_install/log/initdb-template.log 2>&1
endif
endif
endif
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2023-08-29 16:55 ` Pavel Stehule <pavel.stehule@gmail.com>
1 sibling, 0 replies; 24+ messages in thread
From: Pavel Stehule @ 2023-08-29 16:55 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Thomas Munro <thomas.munro@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
út 29. 8. 2023 v 17:54 odesílatel Alvaro Herrera <alvherre@alvh.no-ip.org>
napsal:
> On 2023-Aug-27, Thomas Munro wrote:
>
> > On Sun, Aug 27, 2023 at 3:03 AM Pavel Stehule <pavel.stehule@gmail.com>
> wrote:
> > > So it looks so IPC::Run::run is ignore parent environment
> >
> > I guess the new initdb template captures lc_messages in
> > postgresql.conf, when it runs earlier? I guess if you put
> > $node->append_conf('postgresql.conf', 'lc_messages=C'); into
> > src/bin/pg_amcheck/t/003_check.pl then it will work. I'm not sure
> > what the correct fix should be, ie if the template mechanism should
> > notice this difference and not use the template, or if tests that
> > depend on the message locale should explicitly say so with
> > lc_messages=C or similar (why is this the only one?), or ...
>
> So I tried this technique, but it gest old pretty fast: apparently
> there's a *ton* of tests that depend on the locale. I gave up after
> patching the first five files, and noticing that in a second run there
> another half a dozen failing tests that hadn't failed the first time
> around. (Not sure why this happened.)
>
> So I think injecting --no-locale to the initdb line that creates the
> template is a better approach; something like the attached.
>
ok
thank you for fixing it
Regards
Pavel
>
> --
> Álvaro Herrera PostgreSQL Developer —
> https://www.EnterpriseDB.com/
>
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
@ 2023-09-12 02:23 ` Andres Freund <andres@anarazel.de>
2023-10-11 00:08 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
1 sibling, 1 reply; 24+ messages in thread
From: Andres Freund @ 2023-09-12 02:23 UTC (permalink / raw)
To: Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Thomas Munro <thomas.munro@gmail.com>; Pavel Stehule <pavel.stehule@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Hi,
On 2023-08-29 17:54:24 +0200, Alvaro Herrera wrote:
> On 2023-Aug-27, Thomas Munro wrote:
>
> > On Sun, Aug 27, 2023 at 3:03 AM Pavel Stehule <pavel.stehule@gmail.com> wrote:
> > > So it looks so IPC::Run::run is ignore parent environment
> >
> > I guess the new initdb template captures lc_messages in
> > postgresql.conf, when it runs earlier? I guess if you put
> > $node->append_conf('postgresql.conf', 'lc_messages=C'); into
> > src/bin/pg_amcheck/t/003_check.pl then it will work. I'm not sure
> > what the correct fix should be, ie if the template mechanism should
> > notice this difference and not use the template, or if tests that
> > depend on the message locale should explicitly say so with
> > lc_messages=C or similar (why is this the only one?), or ...
>
> So I tried this technique, but it gest old pretty fast: apparently
> there's a *ton* of tests that depend on the locale. I gave up after
> patching the first five files, and noticing that in a second run there
> another half a dozen failing tests that hadn't failed the first time
> around. (Not sure why this happened.)
>
> So I think injecting --no-locale to the initdb line that creates the
> template is a better approach; something like the attached.
Makes sense, thanks for taking care of this.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-09-12 02:23 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
@ 2023-10-11 00:08 ` Jeff Davis <pgsql@j-davis.com>
2023-10-11 00:54 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
0 siblings, 1 reply; 24+ messages in thread
From: Jeff Davis @ 2023-10-11 00:08 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; Alvaro Herrera <alvherre@alvh.no-ip.org>; +Cc: Thomas Munro <thomas.munro@gmail.com>; Pavel Stehule <pavel.stehule@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Mon, 2023-09-11 at 19:23 -0700, Andres Freund wrote:
> > So I think injecting --no-locale to the initdb line that creates
> > the
> > template is a better approach; something like the attached.
>
> Makes sense, thanks for taking care of this.
After this, it seems "make check" no longer picks up the locale from
the system environment by default.
What is the new way to run the regression tests with an actual locale?
If it's no longer done by default, won't that dramatically reduce the
coverage of non-C locales?
Regards,
Jeff Davis
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-09-12 02:23 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-10-11 00:08 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
@ 2023-10-11 00:54 ` Andres Freund <andres@anarazel.de>
2023-10-17 03:10 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-12-13 02:56 ` Re: broken master regress tests Noah Misch <noah@leadboat.com>
0 siblings, 2 replies; 24+ messages in thread
From: Andres Freund @ 2023-10-11 00:54 UTC (permalink / raw)
To: Jeff Davis <pgsql@j-davis.com>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; Thomas Munro <thomas.munro@gmail.com>; Pavel Stehule <pavel.stehule@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Hi,
On 2023-10-10 17:08:25 -0700, Jeff Davis wrote:
> On Mon, 2023-09-11 at 19:23 -0700, Andres Freund wrote:
> > > So I think injecting --no-locale to the initdb line that creates
> > > the
> > > template is a better approach; something like the attached.
> >
> > Makes sense, thanks for taking care of this.
>
> After this, it seems "make check" no longer picks up the locale from
> the system environment by default.
Yea. I wonder if the better fix would have been to copy setenv("LC_MESSAGES", "C", 1);
to the initdb template creation. That afaict also fixes the issue, with a
smaller blast radius?
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-09-12 02:23 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-10-11 00:08 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-10-11 00:54 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
@ 2023-10-17 03:10 ` Jeff Davis <pgsql@j-davis.com>
1 sibling, 0 replies; 24+ messages in thread
From: Jeff Davis @ 2023-10-17 03:10 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; Thomas Munro <thomas.munro@gmail.com>; Pavel Stehule <pavel.stehule@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Tue, 2023-10-10 at 17:54 -0700, Andres Freund wrote:
> Yea. I wonder if the better fix would have been to copy
> setenv("LC_MESSAGES", "C", 1);
> to the initdb template creation. That afaict also fixes the issue,
> with a
> smaller blast radius?
Sounds good to me. Is there anything else we should do to notice that
tests are unexpectedly skipped, or is this a rare enough problem to not
worry about other cases?
Regards,
Jeff Davis
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-09-12 02:23 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-10-11 00:08 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-10-11 00:54 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
@ 2023-12-13 02:56 ` Noah Misch <noah@leadboat.com>
2023-12-13 02:59 ` Re: broken master regress tests Tom Lane <tgl@sss.pgh.pa.us>
2023-12-21 01:48 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
1 sibling, 2 replies; 24+ messages in thread
From: Noah Misch @ 2023-12-13 02:56 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: Jeff Davis <pgsql@j-davis.com>; Alvaro Herrera <alvherre@alvh.no-ip.org>; Thomas Munro <thomas.munro@gmail.com>; Pavel Stehule <pavel.stehule@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Tue, Oct 10, 2023 at 05:54:34PM -0700, Andres Freund wrote:
> On 2023-10-10 17:08:25 -0700, Jeff Davis wrote:
> > After this, it seems "make check" no longer picks up the locale from
> > the system environment by default.
>
> Yea. I wonder if the better fix would have been to copy setenv("LC_MESSAGES", "C", 1);
> to the initdb template creation. That afaict also fixes the issue, with a
> smaller blast radius?
+1, that would restore the testing semantics known from v16-. I think the
intent of the template was to optimize without changing semantics, and the
above proposal aligns with that. Currently, for v17 alone, one needs
installcheck or build file hacks to reproduce a locale-specific test failure.
An alternative would be to declare that the tests are supported in one
encoding+locale only, then stop testing others in the buildfarm. Even if we
did that, I'm fairly sure we'd standardize on UTF8, not SQL_ASCII, as the one
testable encoding.
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-09-12 02:23 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-10-11 00:08 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-10-11 00:54 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-12-13 02:56 ` Re: broken master regress tests Noah Misch <noah@leadboat.com>
@ 2023-12-13 02:59 ` Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 0 replies; 24+ messages in thread
From: Tom Lane @ 2023-12-13 02:59 UTC (permalink / raw)
To: Noah Misch <noah@leadboat.com>; +Cc: Andres Freund <andres@anarazel.de>; Jeff Davis <pgsql@j-davis.com>; Alvaro Herrera <alvherre@alvh.no-ip.org>; Thomas Munro <thomas.munro@gmail.com>; Pavel Stehule <pavel.stehule@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Noah Misch <noah@leadboat.com> writes:
> An alternative would be to declare that the tests are supported in one
> encoding+locale only, then stop testing others in the buildfarm.
Surely that's not even a thinkably acceptable choice.
regards, tom lane
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-09-12 02:23 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-10-11 00:08 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-10-11 00:54 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-12-13 02:56 ` Re: broken master regress tests Noah Misch <noah@leadboat.com>
@ 2023-12-21 01:48 ` Jeff Davis <pgsql@j-davis.com>
2023-12-21 23:17 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
1 sibling, 1 reply; 24+ messages in thread
From: Jeff Davis @ 2023-12-21 01:48 UTC (permalink / raw)
To: Noah Misch <noah@leadboat.com>; Andres Freund <andres@anarazel.de>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; Thomas Munro <thomas.munro@gmail.com>; Pavel Stehule <pavel.stehule@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Tue, 2023-12-12 at 18:56 -0800, Noah Misch wrote:
> > Yea. I wonder if the better fix would have been to copy
> > setenv("LC_MESSAGES", "C", 1);
> > to the initdb template creation. That afaict also fixes the issue,
> > with a
> > smaller blast radius?
>
> +1, that would restore the testing semantics known from v16-. I
> think the
> intent of the template was to optimize without changing semantics,
> and the
> above proposal aligns with that. Currently, for v17 alone, one needs
> installcheck or build file hacks to reproduce a locale-specific test
> failure.
Attached.
I just changed --no-locale to --lc-messages=C, which I think solves it
in the right place with minimal blast radius. Andres, did you literally
mean C setenv() somewhere, or is this what you had in mind?
I also noticed that collate.linux.utf8.sql seems to be skipped on my
machine because of the "version() !~ 'linux-gnu'" check, even though
I'm running Ubuntu. Is that test getting run often enough?
And relatedly, is it worth thinking about extending pg_regress to
report skipped tests so it's easier to find these kinds of problems?
Regards,
Jeff Davis
Attachments:
v1-0001-Initialize-data-directories-with-lc-messages-C-fo.patch (text/x-patch, 1.9K) download
From 3ffcf3e25bd2b16114775409404ee492e283584f Mon Sep 17 00:00:00 2001
From: Jeff Davis <jeff@j-davis.com>
Date: Tue, 19 Dec 2023 22:34:52 -0800
Subject: [PATCH v1] Initialize data directories with --lc-messages=C for
tests.
Commit db6d9891e8 changed them to be initialized with --no-locale, but
that reduced the test coverage for non-C locales.
Discussion: https://postgr.es/m/0d47e5ecc037b3908149aad5f2a987793cf938bd.camel%40j-davis.com
---
meson.build | 2 +-
src/Makefile.global.in | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/meson.build b/meson.build
index f816283301..f786850840 100644
--- a/meson.build
+++ b/meson.build
@@ -3115,7 +3115,7 @@ sys.exit(sp.returncode)
''',
test_initdb_template,
temp_install_bindir / 'initdb',
- '--auth', 'trust', '--no-sync', '--no-instructions', '--no-locale',
+ '--auth', 'trust', '--no-sync', '--no-instructions', '--lc-messages=C',
'--no-clean'
],
priority: setup_tests_priority - 1,
diff --git a/src/Makefile.global.in b/src/Makefile.global.in
index 104e5de0fe..f8e461cbad 100644
--- a/src/Makefile.global.in
+++ b/src/Makefile.global.in
@@ -423,7 +423,7 @@ ifeq ($(MAKELEVEL),0)
$(MAKE) -C '$(top_builddir)' DESTDIR='$(abs_top_builddir)'/tmp_install install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1
$(MAKE) -j1 $(if $(CHECKPREP_TOP),-C $(CHECKPREP_TOP),) checkprep >>'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1
- $(with_temp_install) initdb --auth trust --no-sync --no-instructions --no-locale --no-clean '$(abs_top_builddir)'/tmp_install/initdb-template >>'$(abs_top_builddir)'/tmp_install/log/initdb-template.log 2>&1
+ $(with_temp_install) initdb --auth trust --no-sync --no-instructions --lc-messages=C --no-clean '$(abs_top_builddir)'/tmp_install/initdb-template >>'$(abs_top_builddir)'/tmp_install/log/initdb-template.log 2>&1
endif
endif
endif
--
2.34.1
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-09-12 02:23 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-10-11 00:08 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-10-11 00:54 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-12-13 02:56 ` Re: broken master regress tests Noah Misch <noah@leadboat.com>
2023-12-21 01:48 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
@ 2023-12-21 23:17 ` Jeff Davis <pgsql@j-davis.com>
2023-12-23 20:35 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-12-28 15:00 ` Re: broken master regress tests Alexander Lakhin <exclusion@gmail.com>
0 siblings, 2 replies; 24+ messages in thread
From: Jeff Davis @ 2023-12-21 23:17 UTC (permalink / raw)
To: Noah Misch <noah@leadboat.com>; Andres Freund <andres@anarazel.de>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; Thomas Munro <thomas.munro@gmail.com>; Pavel Stehule <pavel.stehule@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Wed, 2023-12-20 at 17:48 -0800, Jeff Davis wrote:
> Attached.
It appears to increase the coverage. I committed it and I'll see how
the buildfarm reacts.
Regards,
Jeff Davis
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-09-12 02:23 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-10-11 00:08 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-10-11 00:54 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-12-13 02:56 ` Re: broken master regress tests Noah Misch <noah@leadboat.com>
2023-12-21 01:48 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-12-21 23:17 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
@ 2023-12-23 20:35 ` Pavel Stehule <pavel.stehule@gmail.com>
1 sibling, 0 replies; 24+ messages in thread
From: Pavel Stehule @ 2023-12-23 20:35 UTC (permalink / raw)
To: Jeff Davis <pgsql@j-davis.com>; +Cc: Noah Misch <noah@leadboat.com>; Andres Freund <andres@anarazel.de>; Alvaro Herrera <alvherre@alvh.no-ip.org>; Thomas Munro <thomas.munro@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Hi
pá 22. 12. 2023 v 0:17 odesílatel Jeff Davis <pgsql@j-davis.com> napsal:
> On Wed, 2023-12-20 at 17:48 -0800, Jeff Davis wrote:
> > Attached.
>
> It appears to increase the coverage. I committed it and I'll see how
> the buildfarm reacts.
>
I tested it locally ( LANG=cs_CZ.UTF-8 ) without problems
Regards
Pavel
> Regards,
> Jeff Davis
>
>
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-09-12 02:23 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-10-11 00:08 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-10-11 00:54 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-12-13 02:56 ` Re: broken master regress tests Noah Misch <noah@leadboat.com>
2023-12-21 01:48 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-12-21 23:17 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
@ 2023-12-28 15:00 ` Alexander Lakhin <exclusion@gmail.com>
2023-12-28 17:36 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
1 sibling, 1 reply; 24+ messages in thread
From: Alexander Lakhin @ 2023-12-28 15:00 UTC (permalink / raw)
To: Jeff Davis <pgsql@j-davis.com>; Noah Misch <noah@leadboat.com>; Andres Freund <andres@anarazel.de>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; Thomas Munro <thomas.munro@gmail.com>; Pavel Stehule <pavel.stehule@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Hello Jeff,
22.12.2023 02:17, Jeff Davis wrote:
> On Wed, 2023-12-20 at 17:48 -0800, Jeff Davis wrote:
>> Attached.
> It appears to increase the coverage. I committed it and I'll see how
> the buildfarm reacts.
Starting from the commit 8793c6005, I observe a failure of test
collate.windows.win1252 on Windows Server 2016:
meson test regress/regress
1/1 postgresql:regress / regress/regress ERROR 24.47s exit status 1
regression.diffs contains:
@@ -993,6 +993,8 @@
-- nondeterministic collations
-- (not supported with libc provider)
CREATE COLLATION ctest_det (locale = 'en_US', deterministic = true);
+ERROR: could not create locale "en_US": No such file or directory
+DETAIL: The operating system could not find any locale data for the locale name "en_US".
CREATE COLLATION ctest_nondet (locale = 'en_US', deterministic = false);
ERROR: nondeterministic collations not supported with this provider
-- cleanup
Though
CREATE COLLATION ctest_det (locale = 'English_United States', deterministic = true);
executed successfully on this OS.
AFAICS, before that commit SELECT getdatabaseencoding() in the test
returned SQL_ASCII, hence the test was essentially skipped, but now it
returns WIN1252, so problematic CREATE COLLATION(locale = 'en_US', ...)
is reached.
Best regards,
Alexander
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-09-12 02:23 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-10-11 00:08 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-10-11 00:54 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-12-13 02:56 ` Re: broken master regress tests Noah Misch <noah@leadboat.com>
2023-12-21 01:48 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-12-21 23:17 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-12-28 15:00 ` Re: broken master regress tests Alexander Lakhin <exclusion@gmail.com>
@ 2023-12-28 17:36 ` Jeff Davis <pgsql@j-davis.com>
2023-12-28 19:00 ` Re: broken master regress tests Alexander Lakhin <exclusion@gmail.com>
0 siblings, 1 reply; 24+ messages in thread
From: Jeff Davis @ 2023-12-28 17:36 UTC (permalink / raw)
To: Alexander Lakhin <exclusion@gmail.com>; Noah Misch <noah@leadboat.com>; Andres Freund <andres@anarazel.de>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; Thomas Munro <thomas.munro@gmail.com>; Pavel Stehule <pavel.stehule@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 2023-12-28 at 18:00 +0300, Alexander Lakhin wrote:
> AFAICS, before that commit SELECT getdatabaseencoding() in the test
> returned SQL_ASCII, hence the test was essentially skipped, but now
> it
> returns WIN1252, so problematic CREATE COLLATION(locale = 'en_US',
> ...)
> is reached.
We do want that test to run though, right?
I suspect that test line never worked reliably. The skip_test check at
the top guarantees that the collation named "en_US" exists, but that
doesn't mean that the OS understands the locale 'en_US'.
Perhaps we can change that line to use a similar trick as what's used
elsewhere in the file:
do $$
BEGIN
EXECUTE 'CREATE COLLATION ctest_det (locale = ' ||
quote_literal((SELECT collcollate FROM pg_collation WHERE
collname = ''en_US'')) || ', deterministic = true);';
END
$$;
The above may need some adjustment, but perhaps you can try it out?
Another option might be to use \gset to assign it to a variable, which
might be more readable, but I think it's better to just follow what the
rest of the file is doing.
Regards,
Jeff Davis
^ permalink raw reply [nested|flat] 24+ messages in thread
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-09-12 02:23 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-10-11 00:08 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-10-11 00:54 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-12-13 02:56 ` Re: broken master regress tests Noah Misch <noah@leadboat.com>
2023-12-21 01:48 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-12-21 23:17 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-12-28 15:00 ` Re: broken master regress tests Alexander Lakhin <exclusion@gmail.com>
2023-12-28 17:36 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
@ 2023-12-28 19:00 ` Alexander Lakhin <exclusion@gmail.com>
2023-12-29 20:10 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
0 siblings, 1 reply; 24+ messages in thread
From: Alexander Lakhin @ 2023-12-28 19:00 UTC (permalink / raw)
To: Jeff Davis <pgsql@j-davis.com>; Noah Misch <noah@leadboat.com>; Andres Freund <andres@anarazel.de>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; Thomas Munro <thomas.munro@gmail.com>; Pavel Stehule <pavel.stehule@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
28.12.2023 20:36, Jeff Davis wrote:
> We do want that test to run though, right?
Yes, I think so.
> I suspect that test line never worked reliably. The skip_test check at
> the top guarantees that the collation named "en_US" exists, but that
> doesn't mean that the OS understands the locale 'en_US'.
>
> Perhaps we can change that line to use a similar trick as what's used
> elsewhere in the file:
>
> do $$
> BEGIN
> EXECUTE 'CREATE COLLATION ctest_det (locale = ' ||
> quote_literal((SELECT collcollate FROM pg_collation WHERE
> collname = ''en_US'')) || ', deterministic = true);';
> END
> $$;
>
> The above may need some adjustment, but perhaps you can try it out?
Yes, this trick resolves the issue, it gives locale 'en-US' on that OS,
which works there. Please see the attached patch.
But looking at the result with the comment above that "do" block, I wonder
whether this successful CREATE COLLATION command is so important to perform
it that tricky way, if we want to demonstrate that nondeterministic
collations not supported.
So in case you decide just to remove this command, please see the second
patch.
Best regards,
Alexander
Attachments: download all (2 files, .tar.gz)
fix-collate-windows-test-.patch (text/x-patch, 1.1K) download
diff --git a/src/test/regress/expected/collate.windows.win1252.out b/src/test/regress/expected/collate.windows.win1252.out
index b7b93959de..bb6297a113 100644
--- a/src/test/regress/expected/collate.windows.win1252.out
+++ b/src/test/regress/expected/collate.windows.win1252.out
@@ -992,7 +992,6 @@ drop type textrange_c;
drop type textrange_en_us;
-- nondeterministic collations
-- (not supported with libc provider)
-CREATE COLLATION ctest_det (locale = 'en_US', deterministic = true);
CREATE COLLATION ctest_nondet (locale = 'en_US', deterministic = false);
ERROR: nondeterministic collations not supported with this provider
-- cleanup
diff --git a/src/test/regress/sql/collate.windows.win1252.sql b/src/test/regress/sql/collate.windows.win1252.sql
index 353d769a5b..6246d89634 100644
--- a/src/test/regress/sql/collate.windows.win1252.sql
+++ b/src/test/regress/sql/collate.windows.win1252.sql
@@ -400,8 +400,6 @@ drop type textrange_en_us;
-- nondeterministic collations
-- (not supported with libc provider)
-
-CREATE COLLATION ctest_det (locale = 'en_US', deterministic = true);
CREATE COLLATION ctest_nondet (locale = 'en_US', deterministic = false);
fix-collate-windows-test+.patch (text/x-patch, 1.6K) download
diff --git a/src/test/regress/expected/collate.windows.win1252.out b/src/test/regress/expected/collate.windows.win1252.out
index b7b93959de..97cbfc86de 100644
--- a/src/test/regress/expected/collate.windows.win1252.out
+++ b/src/test/regress/expected/collate.windows.win1252.out
@@ -992,7 +992,13 @@ drop type textrange_c;
drop type textrange_en_us;
-- nondeterministic collations
-- (not supported with libc provider)
-CREATE COLLATION ctest_det (locale = 'en_US', deterministic = true);
+do $$
+BEGIN
+ EXECUTE 'CREATE COLLATION ctest_det (locale = ' ||
+ quote_literal((SELECT collcollate FROM pg_collation WHERE
+ collname = 'en_US')) || ', deterministic = true);';
+ END
+$$;
CREATE COLLATION ctest_nondet (locale = 'en_US', deterministic = false);
ERROR: nondeterministic collations not supported with this provider
-- cleanup
diff --git a/src/test/regress/sql/collate.windows.win1252.sql b/src/test/regress/sql/collate.windows.win1252.sql
index 353d769a5b..727d136f2f 100644
--- a/src/test/regress/sql/collate.windows.win1252.sql
+++ b/src/test/regress/sql/collate.windows.win1252.sql
@@ -400,8 +400,13 @@ drop type textrange_en_us;
-- nondeterministic collations
-- (not supported with libc provider)
-
-CREATE COLLATION ctest_det (locale = 'en_US', deterministic = true);
+do $$
+BEGIN
+ EXECUTE 'CREATE COLLATION ctest_det (locale = ' ||
+ quote_literal((SELECT collcollate FROM pg_collation WHERE
+ collname = 'en_US')) || ', deterministic = true);';
+ END
+$$;
CREATE COLLATION ctest_nondet (locale = 'en_US', deterministic = false);
* Re: broken master regress tests
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Re: broken master regress tests Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Re: broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Re: broken master regress tests Thomas Munro <thomas.munro@gmail.com>
2023-08-29 15:54 ` Re: broken master regress tests Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-09-12 02:23 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-10-11 00:08 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-10-11 00:54 ` Re: broken master regress tests Andres Freund <andres@anarazel.de>
2023-12-13 02:56 ` Re: broken master regress tests Noah Misch <noah@leadboat.com>
2023-12-21 01:48 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-12-21 23:17 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-12-28 15:00 ` Re: broken master regress tests Alexander Lakhin <exclusion@gmail.com>
2023-12-28 17:36 ` Re: broken master regress tests Jeff Davis <pgsql@j-davis.com>
2023-12-28 19:00 ` Re: broken master regress tests Alexander Lakhin <exclusion@gmail.com>
@ 2023-12-29 20:10 ` Jeff Davis <pgsql@j-davis.com>
0 siblings, 0 replies; 24+ messages in thread
From: Jeff Davis @ 2023-12-29 20:10 UTC (permalink / raw)
To: Alexander Lakhin <exclusion@gmail.com>; Noah Misch <noah@leadboat.com>; Andres Freund <andres@anarazel.de>; +Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>; Thomas Munro <thomas.munro@gmail.com>; Pavel Stehule <pavel.stehule@gmail.com>; Matthias van de Meent <boekewurm+postgres@gmail.com>; PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
On Thu, 2023-12-28 at 22:00 +0300, Alexander Lakhin wrote:
> But looking at the result with the comment above that "do" block, I
> wonder
> whether this successful CREATE COLLATION command is so important to
> perform
> it that tricky way, if we want to demonstrate that nondeterministic
> collations not supported.
Thank you, pushed this version. There are other similar commands in the
file, so I think it's fine. It exercises a specific locale that might
be different from datcollate.
Regards,
Jeff Davis
^ permalink raw reply [nested|flat] 24+ messages in thread
end of thread, other threads:[~2023-12-29 20:10 UTC | newest]
Thread overview: 24+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-08-25 03:53 broken master regress tests Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 05:37 ` Thomas Munro <thomas.munro@gmail.com>
2023-08-25 06:10 ` Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:17 ` Pavel Stehule <pavel.stehule@gmail.com>
2023-08-25 06:22 ` Matthias van de Meent <boekewurm+postgres@gmail.com>
2023-08-25 07:12 ` Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 15:02 ` Pavel Stehule <pavel.stehule@gmail.com>
2023-08-26 21:52 ` Thomas Munro <thomas.munro@gmail.com>
2023-08-27 03:37 ` Pavel Stehule <pavel.stehule@gmail.com>
2023-08-29 15:54 ` Alvaro Herrera <alvherre@alvh.no-ip.org>
2023-08-29 16:55 ` Pavel Stehule <pavel.stehule@gmail.com>
2023-09-12 02:23 ` Andres Freund <andres@anarazel.de>
2023-10-11 00:08 ` Jeff Davis <pgsql@j-davis.com>
2023-10-11 00:54 ` Andres Freund <andres@anarazel.de>
2023-10-17 03:10 ` Jeff Davis <pgsql@j-davis.com>
2023-12-13 02:56 ` Noah Misch <noah@leadboat.com>
2023-12-13 02:59 ` Tom Lane <tgl@sss.pgh.pa.us>
2023-12-21 01:48 ` Jeff Davis <pgsql@j-davis.com>
2023-12-21 23:17 ` Jeff Davis <pgsql@j-davis.com>
2023-12-23 20:35 ` Pavel Stehule <pavel.stehule@gmail.com>
2023-12-28 15:00 ` Alexander Lakhin <exclusion@gmail.com>
2023-12-28 17:36 ` Jeff Davis <pgsql@j-davis.com>
2023-12-28 19:00 ` Alexander Lakhin <exclusion@gmail.com>
2023-12-29 20:10 ` Jeff Davis <pgsql@j-davis.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox