agora inbox for pgsql-hackers@postgresql.orghelp / color / mirror / Atom feed
[PATCH 1/5] Make XLogReaderInvalReadState static. 1+ messages / 1 participants [nested] [flat]
* [PATCH 1/5] Make XLogReaderInvalReadState static. @ 2019-07-09 09:54 Antonin Houska <ah@cybertec.at> 0 siblings, 0 replies; 1+ messages in thread From: Antonin Houska @ 2019-07-09 09:54 UTC (permalink / raw) This change is not necessary for the XLogRead() refactoring itself, but I noticed the problem while working on it. Not sure it's worth a separate CF entry. --- src/backend/access/transam/xlogreader.c | 4 ++-- src/include/access/xlogreader.h | 4 ---- 2 files changed, 2 insertions(+), 6 deletions(-) diff --git a/src/backend/access/transam/xlogreader.c b/src/backend/access/transam/xlogreader.c index 41dae916b4..08bc9695c1 100644 --- a/src/backend/access/transam/xlogreader.c +++ b/src/backend/access/transam/xlogreader.c @@ -35,10 +35,10 @@ static bool ValidXLogRecordHeader(XLogReaderState *state, XLogRecPtr RecPtr, XLogRecPtr PrevRecPtr, XLogRecord *record, bool randAccess); static bool ValidXLogRecord(XLogReaderState *state, XLogRecord *record, XLogRecPtr recptr); +static void XLogReaderInvalReadState(XLogReaderState *state); static int ReadPageInternal(XLogReaderState *state, XLogRecPtr pageptr, int reqLen); static void report_invalid_record(XLogReaderState *state, const char *fmt,...) pg_attribute_printf(2, 3); - static void ResetDecoder(XLogReaderState *state); /* size of the buffer allocated for error message. */ @@ -620,7 +620,7 @@ err: /* * Invalidate the xlogreader's read state to force a re-read. */ -void +static void XLogReaderInvalReadState(XLogReaderState *state) { state->readSegNo = 0; diff --git a/src/include/access/xlogreader.h b/src/include/access/xlogreader.h index 04228e2a87..a3d3cc1e7b 100644 --- a/src/include/access/xlogreader.h +++ b/src/include/access/xlogreader.h @@ -212,13 +212,9 @@ extern struct XLogRecord *XLogReadRecord(XLogReaderState *state, extern bool XLogReaderValidatePageHeader(XLogReaderState *state, XLogRecPtr recptr, char *phdr); -/* Invalidate read state */ -extern void XLogReaderInvalReadState(XLogReaderState *state); - #ifdef FRONTEND extern XLogRecPtr XLogFindNextRecord(XLogReaderState *state, XLogRecPtr RecPtr); #endif /* FRONTEND */ - /* Functions for decoding an XLogRecord */ extern bool DecodeXLogRecord(XLogReaderState *state, XLogRecord *record, -- 2.16.4 --=-=-= Content-Type: text/x-diff Content-Disposition: attachment; filename=v04-0002-Remove-TLI-from-some-argument-lists.patch ^ permalink raw reply [nested|flat] 1+ messages in thread
only message in thread Thread overview: 1+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2019-07-09 09:54 [PATCH 1/5] Make XLogReaderInvalReadState static. Antonin Houska <ah@cybertec.at>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox