From: Martijn van Oosterhout <kleptog@svana.org>
To: Simon Riggs <simon@2ndquadrant.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Ron Peacetree <rjpeace@earthlink.net>
Cc: pgsql-hackers@postgresql.org
Subject: Re: [PERFORM] A Better External Sort?
Date: Tue, 4 Oct 2005 17:23:41 +0200
Message-ID: <20051004152336.GI17589@svana.org> (raw)
In-Reply-To: <1128437813.8603.305.camel@localhost.localdomain>
References: <29837.1128223567@sss.pgh.pa.us>
<20051002123240.GA30492@svana.org>
<20051002193835.GJ30492@svana.org>
<1128376292.8603.142.camel@localhost.localdomain>
<20051004100441.GC17589@svana.org>
<1128425094.8603.296.camel@localhost.localdomain>
<20051004122443.GF17589@svana.org>
<7788.1128434784@sss.pgh.pa.us>
<20051004143041.GH17589@svana.org>
<1128437813.8603.305.camel@localhost.localdomain>
On Tue, Oct 04, 2005 at 03:56:53PM +0100, Simon Riggs wrote:
> I've been using gcc 3.4 and saw no warning when using either "-Winline"
> or "-O3 -Winline".
Ok, I've just installed 3.4 and verified that. I examined the asm code
and gcc is inlining it. I concede, at this point just throw in -Winline
and monitor the situation.
As an aside, the *_getattr calls end up a bit suboptimal though. It's
producing code like:
cmp attlen, 4
je $elsewhere1
cmp attlen, 2
je $elsewhere2
ld byte
here:
--- much later ---
elsewhere1:
ld integer
jmp $here
elsewhere2:
ld short
jmp $here
No idea whether we want to go down the path of hinting to gcc which
size will be the most common.
Have a nice day,
--
Martijn van Oosterhout <kleptog@svana.org> http://svana.org/kleptog/> Patent. n. Genius is 5% inspiration and 95% perspiration. A patent is a
> tool for doing 5% of the work and then sitting around waiting for someone
> else to do the other 95% so you can sue them.
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-performance@postgresql.org
Cc: kleptog@svana.org, simon@2ndquadrant.com, tgl@sss.pgh.pa.us, rjpeace@earthlink.net, pgsql-hackers@postgresql.org
Subject: Re: [PERFORM] A Better External Sort?
In-Reply-To: <20051004152336.GI17589@svana.org>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox