public inbox for [email protected]
help / color / mirror / Atom feedpatch bug in 9.6 spec
3+ messages / 2 participants
[nested] [flat]
* patch bug in 9.6 spec
@ 2017-07-07 01:16 Martín Marqués <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Martín Marqués @ 2017-07-07 01:16 UTC (permalink / raw)
To: pgsql-pkg-yum
Hi,
I was making a custom build with a patch for 9.6 and found this which
seems to be a bug in the spec file of postgresql 9.6.3 src.rpm package:
%patch6 -p1
%if 0%{?rhel} && 0%{?rhel} <= 5
%patch7 -p1
%endif
Compilation passed because I'm using rhel7, but that patch doesn't exist
in the spec file, so if someone would have tried to compile it on rhel5
it would have failed.
I didn't do much digging on when it got there, but it seems it would be
good to remove it.
Regards,
--
Martín Marqués http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Training & Services
--
Sent via pgsql-pkg-yum mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-pkg-yum
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: patch bug in 9.6 spec
@ 2017-07-22 07:59 Devrim Gündüz <[email protected]>
parent: Martín Marqués <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Devrim Gündüz @ 2017-07-22 07:59 UTC (permalink / raw)
To: Martín Marqués <[email protected]>; pgsql-pkg-yum
Hi Martin,
On Thu, 2017-07-06 at 22:16 -0300, Martín Marqués wrote:
> I was making a custom build with a patch for 9.6 and found this which
> seems to be a bug in the spec file of postgresql 9.6.3 src.rpm package:
>
> %patch6 -p1
> %if 0%{?rhel} && 0%{?rhel} <= 5
> %patch7 -p1
> %endif
>
> Compilation passed because I'm using rhel7, but that patch doesn't exist
> in the spec file, so if someone would have tried to compile it on rhel5
> it would have failed.
>
> I didn't do much digging on when it got there, but it seems it would be
> good to remove it.
I think you are using an older version of the spec file -- this is from 9.6.3-2
changelog:
- Remove nonexistent Patch7 reference
I refactored the spec files recently, so please let me know if you see more
issues.
Regards,
--
Devrim Gündüz
EnterpriseDB: https://www.enterprisedb.com
PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: patch bug in 9.6 spec
@ 2017-07-22 10:20 Martín Marqués <[email protected]>
parent: Devrim Gündüz <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Martín Marqués @ 2017-07-22 10:20 UTC (permalink / raw)
To: Devrim Gündüz <[email protected]>; +Cc: pgsql-pkg-yum
Ok, I will check.
Thanks,
El 22 jul. 2017 4:59 AM, "Devrim Gündüz" <[email protected]> escribió:
>
> Hi Martin,
>
> On Thu, 2017-07-06 at 22:16 -0300, Martín Marqués wrote:
> > I was making a custom build with a patch for 9.6 and found this which
> > seems to be a bug in the spec file of postgresql 9.6.3 src.rpm package:
> >
> > %patch6 -p1
> > %if 0%{?rhel} && 0%{?rhel} <= 5
> > %patch7 -p1
> > %endif
> >
> > Compilation passed because I'm using rhel7, but that patch doesn't exist
> > in the spec file, so if someone would have tried to compile it on rhel5
> > it would have failed.
> >
> > I didn't do much digging on when it got there, but it seems it would be
> > good to remove it.
>
> I think you are using an older version of the spec file -- this is from
> 9.6.3-2
> changelog:
>
> - Remove nonexistent Patch7 reference
>
> I refactored the spec files recently, so please let me know if you see more
> issues.
>
> Regards,
> --
> Devrim Gündüz
> EnterpriseDB: https://www.enterprisedb.com
> PostgreSQL Danışmanı/Consultant, Red Hat Certified Engineer
> Twitter: @DevrimGunduz , @DevrimGunduzTR
>
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2017-07-22 10:20 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-07-07 01:16 patch bug in 9.6 spec Martín Marqués <[email protected]>
2017-07-22 07:59 ` Devrim Gündüz <[email protected]>
2017-07-22 10:20 ` Martín Marqués <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox