public inbox for [email protected]
help / color / mirror / Atom feedplease build packages --with-lz4
8+ messages / 4 participants
[nested] [flat]
* please build packages --with-lz4
@ 2021-03-22 02:03 Justin Pryzby <[email protected]>
2021-03-22 14:45 ` Re: please build packages --with-lz4 Stephen Frost <[email protected]>
2021-03-22 16:03 ` Re: please build packages --with-lz4 Devrim Gündüz <[email protected]>
0 siblings, 2 replies; 8+ messages in thread
From: Justin Pryzby @ 2021-03-22 02:03 UTC (permalink / raw)
To: Devrim Gündüz <[email protected]>; +Cc: pgsql-pkg-yum
Would you plan to build packages --with-lz4 ?
See commit bbe0a81db69bd10bd166907c3701492a29aca294
Allow configurable LZ4 TOAST compression.
Also, a reminder about this old thread.
The devel packages should be built with a versions like (I think)
0.1.14.0-alpha*
postgresql14.x86_64 14-alpha_20210322_PGDG.rhel7 pgdg14-updates-testing
On Thu, Apr 09, 2020 at 11:56:01AM -0500, Justin Pryzby wrote:
> On Thu, 2019-05-23 at 09:55 -0500, Justin Pryzby wrote:
> > > I'm wondering how versioning on PGDG RPMs is intended to work.
> > > Yum seems to thinks that the "nightly builds" are of higher version number
> > > than beta.
> > > [pryzbyj@dev ~]$ yum list --enablerepo='pgdg12-updates-testing' --showdu postgresql12
> > > Installed Packages postgresql12.x86_64 12.0-1devel_20190502_1PGDG.rhel7 @pgdg12-updates-testing
> > > Available Packages postgresql12.x86_64 12beta1-1PGDG.rhel7 pgdg12-updates-testing
>
> On Thu, Jun 06, 2019 at 11:15:58AM +0100, Devrim Gündüz wrote:
> > Oops, I did it again :-( Let's review this once we start releasing 13 devel
> > RPMs after summer.
>
> On Thu, Apr 09, 2020 at 12:24:29AM +0100, Devrim Gündüz wrote:
> > On Wed, 2020-04-08 at 10:47 -0500, Justin Pryzby wrote:
> > > A reminder about this.
> > > The versions should sort like:
> > >
> > > nightly build < beta < rc < released
> >
> > Can you please send a patch?
>
> I'm sorry, but I don't know anything about building RPMs.
>
> When I mentioned last year, it looked like:
> > > postgresql12.x86_64 12.0-1devel_20190502_1PGDG.rhel7 @pgdg12-updates-testing
> > > postgresql12.x86_64 12beta1-1PGDG.rhel7 pgdg12-updates-testing
>
> That's an issue since "12" sorts lower than "12beta1", which means that the
> devel => beta upgrade didn't work correctly (I don't remember, but that maybe
> also broke the beta/rc => 13.0 release upgrade).
>
> The curent package looks like:
> postgresql13.x86_64 13.0-20200407_devel_1PGDG.rhel7 @pgdg13-updates-testing
>
> I think that will be an issue again when you release beta1, unless you name it
> something weird like 20200601beta1.
>
> I found:
> https://docs.fedoraproject.org/en-US/packaging-guidelines/Versioning/
> |Prerelease versions
> |In the Version: tag, use the version that upstream has determined the next release will be. For the field of the Release: tag, use a number of the form "0.N" where N is an integer beginning with 1 and increasing for each revision of the package. Prerelease versions MUST use a Release: tag strictly less than 1, as this is the sole indicator that a prerelease has been packaged.
>
> So I *think* the devel release should be called something like this with a
> leading "0.0":
>
> postgresql13-13.0.0.20200407git[...]
>
> And then beta1 can use a leading "0.1" or (according to that doc) "~":
> postgresql13-13.0.1.beta1
> postgresql13-13.0~beta1
>
> "r" follows "b" so "rc" will work right using the same convention.
> postgresql13-13.0.1.rc1
> postgresql13-13.0~rc1
>
> And then I think it's finally released as:
> postgresql13-13.0 (here, the "release tag" is 1):
>
> --
> Justin
--
Justin Pryzby
System Administrator
Telsasoft
+1-952-707-8581
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: please build packages --with-lz4
2021-03-22 02:03 please build packages --with-lz4 Justin Pryzby <[email protected]>
@ 2021-03-22 14:45 ` Stephen Frost <[email protected]>
2021-03-22 15:20 ` Re: please build packages --with-lz4 Justin Pryzby <[email protected]>
2021-03-22 16:05 ` Re: please build packages --with-lz4 Devrim Gündüz <[email protected]>
1 sibling, 2 replies; 8+ messages in thread
From: Stephen Frost @ 2021-03-22 14:45 UTC (permalink / raw)
To: Justin Pryzby <[email protected]>; +Cc: Devrim Gündüz <[email protected]>; pgsql-pkg-yum
Greetings,
* Justin Pryzby ([email protected]) wrote:
> Would you plan to build packages --with-lz4 ?
>
> See commit bbe0a81db69bd10bd166907c3701492a29aca294
> Allow configurable LZ4 TOAST compression.
>
> Also, a reminder about this old thread.
> The devel packages should be built with a versions like (I think)
> 0.1.14.0-alpha*
I have to wonder why we aren't just automatically checking if lz4 is
available and enabling it when it is...
Thanks,
Stephen
Attachments:
[application/pgp-signature] signature.asc (819B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: please build packages --with-lz4
2021-03-22 02:03 please build packages --with-lz4 Justin Pryzby <[email protected]>
2021-03-22 14:45 ` Re: please build packages --with-lz4 Stephen Frost <[email protected]>
@ 2021-03-22 15:20 ` Justin Pryzby <[email protected]>
2021-03-22 15:58 ` Re: please build packages --with-lz4 Stephen Frost <[email protected]>
2021-03-23 11:59 ` Re: please build packages --with-lz4 Christoph Berg <[email protected]>
1 sibling, 2 replies; 8+ messages in thread
From: Justin Pryzby @ 2021-03-22 15:20 UTC (permalink / raw)
To: Stephen Frost <[email protected]>; +Cc: Devrim Gündüz <[email protected]>; pgsql-pkg-yum
On Mon, Mar 22, 2021 at 10:45:08AM -0400, Stephen Frost wrote:
> Greetings,
>
> * Justin Pryzby ([email protected]) wrote:
> > Would you plan to build packages --with-lz4 ?
> >
> > See commit bbe0a81db69bd10bd166907c3701492a29aca294
> > Allow configurable LZ4 TOAST compression.
> >
> > Also, a reminder about this old thread.
> > The devel packages should be built with a versions like (I think)
> > 0.1.14.0-alpha*
>
> I have to wonder why we aren't just automatically checking if lz4 is
> available and enabling it when it is...
I assume you mean at compile time, regarding autoconf macros ?
This probably doesn't apply to PGDG, but as I recall at least within debian,
there's a preference to build either --with-... or --without-.., so that a
library which happens to be installed doesn't create a package with an
unintentional dependency, or a library which is not installed or something
broken/incompatible doesn't result in a package without the intended
dependency.
--
Justin
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: please build packages --with-lz4
2021-03-22 02:03 please build packages --with-lz4 Justin Pryzby <[email protected]>
2021-03-22 14:45 ` Re: please build packages --with-lz4 Stephen Frost <[email protected]>
2021-03-22 15:20 ` Re: please build packages --with-lz4 Justin Pryzby <[email protected]>
@ 2021-03-22 15:58 ` Stephen Frost <[email protected]>
1 sibling, 0 replies; 8+ messages in thread
From: Stephen Frost @ 2021-03-22 15:58 UTC (permalink / raw)
To: Justin Pryzby <[email protected]>; +Cc: Devrim Gündüz <[email protected]>; pgsql-pkg-yum
Greetings,
* Justin Pryzby ([email protected]) wrote:
> On Mon, Mar 22, 2021 at 10:45:08AM -0400, Stephen Frost wrote:
> > * Justin Pryzby ([email protected]) wrote:
> > > Would you plan to build packages --with-lz4 ?
> > >
> > > See commit bbe0a81db69bd10bd166907c3701492a29aca294
> > > Allow configurable LZ4 TOAST compression.
> > >
> > > Also, a reminder about this old thread.
> > > The devel packages should be built with a versions like (I think)
> > > 0.1.14.0-alpha*
> >
> > I have to wonder why we aren't just automatically checking if lz4 is
> > available and enabling it when it is...
>
> I assume you mean at compile time, regarding autoconf macros ?
Yes, talking about picking things up at compile time.
> This probably doesn't apply to PGDG, but as I recall at least within debian,
> there's a preference to build either --with-... or --without-.., so that a
> library which happens to be installed doesn't create a package with an
> unintentional dependency, or a library which is not installed or something
> broken/incompatible doesn't result in a package without the intended
> dependency.
I'm just voicing my annoyence that we don't just automatically pick
things up when they're available- sure, packagers might want to go
through and add --without-whatever in situations where they don't want
something, but making everyone have to go add --with-whatever whenever
we add new dependencies doesn't strike me as useful.
Thanks,
Stephen
Attachments:
[application/pgp-signature] signature.asc (819B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: please build packages --with-lz4
2021-03-22 02:03 please build packages --with-lz4 Justin Pryzby <[email protected]>
2021-03-22 14:45 ` Re: please build packages --with-lz4 Stephen Frost <[email protected]>
2021-03-22 15:20 ` Re: please build packages --with-lz4 Justin Pryzby <[email protected]>
@ 2021-03-23 11:59 ` Christoph Berg <[email protected]>
1 sibling, 0 replies; 8+ messages in thread
From: Christoph Berg @ 2021-03-23 11:59 UTC (permalink / raw)
To: Justin Pryzby <[email protected]>; +Cc: Stephen Frost <[email protected]>; Devrim Gündüz <[email protected]>; pgsql-pkg-yum
Re: Justin Pryzby
> > I have to wonder why we aren't just automatically checking if lz4 is
> > available and enabling it when it is...
>
> I assume you mean at compile time, regarding autoconf macros ?
>
> This probably doesn't apply to PGDG, but as I recall at least within debian,
> there's a preference to build either --with-... or --without-.., so that a
> library which happens to be installed doesn't create a package with an
> unintentional dependency, or a library which is not installed or something
> broken/incompatible doesn't result in a package without the intended
> dependency.
There is some value in making explicit statements in configure flags,
but if the package declares "Build-Depends: liblz4-dev" and then
configure picks that up automatically, there is not that much room for
unwanted surprises.
If we chose to deliberately go without lz4 support I'd in fact put a
--without-lz4 into the list of options.
The deeper question here is I guess, if lz4 is better than pglz, and
besides why isn't --with-lz4 the default, why isn't it the default for
all columns but needs some obsure GUC set?
Christoph
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: please build packages --with-lz4
2021-03-22 02:03 please build packages --with-lz4 Justin Pryzby <[email protected]>
2021-03-22 14:45 ` Re: please build packages --with-lz4 Stephen Frost <[email protected]>
@ 2021-03-22 16:05 ` Devrim Gündüz <[email protected]>
2021-03-22 16:06 ` Re: please build packages --with-lz4 Stephen Frost <[email protected]>
1 sibling, 1 reply; 8+ messages in thread
From: Devrim Gündüz @ 2021-03-22 16:05 UTC (permalink / raw)
To: Stephen Frost <[email protected]>; Justin Pryzby <[email protected]>; +Cc: pgsql-pkg-yum
Hi,
On Mon, 2021-03-22 at 10:45 -0400, Stephen Frost wrote:
> I have to wonder why we aren't just automatically checking if lz4 is
> available and enabling it when it is...
We also need to dependencies, maybe some new files to the spec file. It
is not just adding --with-foobar:
https://git.postgresql.org/gitweb/?p=pgrpms.git;a=blobdiff;f=rpm/redhat/master/non-common/postgresql...
Regards,
--
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: please build packages --with-lz4
2021-03-22 02:03 please build packages --with-lz4 Justin Pryzby <[email protected]>
2021-03-22 14:45 ` Re: please build packages --with-lz4 Stephen Frost <[email protected]>
2021-03-22 16:05 ` Re: please build packages --with-lz4 Devrim Gündüz <[email protected]>
@ 2021-03-22 16:06 ` Stephen Frost <[email protected]>
0 siblings, 0 replies; 8+ messages in thread
From: Stephen Frost @ 2021-03-22 16:06 UTC (permalink / raw)
To: Devrim Gündüz <[email protected]>; +Cc: Justin Pryzby <[email protected]>; pgsql-pkg-yum
Greetings,
* Devrim Gündüz ([email protected]) wrote:
> On Mon, 2021-03-22 at 10:45 -0400, Stephen Frost wrote:
> > I have to wonder why we aren't just automatically checking if lz4 is
> > available and enabling it when it is...
>
> We also need to dependencies, maybe some new files to the spec file. It
> is not just adding --with-foobar:
Sure, of course, not saying that you wouldn't need to do those other
things, just seems unnecessary for PG itself to require the --with bit,
but I suppose that's just how it is. Just annoying imv.
Thanks,
Stephen
Attachments:
[application/pgp-signature] signature.asc (819B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 8+ messages in thread
* Re: please build packages --with-lz4
2021-03-22 02:03 please build packages --with-lz4 Justin Pryzby <[email protected]>
@ 2021-03-22 16:03 ` Devrim Gündüz <[email protected]>
1 sibling, 0 replies; 8+ messages in thread
From: Devrim Gündüz @ 2021-03-22 16:03 UTC (permalink / raw)
To: Justin Pryzby <[email protected]>; +Cc: pgsql-pkg-yum
Hi Justin,
On Sun, 2021-03-21 at 21:03 -0500, Justin Pryzby wrote:
> Would you plan to build packages --with-lz4 ?
Already done, about 1h before you sent the email :) Latest snapshot
RPMs are built with lz4 compression support.
Regards,
--
Devrim Gündüz
Open Source Solution Architect, Red Hat Certified Engineer
Twitter: @DevrimGunduz , @DevrimGunduzTR
Attachments:
[application/pgp-signature] signature.asc (833B, 2-signature.asc)
download
^ permalink raw reply [nested|flat] 8+ messages in thread
end of thread, other threads:[~2021-03-23 11:59 UTC | newest]
Thread overview: 8+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2021-03-22 02:03 please build packages --with-lz4 Justin Pryzby <[email protected]>
2021-03-22 14:45 ` Stephen Frost <[email protected]>
2021-03-22 15:20 ` Justin Pryzby <[email protected]>
2021-03-22 15:58 ` Stephen Frost <[email protected]>
2021-03-23 11:59 ` Christoph Berg <[email protected]>
2021-03-22 16:05 ` Devrim Gündüz <[email protected]>
2021-03-22 16:06 ` Stephen Frost <[email protected]>
2021-03-22 16:03 ` Devrim Gündüz <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox