pg.ddx.io pgsql-rrreviewers@postgresql.org mailing list archive
help / color / mirror / Atom feedreviewers needed!
14+ messages / 7 participants
[nested] [flat]
* reviewers needed!
@ 2011-01-12 02:17 Robert Haas <robertmhaas@gmail.com>
2011-01-13 21:54 ` Re: reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-16 19:30 ` Re: [HACKERS] reviewers needed! Andy Colson <andy@squeakycode.net>
0 siblings, 2 replies; 14+ messages in thread
From: Robert Haas @ 2011-01-12 02:17 UTC (permalink / raw)
To: pgsql-hackers@postgresql.org; pgsql-rrreviewers
We have 46 patches in this CommitFest so far and I know that there are
quite a few patches that have been posted but not added to the
CommitFest application yet (please fix this, if you are a patch author
who has failed to do this) and that there will be lots more patches
posted over the next few days. I expect that we will have at least 60
patches in the CommitFest, maybe 75 or more. These patches *will not*
review themselves. If you're available to review for this final
CommitFest (and if you've submitted any patches to it, you should make
yourself available to review as well), then please either sign up for
some patches, or (better) email me off-list and I will assign you a
patch. You don't need to be an experienced patch reviewer (although
if you are, your help is even-more-appreciated) or even an experienced
C programmer, but you do need to be willing to:
(1) test the patch and comment on what you think is good and bad about it,
(2) read the code to the extent you are able and comment on what you
think is good and bad about that, even if it's just "the formatting is
all wrong",
(3) do (1) and (2) in a timely fashion so that the patch author has
time to update it,
(4) prod the patch author if s/he does not respond to your review comments, and
(5) keep the commitfest application up to date with respect to your
chosen/assigned patch.
See also http://wiki.postgresql.org/wiki/Reviewing_a_Patch
As I'm sure everyone is aware, this is the LAST CommitFest for 9.1 and
we have a TON of patches, many of them large and important, to review.
Please help however you can.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: reviewers needed!
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
@ 2011-01-13 21:54 ` Robert Haas <robertmhaas@gmail.com>
2011-01-13 21:58 ` Re: [HACKERS] reviewers needed! Josh Berkus <josh@agliodbs.com>
2011-01-13 23:13 ` Re: reviewers needed! Jeff Davis <pgsql@j-davis.com>
2011-01-14 10:34 ` Re: reviewers needed! Dimitri Fontaine <dimitri@2ndQuadrant.fr>
2011-01-14 12:10 ` Re: reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-15 11:31 ` Re: reviewers needed! Dimitri Fontaine <dimitri@2ndQuadrant.fr>
1 sibling, 5 replies; 14+ messages in thread
From: Robert Haas @ 2011-01-13 21:54 UTC (permalink / raw)
To: pgsql-hackers@postgresql.org; pgsql-rrreviewers
On Tue, Jan 11, 2011 at 9:17 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> [ abject plea for reviewers ]
So far I have 6 people who have volunteered to be round-robin
reviewers, and 7 people who are listed as reviewers on the CF site
already. That leaves 45 patches without a reviewer, plus whatever
comes in in the next day or so. This is not going to work unless a
lot more people pitch in.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [HACKERS] reviewers needed!
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-13 21:54 ` Re: reviewers needed! Robert Haas <robertmhaas@gmail.com>
@ 2011-01-13 21:58 ` Josh Berkus <josh@agliodbs.com>
4 siblings, 0 replies; 14+ messages in thread
From: Josh Berkus @ 2011-01-13 21:58 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-hackers@postgresql.org; pgsql-rrreviewers
> So far I have 6 people who have volunteered to be round-robin
> reviewers, and 7 people who are listed as reviewers on the CF site
> already. That leaves 45 patches without a reviewer, plus whatever
> comes in in the next day or so. This is not going to work unless a
> lot more people pitch in.
I'll be joining as an RRR on the 24th. I'm too booked before then.
--
-- Josh Berkus
PostgreSQL Experts Inc.
http://www.pgexperts.com
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: reviewers needed!
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-13 21:54 ` Re: reviewers needed! Robert Haas <robertmhaas@gmail.com>
@ 2011-01-13 23:13 ` Jeff Davis <pgsql@j-davis.com>
4 siblings, 0 replies; 14+ messages in thread
From: Jeff Davis @ 2011-01-13 23:13 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-rrreviewers
On Thu, 2011-01-13 at 16:54 -0500, Robert Haas wrote:
> On Tue, Jan 11, 2011 at 9:17 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> > [ abject plea for reviewers ]
>
> So far I have 6 people who have volunteered to be round-robin
> reviewers, and 7 people who are listed as reviewers on the CF site
> already. That leaves 45 patches without a reviewer, plus whatever
> comes in in the next day or so. This is not going to work unless a
> lot more people pitch in.
I signed up to review Kevin's patch, which I reviewed the last time
around.
Regards,
Jeff Davis
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: reviewers needed!
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-13 21:54 ` Re: reviewers needed! Robert Haas <robertmhaas@gmail.com>
@ 2011-01-14 10:34 ` Dimitri Fontaine <dimitri@2ndQuadrant.fr>
4 siblings, 0 replies; 14+ messages in thread
From: Dimitri Fontaine @ 2011-01-14 10:34 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-hackers@postgresql.org; pgsql-rrreviewers
Robert Haas <robertmhaas@gmail.com> writes:
> So far I have 6 people who have volunteered to be round-robin
> reviewers, and 7 people who are listed as reviewers on the CF site
> already. That leaves 45 patches without a reviewer, plus whatever
> comes in in the next day or so. This is not going to work unless a
> lot more people pitch in.
I will enroll later this week-end or early next week, have some other
duties meanwhile.
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: reviewers needed!
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-13 21:54 ` Re: reviewers needed! Robert Haas <robertmhaas@gmail.com>
@ 2011-01-14 12:10 ` Robert Haas <robertmhaas@gmail.com>
4 siblings, 0 replies; 14+ messages in thread
From: Robert Haas @ 2011-01-14 12:10 UTC (permalink / raw)
To: pgsql-hackers@postgresql.org; pgsql-rrreviewers
On Thu, Jan 13, 2011 at 4:54 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Tue, Jan 11, 2011 at 9:17 PM, Robert Haas <robertmhaas@gmail.com> wrote:
>> [ abject plea for reviewers ]
>
> [ second abject please for reviewers ]
OK, I believe I've sent an off-list email to everyone who volunteered
to review and asked me to assign them a patch, which totaled 11
people.
If you got an email of this type, and the patch you were assigned is
OK, then please go to commitfest.postgresql.org, edit your patch, and
put your name next to it so other people know you've grabbed it. Then
review it and post your review on -hackers. Then add a comment to the
patch with your review and mark it as either Waiting on Author or
Ready for Committer.
If you did not get an email of this type and want one, email me and
I'll assign you a patch.
If you are a committer or an experience reviewer looking for a
challenge, please pick up a "hard" patch and review it, as many people
are not up to picking these up. Some good choices: Change
pg_last_xlog_receive_location not to move backwards (is this safe?),
SSPI client auth on non-Windows systems (needs Windows expertise), FDW
API (complicated), Range Types (also complicated), ALTER EXTENSION
UPGRADE (needs design comments as well as code review).
At this point, our goal should be to get all patches that are marked
as "Needs Review" to either "Waiting on Author" or "Ready for
Committer" as quickly as possible. All help is appreciated!
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: reviewers needed!
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-13 21:54 ` Re: reviewers needed! Robert Haas <robertmhaas@gmail.com>
@ 2011-01-15 11:31 ` Dimitri Fontaine <dimitri@2ndQuadrant.fr>
4 siblings, 0 replies; 14+ messages in thread
From: Dimitri Fontaine @ 2011-01-15 11:31 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-hackers@postgresql.org, pgsql-rrreviewers@postgresql.org, Alvaro Herrera <alvherre@alvh.no-ip.org>; Magnus Hagander <magnus@hagander.net>
Robert Haas <robertmhaas@gmail.com> writes:
> lot more people pitch in.
I just assigned myself the review of those two patches:
https://commitfest.postgresql.org/action/patch_view?id=475
Streaming base backups
https://commitfest.postgresql.org/action/patch_view?id=502
FOR KEY LOCK foreign keys
I think I'll post reviews sometime next week, it would be a surprise if
that happens sooner than Tuesday. Depending on how the extension review
goes I might have some more time later in the CF, of course.
Regards,
--
Dimitri Fontaine
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [HACKERS] reviewers needed!
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
@ 2011-01-16 19:30 ` Andy Colson <andy@squeakycode.net>
2011-01-16 21:13 ` Re: [HACKERS] reviewers needed! Euler Taveira de Oliveira <euler@timbira.com>
2011-01-16 22:10 ` Re: [HACKERS] reviewers needed! Robert Haas <robertmhaas@gmail.com>
1 sibling, 2 replies; 14+ messages in thread
From: Andy Colson @ 2011-01-16 19:30 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-hackers@postgresql.org; pgsql-rrreviewers
I reviewed a couple patched, and I added my review to the commitfest page.
If I find a problem, its obvious I should mark the patch as "returned with feedback".
But what if I'm happy with it? I'm not a hacker so cannot do C code review, should I leave it alone? Mark it as "ready for committer"?
I marked my two reviews as ready for committer, but I feel like I've overstepped my bounds.
-Andy
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [HACKERS] reviewers needed!
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-16 19:30 ` Re: [HACKERS] reviewers needed! Andy Colson <andy@squeakycode.net>
@ 2011-01-16 21:13 ` Euler Taveira de Oliveira <euler@timbira.com>
1 sibling, 0 replies; 14+ messages in thread
From: Euler Taveira de Oliveira @ 2011-01-16 21:13 UTC (permalink / raw)
To: Andy Colson <andy@squeakycode.net>; +Cc: Robert Haas <robertmhaas@gmail.com>; pgsql-hackers@postgresql.org; pgsql-rrreviewers
Em 16-01-2011 16:30, Andy Colson escreveu:
> I reviewed a couple patched, and I added my review to the commitfest page.
>
> If I find a problem, its obvious I should mark the patch as "returned
> with feedback".
>
> But what if I'm happy with it? I'm not a hacker so cannot do C code
> review, should I leave it alone? Mark it as "ready for committer"?
>
Did you take a look at [1]? If your patch involves C code and you're not C
proficient then there must be another reviewer to give his/her opinion (of
course, the other person could be the committer). I wouldn't mark it "ready
for committer" instead leave it as is ("needs review"); just be sure to add
your comments in the commitfest app.
[1] http://wiki.postgresql.org/wiki/RRReviewers
--
Euler Taveira de Oliveira
http://www.timbira.com/
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [HACKERS] reviewers needed!
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-16 19:30 ` Re: [HACKERS] reviewers needed! Andy Colson <andy@squeakycode.net>
@ 2011-01-16 22:10 ` Robert Haas <robertmhaas@gmail.com>
2011-01-26 18:21 ` Re: [HACKERS] reviewers needed! Ibrar Ahmed <ibrar.ahmad@gmail.com>
1 sibling, 1 reply; 14+ messages in thread
From: Robert Haas @ 2011-01-16 22:10 UTC (permalink / raw)
To: Andy Colson <andy@squeakycode.net>; +Cc: pgsql-hackers@postgresql.org; pgsql-rrreviewers
On Sun, Jan 16, 2011 at 2:30 PM, Andy Colson <andy@squeakycode.net> wrote:
> I reviewed a couple patched, and I added my review to the commitfest page.
>
> If I find a problem, its obvious I should mark the patch as "returned with
> feedback".
Only if it's got sufficiently serious flaws that getting it committed
during this CommitFest is not practical. If it just needs some
revision, "Waiting on Author" is the right place.
> But what if I'm happy with it? I'm not a hacker so cannot do C code review,
> should I leave it alone? Mark it as "ready for committer"?
Yep, that's fine.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [HACKERS] reviewers needed!
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-16 19:30 ` Re: [HACKERS] reviewers needed! Andy Colson <andy@squeakycode.net>
2011-01-16 22:10 ` Re: [HACKERS] reviewers needed! Robert Haas <robertmhaas@gmail.com>
@ 2011-01-26 18:21 ` Ibrar Ahmed <ibrar.ahmad@gmail.com>
2011-01-27 16:42 ` Re: [HACKERS] reviewers needed! Robert Haas <robertmhaas@gmail.com>
0 siblings, 1 reply; 14+ messages in thread
From: Ibrar Ahmed @ 2011-01-26 18:21 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-rrreviewers
Hi!
I can join as an RRR, if its still needed.
--
Ibrar Ahmed
EnterpriseDB Corporation
The Enterprise Postgres Company
On Mon, Jan 17, 2011 at 3:10 AM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Sun, Jan 16, 2011 at 2:30 PM, Andy Colson <andy@squeakycode.net> wrote:
>> I reviewed a couple patched, and I added my review to the commitfest page.
>>
>> If I find a problem, its obvious I should mark the patch as "returned with
>> feedback".
>
> Only if it's got sufficiently serious flaws that getting it committed
> during this CommitFest is not practical. If it just needs some
> revision, "Waiting on Author" is the right place.
>
>> But what if I'm happy with it? I'm not a hacker so cannot do C code review,
>> should I leave it alone? Mark it as "ready for committer"?
>
> Yep, that's fine.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
> --
> Sent via pgsql-rrreviewers mailing list (pgsql-rrreviewers@postgresql.org)
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgsql-rrreviewers
>
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [HACKERS] reviewers needed!
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-16 19:30 ` Re: [HACKERS] reviewers needed! Andy Colson <andy@squeakycode.net>
2011-01-16 22:10 ` Re: [HACKERS] reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-26 18:21 ` Re: [HACKERS] reviewers needed! Ibrar Ahmed <ibrar.ahmad@gmail.com>
@ 2011-01-27 16:42 ` Robert Haas <robertmhaas@gmail.com>
2011-02-16 15:16 ` Re: [HACKERS] reviewers needed! Ibrar Ahmed <ibrar.ahmad@gmail.com>
0 siblings, 1 reply; 14+ messages in thread
From: Robert Haas @ 2011-01-27 16:42 UTC (permalink / raw)
To: Ibrar Ahmed <ibrar.ahmad@gmail.com>; +Cc: pgsql-rrreviewers
On Wed, Jan 26, 2011 at 1:21 PM, Ibrar Ahmed <ibrar.ahmad@gmail.com> wrote:
> I can join as an RRR, if its still needed.
Yep. Perhaps you could take a look at:
determining client_encoding from client locale
https://commitfest.postgresql.org/action/patch_view?id=503
It may be that the status in the CF app is out of date, so the first
thing to do is review any discussion that's happened already.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [HACKERS] reviewers needed!
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-16 19:30 ` Re: [HACKERS] reviewers needed! Andy Colson <andy@squeakycode.net>
2011-01-16 22:10 ` Re: [HACKERS] reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-26 18:21 ` Re: [HACKERS] reviewers needed! Ibrar Ahmed <ibrar.ahmad@gmail.com>
2011-01-27 16:42 ` Re: [HACKERS] reviewers needed! Robert Haas <robertmhaas@gmail.com>
@ 2011-02-16 15:16 ` Ibrar Ahmed <ibrar.ahmad@gmail.com>
2011-02-16 15:36 ` Re: [HACKERS] reviewers needed! Robert Haas <robertmhaas@gmail.com>
0 siblings, 1 reply; 14+ messages in thread
From: Ibrar Ahmed @ 2011-02-16 15:16 UTC (permalink / raw)
To: Robert Haas <robertmhaas@gmail.com>; +Cc: pgsql-rrreviewers
Its done now, can I have one more?
On Thu, Jan 27, 2011 at 9:42 PM, Robert Haas <robertmhaas@gmail.com> wrote:
> On Wed, Jan 26, 2011 at 1:21 PM, Ibrar Ahmed <ibrar.ahmad@gmail.com>
> wrote:
> > I can join as an RRR, if its still needed.
>
> Yep. Perhaps you could take a look at:
>
> determining client_encoding from client locale
> https://commitfest.postgresql.org/action/patch_view?id=503
>
> It may be that the status in the CF app is out of date, so the first
> thing to do is review any discussion that's happened already.
>
> --
> Robert Haas
> EnterpriseDB: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
Ibrar Ahmed
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: [HACKERS] reviewers needed!
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-16 19:30 ` Re: [HACKERS] reviewers needed! Andy Colson <andy@squeakycode.net>
2011-01-16 22:10 ` Re: [HACKERS] reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-26 18:21 ` Re: [HACKERS] reviewers needed! Ibrar Ahmed <ibrar.ahmad@gmail.com>
2011-01-27 16:42 ` Re: [HACKERS] reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-02-16 15:16 ` Re: [HACKERS] reviewers needed! Ibrar Ahmed <ibrar.ahmad@gmail.com>
@ 2011-02-16 15:36 ` Robert Haas <robertmhaas@gmail.com>
0 siblings, 0 replies; 14+ messages in thread
From: Robert Haas @ 2011-02-16 15:36 UTC (permalink / raw)
To: Ibrar Ahmed <ibrar.ahmad@gmail.com>; +Cc: pgsql-rrreviewers
On Wed, Feb 16, 2011 at 10:16 AM, Ibrar Ahmed <ibrar.ahmad@gmail.com> wrote:
> Its done now, can I have one more?
There's not really much left, but it would be helpful if you (and
others) could participate in the discussion of the patches that are
still being discussed.
--
Robert Haas
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 14+ messages in thread
end of thread, other threads:[~2011-02-16 15:36 UTC | newest]
Thread overview: 14+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2011-01-12 02:17 reviewers needed! Robert Haas <robertmhaas@gmail.com>
2011-01-13 21:54 ` Robert Haas <robertmhaas@gmail.com>
2011-01-13 21:58 ` Josh Berkus <josh@agliodbs.com>
2011-01-13 23:13 ` Jeff Davis <pgsql@j-davis.com>
2011-01-14 10:34 ` Dimitri Fontaine <dimitri@2ndQuadrant.fr>
2011-01-14 12:10 ` Robert Haas <robertmhaas@gmail.com>
2011-01-15 11:31 ` Dimitri Fontaine <dimitri@2ndQuadrant.fr>
2011-01-16 19:30 ` Andy Colson <andy@squeakycode.net>
2011-01-16 21:13 ` Euler Taveira de Oliveira <euler@timbira.com>
2011-01-16 22:10 ` Robert Haas <robertmhaas@gmail.com>
2011-01-26 18:21 ` Ibrar Ahmed <ibrar.ahmad@gmail.com>
2011-01-27 16:42 ` Robert Haas <robertmhaas@gmail.com>
2011-02-16 15:16 ` Ibrar Ahmed <ibrar.ahmad@gmail.com>
2011-02-16 15:36 ` Robert Haas <robertmhaas@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox