From: Tom Lane <tgl@sss.pgh.pa.us>
To: Jeff Davis <pgsql@j-davis.com>
Cc: oleg@sai.msu.su, Denis de Bernardy <ddebernardy@yahoo.com>
Cc: Teodor Sigaev <teodor@sigaev.ru>
Cc: pgsql-bugs@postgresql.org
Subject: Re: Re: PG regression with row comparison when btree_gist is enabled (BUG)
Date: Wed, 06 Jul 2011 13:25:53 -0400
Message-ID: <13404.1309973153@sss.pgh.pa.us> (raw)
In-Reply-To: <1309971611.3012.121.camel@jdavis>
References: <4DF81BA0.3000601@archidevsys.co.nz>
<743036.48052.qm@web112401.mail.gq1.yahoo.com>
<366790.65150.qm@web112414.mail.gq1.yahoo.com>
<BANLkTikm9Q_z1aYCB9U_Pc0tPTO+LzG57Q@mail.gmail.com>
<1308428403.2597.66.camel@jdavis>
<1308504190.2597.71.camel@jdavis>
<21086.1309646333@sss.pgh.pa.us>
<1309886656.3012.83.camel@jdavis>
<21432.1309888581@sss.pgh.pa.us>
<1309971611.3012.121.camel@jdavis>
Jeff Davis <pgsql@j-davis.com> writes:
> On Tue, 2011-07-05 at 13:56 -0400, Tom Lane wrote:
>> Yeah, I had been thinking along the same lines. It will require
>> duplicating the search loop, which is a bit annoying, but perhaps that
>> could be factored out as a subroutine.
> Patch attached. The logic in predtest.c was a little more complex, and I
> don't think we have a lot of test coverage in this area (and I didn't
> see an easy way to add many tests), so this will need some review.
Actually, I'd just been working on this myself. I think the cleanest
solution will be to get rid of the duplicative logic by making
predtest.c use get_op_btree_interpretation(). That will require
changing get_op_btree_interpretation() so it can return amoplefttype
and amoprighttype too, but given the small number of callers, an API
change for it doesn't seem like a problem.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-testers@postgresql.org
Cc: tgl@sss.pgh.pa.us, pgsql@j-davis.com, ddebernardy@yahoo.com, teodor@sigaev.ru, pgsql-bugs@postgresql.org
Subject: Re: PG regression with row comparison when btree_gist is enabled (BUG)
In-Reply-To: <13404.1309973153@sss.pgh.pa.us>
References: <4DF81BA0.3000601@archidevsys.co.nz> <743036.48052.qm@web112401.mail.gq1.yahoo.com> <366790.65150.qm@web112414.mail.gq1.yahoo.com> <BANLkTikm9Q_z1aYCB9U_Pc0tPTO+LzG57Q@mail.gmail.com> <1308428403.2597.66.camel@jdavis> <1308504190.2597.71.camel@jdavis> <21086.1309646333@sss.pgh.pa.us> <1309886656.3012.83.camel@jdavis> <21432.1309888581@sss.pgh.pa.us> <1309971611.3012.121.camel@jdavis> <13404.1309973153@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox