public inbox for [email protected]help / color / mirror / Atom feed
Some deleted GUCs are still referred to 4+ messages / 2 participants [nested] [flat]
* Some deleted GUCs are still referred to @ 2023-11-08 23:51 Peter Smith <[email protected]> 2023-11-09 09:12 ` Re: Some deleted GUCs are still referred to Daniel Gustafsson <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Peter Smith @ 2023-11-08 23:51 UTC (permalink / raw) To: PostgreSQL Hackers <[email protected]> Hi, I happened to notice that some GUC names "max_fsm_pages" and "max_fsm_relations" are still mentioned in these translation files (from the REL_16_1 source zip) src\backend\po\fr.po src\backend\po\tr.po ~~ Should those be removed? There was a commit [1] that said these all traces of those GUCs had been eliminated. ====== [1] https://github.com/postgres/postgres/commit/15c121b3ed7eb2f290e19533e41ccca734d23574#diff-65c699b5d4... Kind Regards, Peter Smith. Fujitsu Australia ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Some deleted GUCs are still referred to 2023-11-08 23:51 Some deleted GUCs are still referred to Peter Smith <[email protected]> @ 2023-11-09 09:12 ` Daniel Gustafsson <[email protected]> 2023-11-13 23:32 ` Re: Some deleted GUCs are still referred to Peter Smith <[email protected]> 2023-11-15 01:20 ` Fwd: Some deleted GUCs are still referred to Peter Smith <[email protected]> 0 siblings, 2 replies; 4+ messages in thread From: Daniel Gustafsson @ 2023-11-09 09:12 UTC (permalink / raw) To: Peter Smith <[email protected]>; +Cc: PostgreSQL Hackers <[email protected]> > On 9 Nov 2023, at 00:51, Peter Smith <[email protected]> wrote: > > Hi, > > I happened to notice that some GUC names "max_fsm_pages" and > "max_fsm_relations" are still mentioned in these translation files > (from the REL_16_1 source zip) > > src\backend\po\fr.po > src\backend\po\tr.po > > ~~ > > Should those be removed? These mentions are only in comments and not in actual translations, so I don't think they risk causing any issues. $ git grep max_fsm_ |cut -d":" -f 2 |grep -v "^#" | wc -l 0 I don't know enough about the translation workflow to know how these comments are handled, sending this to pgsql-translators@ might be a better way to reach the authors working on this. > There was a commit [1] that said these all traces of those GUCs had > been eliminated. Translations are managed in an external repo and synced with the main repo at intervals, so such a commit couldn't have updated the master translation work files anyways. -- Daniel Gustafsson ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: Some deleted GUCs are still referred to 2023-11-08 23:51 Some deleted GUCs are still referred to Peter Smith <[email protected]> 2023-11-09 09:12 ` Re: Some deleted GUCs are still referred to Daniel Gustafsson <[email protected]> @ 2023-11-13 23:32 ` Peter Smith <[email protected]> 1 sibling, 0 replies; 4+ messages in thread From: Peter Smith @ 2023-11-13 23:32 UTC (permalink / raw) To: Daniel Gustafsson <[email protected]>; +Cc: PostgreSQL Hackers <[email protected]> On Thu, Nov 9, 2023 at 8:12 PM Daniel Gustafsson <[email protected]> wrote: > > > On 9 Nov 2023, at 00:51, Peter Smith <[email protected]> wrote: > > > > Hi, > > > > I happened to notice that some GUC names "max_fsm_pages" and > > "max_fsm_relations" are still mentioned in these translation files > > (from the REL_16_1 source zip) > > > > src\backend\po\fr.po > > src\backend\po\tr.po > > > > ~~ > > > > Should those be removed? > > These mentions are only in comments and not in actual translations, so I don't > think they risk causing any issues. > > $ git grep max_fsm_ |cut -d":" -f 2 |grep -v "^#" | wc -l > 0 > > I don't know enough about the translation workflow to know how these comments > are handled, sending this to pgsql-translators@ might be a better way to reach > the authors working on this. > Thanks for the advice. Done that. ====== Kind Regards, Peter Smith. Fujitsu Australia ^ permalink raw reply [nested|flat] 4+ messages in thread
* Fwd: Some deleted GUCs are still referred to 2023-11-08 23:51 Some deleted GUCs are still referred to Peter Smith <[email protected]> 2023-11-09 09:12 ` Re: Some deleted GUCs are still referred to Daniel Gustafsson <[email protected]> @ 2023-11-15 01:20 ` Peter Smith <[email protected]> 1 sibling, 0 replies; 4+ messages in thread From: Peter Smith @ 2023-11-15 01:20 UTC (permalink / raw) To: pgsql-translators FYI. ====== Kind Regards, Peter Smith. Fujitsu Australia ---------- Forwarded message --------- From: Daniel Gustafsson <[email protected]> Date: Thu, Nov 9, 2023 at 8:12 PM Subject: Re: Some deleted GUCs are still referred to To: Peter Smith <[email protected]> Cc: PostgreSQL Hackers <[email protected]> > On 9 Nov 2023, at 00:51, Peter Smith <[email protected]> wrote: > > Hi, > > I happened to notice that some GUC names "max_fsm_pages" and > "max_fsm_relations" are still mentioned in these translation files > (from the REL_16_1 source zip) > > src\backend\po\fr.po > src\backend\po\tr.po > > ~~ > > Should those be removed? These mentions are only in comments and not in actual translations, so I don't think they risk causing any issues. $ git grep max_fsm_ |cut -d":" -f 2 |grep -v "^#" | wc -l 0 I don't know enough about the translation workflow to know how these comments are handled, sending this to pgsql-translators@ might be a better way to reach the authors working on this. > There was a commit [1] that said these all traces of those GUCs had > been eliminated. Translations are managed in an external repo and synced with the main repo at intervals, so such a commit couldn't have updated the master translation work files anyways. -- Daniel Gustafsson ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2023-11-15 01:20 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2023-11-08 23:51 Some deleted GUCs are still referred to Peter Smith <[email protected]> 2023-11-09 09:12 ` Daniel Gustafsson <[email protected]> 2023-11-13 23:32 ` Peter Smith <[email protected]> 2023-11-15 01:20 ` Peter Smith <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox