public inbox for [email protected]
help / color / mirror / Atom feed[pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl
3+ messages / 2 participants
[nested] [flat]
* [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl
@ 2016-04-28 13:32 Surinder Kumar <[email protected]>
2016-04-29 06:04 ` Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl Surinder Kumar <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Surinder Kumar @ 2016-04-28 13:32 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
The *SqlFieldControl* is setting default height for textarea, which is not
needed.
It should expand as needed as similar in *SqlTabControl*.
Please find the attached patch, review it.
Thanks
Surinder Kumar
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] remove_default_height_in_SqlFieldControl.patch (489B, 3-remove_default_height_in_SqlFieldControl.patch)
download | inline diff:
diff --git a/web/pgadmin/static/js/backform.pgadmin.js b/web/pgadmin/static/js/backform.pgadmin.js
index 544d574..ec7ecf4 100644
--- a/web/pgadmin/static/js/backform.pgadmin.js
+++ b/web/pgadmin/static/js/backform.pgadmin.js
@@ -1905,7 +1905,7 @@
defaults: {
label: "",
- extraClasses: ['sql_field_height_300'], // Add default control height
+ extraClasses: [], // Add default control height
helpMessage: null,
maxlength: 4096,
rows: undefined
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl
2016-04-28 13:32 [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl Surinder Kumar <[email protected]>
@ 2016-04-29 06:04 ` Surinder Kumar <[email protected]>
2016-04-29 10:36 ` Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl Ashesh Vashi <[email protected]>
0 siblings, 1 reply; 3+ messages in thread
From: Surinder Kumar @ 2016-04-29 06:04 UTC (permalink / raw)
To: pgadmin-hackers
Hi,
More specifically to the issue.
I am using SqlFieldControl in View for Definition Field which takes default
height of 300px which is set by Control as default height. but as per
dave's suggestion on thread
http://www.postgresql.org/message-id/[email protected]....
"The Definition box on the View dialogue should start at a single
line and expand as needed - see the Function dialogue".
If user still need some height for control, It can be specified in*
extraclasses[]* parameter which will apply to the specific field.
On Thu, Apr 28, 2016 at 7:02 PM, Surinder Kumar <
[email protected]> wrote:
> Hi,
>
> The *SqlFieldControl* is setting default height for textarea, which is
> not needed.
> It should expand as needed as similar in *SqlTabControl*.
>
> Please find the attached patch, review it.
>
> Thanks
> Surinder Kumar
>
^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl
2016-04-28 13:32 [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl Surinder Kumar <[email protected]>
2016-04-29 06:04 ` Re: [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl Surinder Kumar <[email protected]>
@ 2016-04-29 10:36 ` Ashesh Vashi <[email protected]>
0 siblings, 0 replies; 3+ messages in thread
From: Ashesh Vashi @ 2016-04-29 10:36 UTC (permalink / raw)
To: Surinder Kumar <[email protected]>; Arun Kollan <[email protected]>; +Cc: pgadmin-hackers
Thanks - committed!
Thanks Arun for the quick review!
--
Thanks & Regards,
Ashesh Vashi
EnterpriseDB INDIA: Enterprise PostgreSQL Company
<http://www.enterprisedb.com;
*http://www.linkedin.com/in/asheshvashi*
<http://www.linkedin.com/in/asheshvashi;
On Fri, Apr 29, 2016 at 11:34 AM, Surinder Kumar <
[email protected]> wrote:
> Hi,
>
> More specifically to the issue.
> I am using SqlFieldControl in View for Definition Field which takes
> default height of 300px which is set by Control as default height. but as
> per dave's suggestion on thread
>
>
> http://www.postgresql.org/message-id/[email protected]....
>
> "The Definition box on the View dialogue should start at a single
> line and expand as needed - see the Function dialogue".
>
> If user still need some height for control, It can be specified in*
> extraclasses[]* parameter which will apply to the specific field.
>
>
>
> On Thu, Apr 28, 2016 at 7:02 PM, Surinder Kumar <
> [email protected]> wrote:
>
>> Hi,
>>
>> The *SqlFieldControl* is setting default height for textarea, which is
>> not needed.
>> It should expand as needed as similar in *SqlTabControl*.
>>
>> Please find the attached patch, review it.
>>
>> Thanks
>> Surinder Kumar
>>
>
>
^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2016-04-29 10:36 UTC | newest]
Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-04-28 13:32 [pgAdmin4][Patch]: Remove default extraclass from the SqlFieldControl Surinder Kumar <[email protected]>
2016-04-29 06:04 ` Surinder Kumar <[email protected]>
2016-04-29 10:36 ` Ashesh Vashi <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox