public inbox for [email protected]
help / color / mirror / Atom feed[patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'
6+ messages / 2 participants
[nested] [flat]
* [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'
@ 2017-05-18 09:17 Akshay Joshi <[email protected]>
2017-05-18 09:30 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Dave Page <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Akshay Joshi @ 2017-05-18 09:17 UTC (permalink / raw)
To: pgadmin-hackers
Hi All
I have found one issue where table name is not displaying in the confirmation
dialog when user click on "Reset Statistics" and "Truncate/Truncate
cascade". Confirmation dialog shows below message:
- Are you sure you want to truncate table {}?
- Are you sure you want to reset the statistics for table {}?
Also header is missing for "Truncate/Truncate cascade" confirmation dialog.
Attached is the patch file to fix that above. Please review it.
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[application/octet-stream] Truncate.patch (1.6K, 3-Truncate.patch)
download | inline diff:
diff --git a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/js/table.js b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/js/table.js
index bf6b76f..62e31c7 100644
--- a/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/js/table.js
+++ b/web/pgadmin/browser/server_groups/servers/databases/schemas/tables/templates/table/js/table.js
@@ -165,7 +165,8 @@ function($, _, S, pgAdmin, pgBrowser, alertify) {
return false;
alertify.confirm(
- S('{{ _('Are you sure you want to truncate table %s?') }}').sprintf(d.label).value(),
+ '{{ _('Truncate Table') }}',
+ S('{{ _('Are you sure you want to truncate table "%%s"?') }}').sprintf(d.label).value(),
function (e) {
if (e) {
var data = d;
@@ -200,8 +201,9 @@ function($, _, S, pgAdmin, pgBrowser, alertify) {
t.unload(i);
}
});
- }
- });
+ }},
+ function() {}
+ );
},
reset_table_stats: function(args) {
var input = args || {},
@@ -215,7 +217,7 @@ function($, _, S, pgAdmin, pgBrowser, alertify) {
alertify.confirm(
'{{ _('Reset statistics') }}',
- S('{{ _('Are you sure you want to reset the statistics for table %s?') }}').sprintf(d._label).value(),
+ S('{{ _('Are you sure you want to reset the statistics for table "%%s"?') }}').sprintf(d._label).value(),
function (e) {
if (e) {
var data = d;
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'
2017-05-18 09:17 [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Akshay Joshi <[email protected]>
@ 2017-05-18 09:30 ` Dave Page <[email protected]>
2017-05-18 09:37 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Akshay Joshi <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Dave Page @ 2017-05-18 09:30 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers
Hi
Please see the discussion here: https://redmine.postgresql.org/issues/2308
Would moving to the client-side translation mechanism help here? We need to
do that anyway - and it's been added since the previous discussion.
On Thu, May 18, 2017 at 10:17 AM, Akshay Joshi <
[email protected]> wrote:
> Hi All
>
> I have found one issue where table name is not displaying in the confirmation
> dialog when user click on "Reset Statistics" and "Truncate/Truncate
> cascade". Confirmation dialog shows below message:
>
> - Are you sure you want to truncate table {}?
> - Are you sure you want to reset the statistics for table {}?
>
> Also header is missing for "Truncate/Truncate cascade" confirmation
> dialog. Attached is the patch file to fix that above. Please review it.
>
> --
> *Akshay Joshi*
> *Principal Software Engineer *
>
>
>
> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
> <+91%2097678%2088246>*
>
>
> --
> Sent via pgadmin-hackers mailing list ([email protected])
> To make changes to your subscription:
> http://www.postgresql.org/mailpref/pgadmin-hackers
>
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'
2017-05-18 09:17 [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Akshay Joshi <[email protected]>
2017-05-18 09:30 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Dave Page <[email protected]>
@ 2017-05-18 09:37 ` Akshay Joshi <[email protected]>
2017-05-18 09:53 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Dave Page <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Akshay Joshi @ 2017-05-18 09:37 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
On Thu, May 18, 2017 at 3:00 PM, Dave Page <[email protected]> wrote:
> Hi
>
> Please see the discussion here: https://redmine.postgresql.org/issues/2308
>
> Would moving to the client-side translation mechanism help here? We need
> to do that anyway - and it's been added since the previous discussion.
>
OK, at least we should checked-in code for showing title of the
confirmation dialog for "Truncate".
>
> On Thu, May 18, 2017 at 10:17 AM, Akshay Joshi <
> [email protected]> wrote:
>
>> Hi All
>>
>> I have found one issue where table name is not displaying in the confirmation
>> dialog when user click on "Reset Statistics" and "Truncate/Truncate
>> cascade". Confirmation dialog shows below message:
>>
>> - Are you sure you want to truncate table {}?
>> - Are you sure you want to reset the statistics for table {}?
>>
>> Also header is missing for "Truncate/Truncate cascade" confirmation
>> dialog. Attached is the patch file to fix that above. Please review it.
>>
>> --
>> *Akshay Joshi*
>> *Principal Software Engineer *
>>
>>
>>
>> *Phone: +91 20-3058-9517 <+91%2020%203058%209517>Mobile: +91 976-788-8246
>> <+91%2097678%2088246>*
>>
>>
>> --
>> Sent via pgadmin-hackers mailing list ([email protected])
>> To make changes to your subscription:
>> http://www.postgresql.org/mailpref/pgadmin-hackers
>>
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'
2017-05-18 09:17 [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Akshay Joshi <[email protected]>
2017-05-18 09:30 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Dave Page <[email protected]>
2017-05-18 09:37 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Akshay Joshi <[email protected]>
@ 2017-05-18 09:53 ` Dave Page <[email protected]>
2017-05-18 10:03 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Akshay Joshi <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Dave Page @ 2017-05-18 09:53 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers
On Thu, May 18, 2017 at 10:37 AM, Akshay Joshi <
[email protected]> wrote:
>
>
> On Thu, May 18, 2017 at 3:00 PM, Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> Please see the discussion here: https://redmine.postgres
>> ql.org/issues/2308
>>
>> Would moving to the client-side translation mechanism help here? We need
>> to do that anyway - and it's been added since the previous discussion.
>>
>
> OK, at least we should checked-in code for showing title of the
> confirmation dialog for "Truncate".
>
Right, but it doesn't work. See the first comment in the bug.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'
2017-05-18 09:17 [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Akshay Joshi <[email protected]>
2017-05-18 09:30 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Dave Page <[email protected]>
2017-05-18 09:37 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Akshay Joshi <[email protected]>
2017-05-18 09:53 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Dave Page <[email protected]>
@ 2017-05-18 10:03 ` Akshay Joshi <[email protected]>
2017-05-18 12:42 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Dave Page <[email protected]>
0 siblings, 1 reply; 6+ messages in thread
From: Akshay Joshi @ 2017-05-18 10:03 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: pgadmin-hackers
On Thu, May 18, 2017 at 3:23 PM, Dave Page <[email protected]> wrote:
>
>
> On Thu, May 18, 2017 at 10:37 AM, Akshay Joshi <
> [email protected]> wrote:
>
>>
>>
>> On Thu, May 18, 2017 at 3:00 PM, Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> Please see the discussion here: https://redmine.postgres
>>> ql.org/issues/2308
>>>
>>> Would moving to the client-side translation mechanism help here? We need
>>> to do that anyway - and it's been added since the previous discussion.
>>>
>>
>> OK, at least we should checked-in code for showing title of the
>> confirmation dialog for "Truncate".
>>
>
> Right, but it doesn't work. See the first comment in the bug.
>
I am talking about the header title of the confirmation dialog. If we
click on Truncate table without opening any alertify dialog header shows "
AlertifyJS" and if any other alertify dialog opens before then it shows the
header title of that dialog even if user clicks on Truncate. Please refer
attached screenshot.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
--
*Akshay Joshi*
*Principal Software Engineer *
*Phone: +91 20-3058-9517Mobile: +91 976-788-8246*
--
Sent via pgadmin-hackers mailing list ([email protected])
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgadmin-hackers
Attachments:
[image/png] Truncate_1.png (31.6K, 3-Truncate_1.png)
download | view image
[image/png] Truncate_2.png (33.5K, 4-Truncate_2.png)
download | view image
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table'
2017-05-18 09:17 [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Akshay Joshi <[email protected]>
2017-05-18 09:30 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Dave Page <[email protected]>
2017-05-18 09:37 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Akshay Joshi <[email protected]>
2017-05-18 09:53 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Dave Page <[email protected]>
2017-05-18 10:03 ` Re: [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Akshay Joshi <[email protected]>
@ 2017-05-18 12:42 ` Dave Page <[email protected]>
0 siblings, 0 replies; 6+ messages in thread
From: Dave Page @ 2017-05-18 12:42 UTC (permalink / raw)
To: Akshay Joshi <[email protected]>; +Cc: pgadmin-hackers
On Thu, May 18, 2017 at 11:03 AM, Akshay Joshi <
[email protected]> wrote:
>
>
> On Thu, May 18, 2017 at 3:23 PM, Dave Page <[email protected]> wrote:
>
>>
>>
>> On Thu, May 18, 2017 at 10:37 AM, Akshay Joshi <
>> [email protected]> wrote:
>>
>>>
>>>
>>> On Thu, May 18, 2017 at 3:00 PM, Dave Page <[email protected]> wrote:
>>>
>>>> Hi
>>>>
>>>> Please see the discussion here: https://redmine.postgres
>>>> ql.org/issues/2308
>>>>
>>>> Would moving to the client-side translation mechanism help here? We
>>>> need to do that anyway - and it's been added since the previous discussion.
>>>>
>>>
>>> OK, at least we should checked-in code for showing title of the
>>> confirmation dialog for "Truncate".
>>>
>>
>> Right, but it doesn't work. See the first comment in the bug.
>>
>
> I am talking about the header title of the confirmation dialog. If we
> click on Truncate table without opening any alertify dialog header shows "
> AlertifyJS" and if any other alertify dialog opens before then it shows
> the header title of that dialog even if user clicks on Truncate. Please
> refer attached screenshot.
>
Oh, sure - that can be fixed. The other part does need resolution as well
though.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2017-05-18 12:42 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2017-05-18 09:17 [patch] update table name in confirmation dialog for 'Reset Statistics' and 'Truncate Table' Akshay Joshi <[email protected]>
2017-05-18 09:30 ` Dave Page <[email protected]>
2017-05-18 09:37 ` Akshay Joshi <[email protected]>
2017-05-18 09:53 ` Dave Page <[email protected]>
2017-05-18 10:03 ` Akshay Joshi <[email protected]>
2017-05-18 12:42 ` Dave Page <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox