From: Laurenz Albe <laurenz.albe@cybertec.at>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Ranier Vilela <ranier.vf@gmail.com>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: printf %s with NULL pointer (was Re: BUG #17098: Assert failed on composing an error message when adding a type to an extension being dropped)
Date: Wed, 14 Jul 2021 07:52:39 +0200
Message-ID: <802d1a9448570ed6b14d0c8d57746c3a3cd55695.camel@cybertec.at> (raw)
In-Reply-To: <3280448.1626200778@sss.pgh.pa.us>
References: <17098-b960f3616c861f83@postgresql.org>
<2468663.1626017338@sss.pgh.pa.us>
<2984422.1626110456@sss.pgh.pa.us>
<dc29b1131b84bef879cf68d1d1edae07f51ca3d2.camel@cybertec.at>
<3227956.1626186568@sss.pgh.pa.us>
<CAEudQAq22dUhHp9ryKNOnro0HkQWiJE1F3g3VxHUFsqQ4ZkyeA@mail.gmail.com>
<3280448.1626200778@sss.pgh.pa.us>
On Tue, 2021-07-13 at 14:26 -0400, Tom Lane wrote:
> Did you see my followup? The vast majority of live systems do not do
> that, so we are accomplishing nothing of value by insisting it's a
> crash-worthy bug.
>
> I flat out don't agree that "crash on debug builds but it's okay on
> production" is a useful way to define this. I spend way too much
> time already on bug reports that only manifest with asserts enabled.
You convinced my that printing "(null)" is better than crashing.
Having a "(null)" show up in a weird place is certainly a minor inconvenience.
But I don't buy your second point: if it is like that, why do we have
Asserts at all?
Yours,
Laurenz Albe
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-bugs@postgresql.org
Cc: laurenz.albe@cybertec.at, tgl@sss.pgh.pa.us, ranier.vf@gmail.com, pgsql-hackers@lists.postgresql.org
Subject: Re: printf %s with NULL pointer (was Re: BUG #17098: Assert failed on composing an error message when adding a type to an extension being dropped)
In-Reply-To: <802d1a9448570ed6b14d0c8d57746c3a3cd55695.camel@cybertec.at>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox