pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Christoph Berg <myon@debian.org>
Cc: Tomas Vondra <tomas.vondra@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
Date: Thu, 9 Mar 2023 19:00:35 +0100
Message-ID: <0e8e53fa-5087-2151-dcd6-a1d3ad3ed493@enterprisedb.com> (raw)
In-Reply-To: <ZAkol+4UyWuBR7PS@paquier.xyz>
References: <E1pVI5z-000MHR-Ch@gemulon.postgresql.org>
	<ZAjL96N9ZW84U59p@msg.df7cb.de>
	<E6DD8AC9-3EE4-4E7B-A2BC-53FDF04D1ED0@yesql.se>
	<819f6883-f7cf-74fd-e918-4c06a9d76d0b@enterprisedb.com>
	<ZAkol+4UyWuBR7PS@paquier.xyz>



On 3/9/23 01:30, Michael Paquier wrote:
> On Thu, Mar 09, 2023 at 12:39:08AM +0100, Tomas Vondra wrote:
>> IMO we should fix that. We have a bunch of buildfarm members running on
>> Ubuntu 18.04 (or older) - it's true none of them seems to be running TAP
>> tests. But considering how trivial the fix is ...
>>
>> Barring objections, I'll push a fix early next week.
> 
> +1, better to change that, thanks.  Actually, would --rm be OK even on
> Windows?  As far as I can see, the CI detects a LZ4 command for the
> VS2019 environment but not the liblz4 libraries that would be needed
> to trigger the set of tests.

Thanks for noticing that. I'll investigate next week.


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





view thread (10+ messages)  latest in thread

Message-ID: <0e8e53fa-5087-2151-dcd6-a1d3ad3ed493@enterprisedb.com>
Permalink:  ../0e8e53fa-5087-2151-dcd6-a1d3ad3ed493@enterprisedb.com/
Also on:    postgresql.org/message-id/0e8e53fa-5087-2151-dcd6-a1d3ad3ed493@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@enterprisedb.com, michael@paquier.xyz, daniel@yesql.se, myon@debian.org, tomas.vondra@postgresql.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
  In-Reply-To: <0e8e53fa-5087-2151-dcd6-a1d3ad3ed493@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox