pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org, Dagfinn Ilmari Mannsåker <ilmari@ilmari.org>
Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
Date: Sun, 30 Jan 2022 18:09:34 -0800
Message-ID: <20220131020934.g6bfyalgkwnvqugw@alap3.anarazel.de> (raw)
In-Reply-To: <535668.1643594467@sss.pgh.pa.us>
References: <E1nEKoB-0007Fc-HF@gemulon.postgresql.org>
	<20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de>
	<20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de>
	<535668.1643594467@sss.pgh.pa.us>

Hi,

On 2022-01-30 21:01:07 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On 2022-01-30 17:35:48 -0800, Andres Freund wrote:
> >> I see this broke on everywhere but master. Looking.
> 
> > Ugh. It's that we didn't backport pport.h.
> 
> Ooops.

I've pushed the quick fix of just using PERL_VERSION for now. That's, as
Ilmari noted, not necessarily future safe, but for now it'll work.


> > Unless somebody comes up with a better idea quickly I'm going use a plain
> > PERL_VERSION check in the backbranches. Might also be a good idea to backpatch
> > the above commit, but that requires more discussion than I want to leave the
> > buildfarm red for.
> 
> I think we oughta backport.  We didn't do so at the time because
> we thought it was mostly cosmetic/future-proofing, but evidently
> the future is now.
> 
> I can look into that tomorrow or so.

Cool. I can either do a revert of the set of commits just now afterwards, or
you can fold that into the backpatch...

Greetings,

Andres Freund





view thread (14+ messages)  latest in thread

Message-ID: <20220131020934.g6bfyalgkwnvqugw@alap3.anarazel.de>
Permalink:  ../20220131020934.g6bfyalgkwnvqugw@alap3.anarazel.de/
Also on:    postgresql.org/message-id/20220131020934.g6bfyalgkwnvqugw@alap3.anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, ilmari@ilmari.org
  Subject: Re: pgsql: plperl: windows: Use Perl_setlocale on 5.28+, fixing compile fai
  In-Reply-To: <20220131020934.g6bfyalgkwnvqugw@alap3.anarazel.de>
  References: <E1nEKoB-0007Fc-HF@gemulon.postgresql.org> <20220131013548.enc5d6qqyokhmj3q@alap3.anarazel.de> <20220131015130.shn6wr2fzuymerf6@alap3.anarazel.de> <535668.1643594467@sss.pgh.pa.us> <20220131020934.g6bfyalgkwnvqugw@alap3.anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox