pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Noah Misch <noah@leadboat.com>
Cc: pgsql-committers@postgresql.org
Subject: Re: [HACKERS] pgsql: Improve performance of SendRowDescriptionMessage.
Date: Fri, 13 Oct 2017 14:19:22 -0400
Message-ID: <1820.1507918762@sss.pgh.pa.us> (raw)
In-Reply-To: <20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de>
References: <E1e2RML-0002do-Lc@gemulon.postgresql.org>
	<307.1507819498@sss.pgh.pa.us>
	<20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de>
	<20171013023536.GA492146@rfd.leadboat.com>
	<12267.1507862660@sss.pgh.pa.us>
	<20171013070247.GA505228@rfd.leadboat.com>
	<21773.1507908395@sss.pgh.pa.us>
	<530.1507916887@sss.pgh.pa.us>
	<20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

Andres Freund <andres@anarazel.de> writes:
> A easiest way to do this would be to put something like
> CPPFLAGS="$CPPFLAGS -Dpg_restrict" into the existing
> if test "$GCC" != yes ; then
> block in a/src/template/linux. But that'd probably result in "macro
> redefined" warnings or somesuch.

You mean src/template/aix, no?  Agreed, that seems like a reasonable
place to control it.  But I'm pretty sure the above would flat out
not work, the #define in pg_config.h would override it.

> So it'd probably better to introduce a FORCE_DISABLE_RESTRICT=yes, set
> at the same place, that's then tested before running the relevant
> configure check?

+1.  I think you don't actually have to skip the configure check,
and there might be some value in letting it carry on normally
(so that "restrict" is set properly).  We'd just want it to affect
what pg_restrict gets defined as.  Something like

if test "$ac_cv_c_restrict" = "no" -o "x$FORCE_DISABLE_RESTRICT" = "xyes"; then
  pg_restrict=""
else
  pg_restrict="$ac_cv_c_restrict"
fi

			regards, tom lane


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



view thread (21+ messages)  latest in thread

Message-ID: <1820.1507918762@sss.pgh.pa.us>
Permalink:  ../1820.1507918762@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/1820.1507918762@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, noah@leadboat.com
  Subject: Re: [HACKERS] pgsql: Improve performance of SendRowDescriptionMessage.
  In-Reply-To: <1820.1507918762@sss.pgh.pa.us>
  References: <E1e2RML-0002do-Lc@gemulon.postgresql.org> <307.1507819498@sss.pgh.pa.us> <20171012230844.ye4tnye2shysvqpk@alap3.anarazel.de> <20171013023536.GA492146@rfd.leadboat.com> <12267.1507862660@sss.pgh.pa.us> <20171013070247.GA505228@rfd.leadboat.com> <21773.1507908395@sss.pgh.pa.us> <530.1507916887@sss.pgh.pa.us> <20171013180106.ruju5qtn6xpw45us@alap3.anarazel.de> <1820.1507918762@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox