pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Check that we have a working tar before trying to use it
Date: Mon, 13 Dec 2021 11:47:36 -0500
Message-ID: <190aad26-d04b-f2c6-c4a3-e184377f4c8c@dunslane.net> (raw)
In-Reply-To: <Ybb/itFhY3FrsyzF@paquier.xyz>
References: <3660797.1638983124@sss.pgh.pa.us>
	<b6782dc3-a7b0-ed56-175f-f8f54cb08d67@dunslane.net>
	<20211209021604.bv5tfr23ymh4u7x4@alap3.anarazel.de>
	<3707204.1639016334@sss.pgh.pa.us>
	<20211209024604.dpmudj4ax2hoi7cx@alap3.anarazel.de>
	<20211209030856.ibxewzpc5ph7ckkp@alap3.anarazel.de>
	<YbGYe483803il3X7@paquier.xyz>
	<20211209064928.7f5lp6hxvw2f2j6o@alap3.anarazel.de>
	<YbGr7ylYwE56l91B@paquier.xyz>
	<95787b2b-d483-0b5e-b24b-1986cff93596@dunslane.net>
	<Ybb/itFhY3FrsyzF@paquier.xyz>


On 12/13/21 03:08, Michael Paquier wrote:
> Also,
> the default values of LZ4, TAR and GZIP_PROGRAM had better be set
> *before* loading buildenv.pl, and not after it is loaded, no?  On
> HEAD, one has no way to unset any of those variables so it is not
> possible to skip things if an environment has in its PATH a funky
> command that TAP would refuse, like a tar command from MinGW or the
> git installation.


No. The code only sets them if they have not been previously set by
buildenv.pl or the calling environment. That's what "||=" means.


cheers


andrew


--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (25+ messages)  latest in thread

Message-ID: <190aad26-d04b-f2c6-c4a3-e184377f4c8c@dunslane.net>
Permalink:  ../190aad26-d04b-f2c6-c4a3-e184377f4c8c@dunslane.net/
Also on:    postgresql.org/message-id/190aad26-d04b-f2c6-c4a3-e184377f4c8c@dunslane.net

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, michael@paquier.xyz, andres@anarazel.de, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Check that we have a working tar before trying to use it
  In-Reply-To: <190aad26-d04b-f2c6-c4a3-e184377f4c8c@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox