From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test
Date: Tue, 14 Jun 2022 20:11:59 -0400
Message-ID: <191585.1655251919@sss.pgh.pa.us> (raw)
In-Reply-To: <YqkhANbVO13UNXxR@paquier.xyz>
References: <E1nxKKP-002beU-Ef@gemulon.postgresql.org>
<90595.1655227384@sss.pgh.pa.us>
<YqkhANbVO13UNXxR@paquier.xyz>
Michael Paquier <michael@paquier.xyz> writes:
> On Tue, Jun 14, 2022 at 01:23:04PM -0400, Tom Lane wrote:
>> I suppose it would be too user-unfriendly to generate those scripts
>> underneath $PGDATA, so don't we need to put back the .gitignore
>> entries?
> delete_old_cluster.sh is generated within tmp_check/ in a non-VPATH
> build:
Sorry, I wasn't very clear: I'd tested pg_upgrade with a manual
invocation, like "./pg_upgrade -d ...". That used to be OK and
now it leaves junk around. I think it's worth keeping the
.gitignore entries (and I guess the "make clean" rule step too)
so that that approach still works without making a mess.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients from your mail client; the link fills in
the headers below: reply via email
Some clients, webmail especially, drop In-Reply-To and References from
a link, and the reply then starts a new thread: use the mbox below.
To: pgsql-committers@postgresql.org
Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz
Subject: Re: pgsql: Force run of pg_upgrade in the build directory in its TAP test
In-Reply-To: <191585.1655251919@sss.pgh.pa.us>
References: <E1nxKKP-002beU-Ef@gemulon.postgresql.org> <90595.1655227384@sss.pgh.pa.us> <YqkhANbVO13UNXxR@paquier.xyz> <191585.1655251919@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox