From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add a regression test for allow_system_table_mods
Date: Tue, 3 Dec 2019 13:12:47 +0900
Message-ID: <20191203041247.GD1634@paquier.xyz> (raw)
In-Reply-To: <29779.1575299500@sss.pgh.pa.us>
References: <E1iacW7-0003h6-6U@gemulon.postgresql.org>
<13656.1575041267@sss.pgh.pa.us>
<315cfd3b-9d04-0ea4-76d8-1507c8bd9bb7@2ndquadrant.com>
<15399.1575043746@sss.pgh.pa.us>
<1e7bb9a1-1104-907d-da62-857408d271ef@2ndquadrant.com>
<29779.1575299500@sss.pgh.pa.us>
On Mon, Dec 02, 2019 at 10:11:40AM -0500, Tom Lane wrote:
> One way would be to provide a variant expected-file, but that's not going
> to be fun for future maintenance of the test script. Another simple
> answer is to crank up client_min_messages for this one test to hide the
> WARNING, but you could conjure scenarios where that misses something
> important. (Of course, not running the test at all would also miss
> any such issue.)
Alternate output files should be IMO avoided if we can, so if I were
to choose sneaking a SET client_min_messages would be fine, but only
for the second create tablespace..
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../20191203041247.GD1634@paquier.xyz/2-signature.asc)
download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, peter.eisentraut@2ndquadrant.com, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Add a regression test for allow_system_table_mods
In-Reply-To: <20191203041247.GD1634@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox