pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgmasters.net>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
Date: Fri, 6 Mar 2020 11:10:25 +0900
Message-ID: <20200306021025.GG52814@paquier.xyz> (raw)
In-Reply-To: <d9ec273a-7f94-db59-fc16-802357e1d23f@pgmasters.net>
References: <E1j9ioh-0005Kn-4O@gemulon.postgresql.org>
	<1cf30561-7dad-dc6e-9fc3-5c456948cfeb@pgmasters.net>
	<20200305233014.GA2501@paquier.xyz>
	<CABUevEzoWeR_q-JztqacmATBvVMUL9rtOcpM5RACubKcmhmk3Q@mail.gmail.com>
	<20200306004826.GB52814@paquier.xyz>
	<e19fa62e-f140-306a-aa6b-fb55ccb3b9c1@pgmasters.net>
	<20200306011006.GC52814@paquier.xyz>
	<d9ec273a-7f94-db59-fc16-802357e1d23f@pgmasters.net>

On Thu, Mar 05, 2020 at 08:20:23PM -0500, David Steele wrote:
> Couldn't we use pageinspect?

Oh, indeed.  I forgot that we already have this function.  The tests
of page.sql don't care about the page size either, so it would be
enough to add a couple of calls with some hardcoded bytea input.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20200306021025.GG52814@paquier.xyz/2-signature.asc)
  download

view thread (14+ messages)  latest in thread

Message-ID: <20200306021025.GG52814@paquier.xyz>
Permalink:  ../20200306021025.GG52814@paquier.xyz/
Also on:    postgresql.org/message-id/20200306021025.GG52814@paquier.xyz

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, david@pgmasters.net, magnus@hagander.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Avoid -Wconversion warnings when using checksum_impl.h
  In-Reply-To: <20200306021025.GG52814@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox