pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-hackers@lists.postgresql.org, Craig Ringer <craig.ringer@enterprisedb.com>
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Date: Thu, 7 Oct 2021 21:24:54 -0700
Message-ID: <20211008042454.GB398563@rfd.leadboat.com> (raw)
In-Reply-To: <197091.1633664351@sss.pgh.pa.us>
References: <E1mYY6Z-0006OL-QN@gemulon.postgresql.org>
	<150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se>
	<161525.1633632402@sss.pgh.pa.us>
	<162421.1633633360@sss.pgh.pa.us>
	<12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se>
	<173186.1633635888@sss.pgh.pa.us>
	<20211008025659.GA398563@rfd.leadboat.com>
	<197091.1633664351@sss.pgh.pa.us>

On Thu, Oct 07, 2021 at 11:39:11PM -0400, Tom Lane wrote:
> Noah Misch <noah@leadboat.com> writes:
> > On Thu, Oct 07, 2021 at 03:44:48PM -0400, Tom Lane wrote:
> >>> (1) I'm distrustful of the idea that perl 5.8.x will compile
> >>> cleanly, or at all, on modern platforms.  Certainly Postgres
> >>> releases of similar vintage won't.
> 
> > perlbrew uses the patchperl system to build old Perl in modern environments.
> > This year, I used it to get 5.8.0.  Building unpatched 5.8.0 does fail.
> 
> Oh, cool.
> 
> >> I propose that what might be more useful than the existing last
> >> section of src/test/perl/README is something along the lines of:
> 
> > -1.  This would replace a useful recipe with, essentially, a restatement of
> > that recipe in English words.  That just leaves the user to rediscover the
> > actual recipe.
> 
> Well, I think the existing text does the reader a disservice
> by stating a specific recipe without any context.  Notably,
> it says nothing about restricting which Perl modules you use.

That's obvious from "cpanm install IPC::Run".  Surely if any other non-core
module were allowed, the recipe would list it in a similar way.  This is a
source tree README; it shouldn't try to hold the reader's hand like the
user-facing docs do.  We've not had commits add usage of other modules, so
there's no evidence of actual doubt on this point.

> What do you think of using my proposed text followed by
> 
>     One way to test against an old Perl version is to use
>     perlbrew.
>     << more or less the existing text here >>
>     Bear in mind that you will still need to install IPC::Run,
>     and what you will get is a current version not the one
>     distributed with Perl 5.8.3.  You will also need to update
>     Test::More because the version distributed with Perl 5.8.3
>     is too old to run our TAP tests.  So this recipe does not create
>     a perfect reproduction of a back-in-the-day Perl installation,
>     but it will probably catch any problems that might surface in
>     the buildfarm.

I don't see an improvement in there.  If there's something to change, it's
improving the actual recipe:

inline patch 1: src/test/perl/README (+2/-1 lines) download inline-1.patch--- a/src/test/perl/README +++ b/src/test/perl/README @@ -83,3 +83,4 @@ Just install and perlbrew install-cpanm - cpanm install IPC::Run + cpanm install Test::More@0.87 + cpanm install IPC::Run@tbd_old_version

view thread (33+ messages)  latest in thread

Message-ID: <20211008042454.GB398563@rfd.leadboat.com>
Permalink:  ../20211008042454.GB398563@rfd.leadboat.com/
Also on:    postgresql.org/message-id/20211008042454.GB398563@rfd.leadboat.com

 ·  · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, daniel@yesql.se, craig.ringer@enterprisedb.com
  Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
  In-Reply-To: <20211008042454.GB398563@rfd.leadboat.com>
  References: <E1mYY6Z-0006OL-QN@gemulon.postgresql.org> <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se> <161525.1633632402@sss.pgh.pa.us> <162421.1633633360@sss.pgh.pa.us> <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> <173186.1633635888@sss.pgh.pa.us> <20211008025659.GA398563@rfd.leadboat.com> <197091.1633664351@sss.pgh.pa.us> <20211008042454.GB398563@rfd.leadboat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox