pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: Wed, 30 Mar 2022 12:58:26 -0400
Message-ID: <230838.1648659506@sss.pgh.pa.us> (raw)
In-Reply-To: <20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de>
References: <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de>
	<CA+TgmoZ6DdRe0=YYv-dXfKCpfwaoKdUXP6gXg7qVB=3FwON1GA@mail.gmail.com>
	<7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net>
	<CA+TgmoYwwTgNPJz34p6MJPAv8OYH77+-sMbae13Ygv8ENfGXdA@mail.gmail.com>
	<20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de>
	<CA+TgmoY-x99HMUcV0a+SBWrzcdREHkE69+Xw620BVBjGqvrc4g@mail.gmail.com>
	<144620.1648326272@sss.pgh.pa.us>
	<20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de>
	<20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de>
	<228044.1648658074@sss.pgh.pa.us>
	<20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de>

Andres Freund <andres@anarazel.de> writes:
> On 2022-03-30 12:34:34 -0400, Tom Lane wrote:
>> One refinement that comes to mind as I look at the patch is to distinguish
>> between "check" and "installcheck".  Not sure that's worthwhile, but not
>> sure it isn't, either.

> As it's just about "free" to do so, I see no reason not to go for showing that
> difference.  How about:

> echo "+++ (tap|regress|isolation) [install-]check in $(subdir) +++" && \

WFM.

> I see no reason to distinguish the PGXS / non-PGXs tap installcheck cases?

Agreed.

> Random aside: Am I the only one bothered by a bunch of places in
> Makefile.global.in quoting like
>   $(MAKE) -C '$(top_builddir)' DESTDIR='$(abs_top_builddir)'/tmp_install install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1
> and
>   rm -rf '$(CURDIR)'/tmp_check &&
> etc

Don't we need that to handle, say, build paths with spaces in them?
Admittedly we're probably not completely clean for such paths,
but that's not an excuse to break the places that do it right.

(I occasionally think about setting up a BF animal configured
like that, but haven't tried yet.)

			regards, tom lane





view thread (66+ messages)  latest in thread

Message-ID: <230838.1648659506@sss.pgh.pa.us>
Permalink:  ../230838.1648659506@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/230838.1648659506@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andres@anarazel.de, robertmhaas@gmail.com, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org, magnus@hagander.net
  Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
  In-Reply-To: <230838.1648659506@sss.pgh.pa.us>
  References: <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <CA+TgmoZ6DdRe0=YYv-dXfKCpfwaoKdUXP6gXg7qVB=3FwON1GA@mail.gmail.com> <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> <CA+TgmoYwwTgNPJz34p6MJPAv8OYH77+-sMbae13Ygv8ENfGXdA@mail.gmail.com> <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> <CA+TgmoY-x99HMUcV0a+SBWrzcdREHkE69+Xw620BVBjGqvrc4g@mail.gmail.com> <144620.1648326272@sss.pgh.pa.us> <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de> <228044.1648658074@sss.pgh.pa.us> <20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de> <230838.1648659506@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox