pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
To: Fabien COELHO <coelho@cri.ensmp.fr>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: psql: Add test for query canceling
Date: Thu, 26 Aug 2021 08:39:31 +0200
Message-ID: <2e765fec-219a-378f-a035-f85c95ff3bff@enterprisedb.com> (raw)
In-Reply-To: <alpine.DEB.2.22.394.2108250705270.2232211@pseudo>
References: <E1mH14Q-0002gh-HS@gemulon.postgresql.org>
	<DD279DFC-DD59-458E-B469-75DC941765A4@yesql.se>
	<alpine.DEB.2.22.394.2108201736060.498998@pseudo>
	<5F16EBAA-30D3-4C0D-840C-C2FF2739E370@yesql.se>
	<1957503.1629485278@sss.pgh.pa.us>
	<9f46b102-da4d-8312-54f0-1f3bc10b453c@enterprisedb.com>
	<350197.1629824350@sss.pgh.pa.us>
	<alpine.DEB.2.22.394.2108250705270.2232211@pseudo>

On 25.08.21 07:37, Fabien COELHO wrote:
> I finally came around to have a look at the patch.
> 
> For the issue raised above, I can see that the file could be created but 
> not yet written, but as the patch waits for the file to be non zero, 
> ISTM that the probability of a torn write of a single integer by echo is 
> so remote that we could let it as that?
> 
> Attached a version with the slurping in the loop anyway.

It looks like this fixed it.  Thanks all.






view thread (20+ messages)  latest in thread

Message-ID: <2e765fec-219a-378f-a035-f85c95ff3bff@enterprisedb.com>
Permalink:  ../2e765fec-219a-378f-a035-f85c95ff3bff@enterprisedb.com/
Also on:    postgresql.org/message-id/2e765fec-219a-378f-a035-f85c95ff3bff@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: peter.eisentraut@enterprisedb.com, coelho@cri.ensmp.fr, tgl@sss.pgh.pa.us, daniel@yesql.se
  Subject: Re: pgsql: psql: Add test for query canceling
  In-Reply-To: <2e765fec-219a-378f-a035-f85c95ff3bff@enterprisedb.com>
  References: <E1mH14Q-0002gh-HS@gemulon.postgresql.org> <DD279DFC-DD59-458E-B469-75DC941765A4@yesql.se> <alpine.DEB.2.22.394.2108201736060.498998@pseudo> <5F16EBAA-30D3-4C0D-840C-C2FF2739E370@yesql.se> <1957503.1629485278@sss.pgh.pa.us> <9f46b102-da4d-8312-54f0-1f3bc10b453c@enterprisedb.com> <350197.1629824350@sss.pgh.pa.us> <alpine.DEB.2.22.394.2108250705270.2232211@pseudo> <2e765fec-219a-378f-a035-f85c95ff3bff@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox