pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Andrew Dunstan <andrew@dunslane.net>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Cache by-reference missing values in a long lived context
Date: Fri, 25 Aug 2023 09:40:14 -0400
Message-ID: <4126204.1692970814@sss.pgh.pa.us> (raw)
In-Reply-To: <7a219b25-b71b-f3ab-5f60-072b65e03d0d@dunslane.net>
References: <E1qYvJA-000XT3-QX@gemulon.postgresql.org>
	<3907902.1692890821@sss.pgh.pa.us>
	<ba2150c1-8485-6597-fafe-4fcd39e49c28@dunslane.net>
	<3979066.1692910679@sss.pgh.pa.us>
	<7a219b25-b71b-f3ab-5f60-072b65e03d0d@dunslane.net>

Andrew Dunstan <andrew@dunslane.net> writes:
> On 2023-08-24 Th 16:57, Tom Lane wrote:
>> I'm not sure if those arguments justify a back-patch instead of
>> the localized hack you suggest.

> Seems like overkill given the age of the surrounding code and the 
> nearness to EOL of releases 11 and 12.

I agree that 11 is nearly dead, but 12 still has a year-plus to go.

Another point that I wasn't thinking of yesterday is that 11 is
still expected to compile on pre-C99 compilers.  I'm not sure
to what extent we are still able to test that -- my old animals
have all gone to buildfarm heaven, although I see that Noah's
AIX menagerie is still soldiering on.  Were we relying on "{ 0 }"
anywhere else pre-v12?

			regards, tom lane





view thread (15+ messages)  latest in thread

Message-ID: <4126204.1692970814@sss.pgh.pa.us>
Permalink:  ../4126204.1692970814@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/4126204.1692970814@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, andrew@dunslane.net, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Cache by-reference missing values in a long lived context
  In-Reply-To: <4126204.1692970814@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox