pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Petr Jelinek <petr.jelinek@2ndquadrant.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
To: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter_e@gmx.net>
Cc: pgsql-committers@postgresql.org
Subject: Re: pgsql: Add support for temporary replication slots
Date: Tue, 13 Dec 2016 02:21:27 +0100
Message-ID: <495584eb-c8c8-90ba-0e21-1b0ecc148bf4@2ndquadrant.com> (raw)
In-Reply-To: <19997.1481591281@sss.pgh.pa.us>
References: <27274.1481557380@sss.pgh.pa.us>
	<27833.1481558144@sss.pgh.pa.us>
	<62935e6f-4f1b-c433-e0fa-7f936a38b3e5@2ndquadrant.com>
	<22907.1481571177@sss.pgh.pa.us>
	<15713.1481585953@sss.pgh.pa.us>
	<314cae39-2e7d-f5a3-d226-cfb80cf80481@2ndquadrant.com>
	<18684.1481589637@sss.pgh.pa.us>
	<48b2c017-695d-b5ac-2ff4-89b939b3e8f9@2ndquadrant.com>
	<20161213004903.iito2pefdrrjgny5@alap3.anarazel.de>
	<6886c56a-f6c8-3c44-53a1-dae6c24afb76@2ndquadrant.com>
	<20161213010059.dn64rrb3u7zxnnwk@alap3.anarazel.de>
	<19997.1481591281@sss.pgh.pa.us>
List-Unsubscribe:  <mailto:majordomo@postgresql.org?body=unsub%20pgsql-committers>

On 13/12/16 02:08, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
>> On 2016-12-13 01:57:01 +0100, Petr Jelinek wrote:
>>> I mentioned that as possible solution upthread, I am only worried that
>>> the failure scenario is basically infinite loop.
> 
>> I don't see the problem with that. If you're really concerned you can
>> set a statement timeout.
> 
> I don't think "change the test" is the right response here.
> I think the problem is that we're disconnecting from the slot at the
> wrong step of backend shutdown, and that we need to fix that before
> it bites us on some more painful parts of our anatomies.  You can't
> just throw darts at the code when deciding where to do things, and
> proc.c is NOT the place that should be concerned with replication
> slots.
> 

It has been concerned with replication slots since 9.4 so it's not like
it's newly invented concern. As Andres says, we don't have better place
to put it to at the moment.

-- 
  Petr Jelinek                  http://www.2ndQuadrant.com/
  PostgreSQL Development, 24x7 Support, Training & Services


-- 
Sent via pgsql-committers mailing list (pgsql-committers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-committers



view thread (22+ messages)  latest in thread

Message-ID: <495584eb-c8c8-90ba-0e21-1b0ecc148bf4@2ndquadrant.com>
Permalink:  ../495584eb-c8c8-90ba-0e21-1b0ecc148bf4@2ndquadrant.com/
Also on:    postgresql.org/message-id/495584eb-c8c8-90ba-0e21-1b0ecc148bf4@2ndquadrant.com

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: petr.jelinek@2ndquadrant.com, tgl@sss.pgh.pa.us, andres@anarazel.de, peter_e@gmx.net
  Subject: Re: pgsql: Add support for temporary replication slots
  In-Reply-To: <495584eb-c8c8-90ba-0e21-1b0ecc148bf4@2ndquadrant.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox