pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andrew Dunstan <andrew@dunslane.net>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa
Date: Fri, 6 May 2022 10:12:36 -0400
Message-ID: <5be02606-a9de-9252-5277-269cae0ad1f0@dunslane.net> (raw)
In-Reply-To: <Ym+DAUUbc7LpseOf@paquier.xyz>
References: <E1nJpf1-0003FC-Od@gemulon.postgresql.org>
	<14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net>
	<Ym6IAq48gBBm5Ujv@paquier.xyz>
	<12a044c9-e982-48d9-dd29-be1216a08805@dunslane.net>
	<Ym+DAUUbc7LpseOf@paquier.xyz>


On 2022-05-02 Mo 03:06, Michael Paquier wrote:
> On Sun, May 01, 2022 at 10:18:37AM -0400, Andrew Dunstan wrote:
>> IIRC we know that tar will be available on Windows.
> What about gzip?  Are the binaries and the libraries split into
> different packages for this package manager on Windows?  We've never
> assumed that this is possible on ./configure, but it would make sense
> to make MSVC able to manage this case.


vcpkg doesn't install any.exe files AFAICS, just DLLs, headers, .lib
files etc.


>
>> I don't think we should do that check for every time we call
>> vc_regress.pl, that seems wasteful. Maybe do it if the command is one
>> that might require these commands, which I think would be bincheck or
>> taptest. And/Or stash some status somewhere?
> Mostly.  We also care about gzip in contrib/basebackup_to_shell/,
> though contribcheck does not run the TAP tests of contrib/ modules.
> As you say, setting up those variables in bincheck and taptest would
> be enough.


That would be a start. Maybe meson will us get rid of some of this mess ...


cheers


andrew

--
Andrew Dunstan
EDB: https://www.enterprisedb.com






view thread (11+ messages)  latest in thread

Message-ID: <5be02606-a9de-9252-5277-269cae0ad1f0@dunslane.net>
Permalink:  ../5be02606-a9de-9252-5277-269cae0ad1f0@dunslane.net/
Also on:    postgresql.org/message-id/5be02606-a9de-9252-5277-269cae0ad1f0@dunslane.net

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andrew@dunslane.net, michael@paquier.xyz
  Subject: Re: pgsql: Remove command checks in tests of pg_basebackup and pg_receivewa
  In-Reply-To: <5be02606-a9de-9252-5277-269cae0ad1f0@dunslane.net>
  References: <E1nJpf1-0003FC-Od@gemulon.postgresql.org> <14402151-376b-a57a-6d0c-10ad12608e12@dunslane.net> <Ym6IAq48gBBm5Ujv@paquier.xyz> <12a044c9-e982-48d9-dd29-be1216a08805@dunslane.net> <Ym+DAUUbc7LpseOf@paquier.xyz> <5be02606-a9de-9252-5277-269cae0ad1f0@dunslane.net>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox