pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Daniel Gustafsson <daniel@yesql.se>
To: Andres Freund <andres@anarazel.de>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Amit Kapila <akapila@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: pgsql: Remove unused wait events.
Date: Mon, 25 Oct 2021 20:03:54 +0200
Message-ID: <97058FA5-5B76-4FD4-B741-9A39E7544EE6@yesql.se> (raw)
In-Reply-To: <20211025180122.th5rm5mhg766qd2u@alap3.anarazel.de>
References: <E1mdOBY-0005j2-QL@gemulon.postgresql.org>
	<CA+TgmoYSAsxiHqpyDCzJa2-hYv0Sme7Me1esi6sHG6LbY8KD+w@mail.gmail.com>
	<4047667.1635179918@sss.pgh.pa.us>
	<CA+TgmoZ2W5Pqq19kzN5K-Boveq0u1v5az7wFJcUhHdZ18aw7_A@mail.gmail.com>
	<4050629.1635182306@sss.pgh.pa.us>
	<1611CCCC-E0E8-4A74-A95B-80ECCE987145@yesql.se>
	<4052153.1635183584@sss.pgh.pa.us>
	<20211025180122.th5rm5mhg766qd2u@alap3.anarazel.de>

> On 25 Oct 2021, at 20:01, Andres Freund <andres@anarazel.de> wrote:
> 
> On 2021-10-25 13:39:44 -0400, Tom Lane wrote:
>> Daniel Gustafsson <daniel@yesql.se> writes:
>>> Since this will cause integer values to have different textual enum value
>>> representations in 14 and 15+, do we want to skip two numbers by assigning the
>>> next wait event the integer value of WAIT_EVENT_WAL_WRITE incremented by three?
>>> Or enum integer reuse not something we guarantee against across major versions?
>> 
>> We require a recompile across major versions.  I don't see a reason why
>> this particular enum needs more stability than any other one.
> 
> +1. That'd end up pushing us to be more conservative about defining new wait
> events, which I think would be bad tradeoff.

Fair enough, makes sense.

--
Daniel Gustafsson		https://vmware.com/

view thread (14+ messages)  latest in thread

Message-ID: <97058FA5-5B76-4FD4-B741-9A39E7544EE6@yesql.se>
Permalink:  ../97058FA5-5B76-4FD4-B741-9A39E7544EE6@yesql.se/
Also on:    postgresql.org/message-id/97058FA5-5B76-4FD4-B741-9A39E7544EE6@yesql.se

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: daniel@yesql.se, andres@anarazel.de, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, akapila@postgresql.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: pgsql: Remove unused wait events.
  In-Reply-To: <97058FA5-5B76-4FD4-B741-9A39E7544EE6@yesql.se>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox