pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Thomas Munro <thomas.munro@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers <pgsql-committers@lists.postgresql.org>
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Date: Tue, 6 Apr 2021 10:37:53 +0900
Message-ID: <YGu7ceWAiSNQDgH5@paquier.xyz> (raw)
In-Reply-To: <CA+hUKGLvexxLBAB_Mb=Eqr6iERW-z74pMVAgKinJ_HK0ZK4O7g@mail.gmail.com>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
	<513200.1617634642@sss.pgh.pa.us>
	<YGuSe6Q484Eshj2n@paquier.xyz>
	<932059.1617663467@sss.pgh.pa.us>
	<933130.1617665023@sss.pgh.pa.us>
	<YGunFpb3U9zi5DV4@paquier.xyz>
	<935457.1617668131@sss.pgh.pa.us>
	<CA+hUKGLvexxLBAB_Mb=Eqr6iERW-z74pMVAgKinJ_HK0ZK4O7g@mail.gmail.com>

On Tue, Apr 06, 2021 at 12:30:48PM +1200, Thomas Munro wrote:
> Commit f44b9b62 springs to mind.

Right.  The kerberos suite does not do that though, so wouldn't it be
better to use the same trick with -c?  For example, the attached for
~13 does so.
--
Michael

Attachments:


kerberos-auth-fail.patch (text/x-diff, 596B) download
diff --git a/src/test/kerberos/t/001_auth.pl b/src/test/kerberos/t/001_auth.pl
index d476a7800e..8d49847948 100644
--- a/src/test/kerberos/t/001_auth.pl
+++ b/src/test/kerberos/t/001_auth.pl
@@ -177,13 +177,15 @@ sub test_access
 	# need to connect over TCP/IP for Kerberos
 	my ($res, $stdoutres, $stderrres) = $node->psql(
 		'postgres',
-		"$query",
+		undef,
 		extra_params => [
 			'-XAtd',
 			$node->connstr('postgres')
 			  . " host=$host hostaddr=$hostaddr $gssencmode",
 			'-U',
-			$role
+			$role,
+			'-c',
+			$query
 		]);
 
 	# If we get a query result back, it should be true.


  signature.asc (application/pgp-signature, 832B) download

view thread (15+ messages)  latest in thread

Message-ID: <YGu7ceWAiSNQDgH5@paquier.xyz>
Permalink:  ../YGu7ceWAiSNQDgH5@paquier.xyz/
Also on:    postgresql.org/message-id/YGu7ceWAiSNQDgH5@paquier.xyz

 ·  · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: michael@paquier.xyz, thomas.munro@gmail.com, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
  In-Reply-To: <YGu7ceWAiSNQDgH5@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox