From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Date: Tue, 6 Apr 2021 09:27:26 +0900
Message-ID: <YGuq7obSb5BviTHz@paquier.xyz> (raw)
In-Reply-To: <935457.1617668131@sss.pgh.pa.us>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
<513200.1617634642@sss.pgh.pa.us>
<YGuSe6Q484Eshj2n@paquier.xyz>
<932059.1617663467@sss.pgh.pa.us>
<933130.1617665023@sss.pgh.pa.us>
<YGunFpb3U9zi5DV4@paquier.xyz>
<935457.1617668131@sss.pgh.pa.us>
On Mon, Apr 05, 2021 at 08:15:31PM -0400, Tom Lane wrote:
> Dunno. Certainly most animals that enable TAP at all should be
> running the "authentication" test, but those others all need to
> be manually enabled, I believe. My own animals run the SSL test
> but not LDAP or kerberos.
The SSL tests have always sent down a query even for scenarios where
the connection would fail, but they have used command_fails_like()
rather than PostgresNode::psql. The puzzle does not seem complete.
> I'm fairly sure that we've previously fixed this exact same issue
> in some tests that expected a connection failure ...
Yeah. Looking at the git history, that would be c757a3da.
test_access() in the kerberos tests sends a SELECT true even for
expected failures, so it seems to me that it would fail with the same
symptoms on those machines. That looks worth fixing and
backpatching.
And I need more caffeine this morning.. I missed your point that a
connection failure should pass down an undefined query string per
that. Well, the fix is simple then now that there is a single code
path for all those connection attempts.
--
Michael
Attachments:
signature.asc (application/pgp-signature, 832B) download
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-committers@postgresql.org
Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
In-Reply-To: <YGuq7obSb5BviTHz@paquier.xyz>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox