public inbox for [email protected]help / color / mirror / Atom feed
[PATCH] log_statement docs 7+ messages / 3 participants [nested] [flat]
* [PATCH] log_statement docs @ 2010-02-25 02:42 gabrielle <[email protected]> 2010-02-25 03:14 ` Re: [PATCH] log_statement docs Tom Lane <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: gabrielle @ 2010-02-25 02:42 UTC (permalink / raw) To: pgsql-docs Patch amends description of log_statement to include definition of "all" option. gabrielle Attachments: [text/x-patch] log_statement.patch (1.1K, 2-log_statement.patch) download | inline diff: From b48f3187ade475570df1eeca1721cf58204ee842 Mon Sep 17 00:00:00 2001 From: Gabrielle Roth <[email protected]> Date: Wed, 24 Feb 2010 18:34:03 -0800 Subject: [PATCH] Amend description of log_statement - add definition of "all" option. --- doc/src/sgml/config.sgml | 4 +++- 1 files changed, 3 insertions(+), 1 deletions(-) diff --git a/doc/src/sgml/config.sgml b/doc/src/sgml/config.sgml index df1d5f1..840b239 100644 --- a/doc/src/sgml/config.sgml +++ b/doc/src/sgml/config.sgml @@ -3373,7 +3373,9 @@ FROM pg_stat_activity; <literal>ddl</> statements, plus data-modifying statements such as <command>INSERT</>, <command>UPDATE</>, <command>DELETE</>, <command>TRUNCATE</>, - and <command>COPY FROM</>. + and <command>COPY FROM</>. + <literal>all</> includes <literal>ddl</> and <literal>mod</>, + plus <command>SELECT</>. <command>PREPARE</>, <command>EXECUTE</>, and <command>EXPLAIN ANALYZE</> statements are also logged if their contained command is of an appropriate type. For clients using -- 1.7.0 ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [PATCH] log_statement docs 2010-02-25 02:42 [PATCH] log_statement docs gabrielle <[email protected]> @ 2010-02-25 03:14 ` Tom Lane <[email protected]> 2010-02-25 17:21 ` Re: [PATCH] log_statement docs gabrielle <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Tom Lane @ 2010-02-25 03:14 UTC (permalink / raw) To: gabrielle <[email protected]>; +Cc: pgsql-docs gabrielle <[email protected]> writes: > Patch amends description of log_statement to include definition of "all" option. Shouldn't it just say "all means all", if we think that needs to be explained? regards, tom lane ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [PATCH] log_statement docs 2010-02-25 02:42 [PATCH] log_statement docs gabrielle <[email protected]> 2010-02-25 03:14 ` Re: [PATCH] log_statement docs Tom Lane <[email protected]> @ 2010-02-25 17:21 ` gabrielle <[email protected]> 2010-02-25 18:47 ` Re: [PATCH] log_statement docs Bruce Momjian <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: gabrielle @ 2010-02-25 17:21 UTC (permalink / raw) To: Tom Lane <[email protected]>; +Cc: pgsql-docs On Wed, Feb 24, 2010 at 7:14 PM, Tom Lane <[email protected]> wrote: > gabrielle <[email protected]> writes: >> Patch amends description of log_statement to include definition of "all" option. > > Shouldn't it just say "all means all", if we think that needs to be > explained? I think it should say something about the "all" option. I read & re-read that section trying to figure out what the difference between "mod" and "all" was, and finally asked on the irc channel. As it stands, it essentially says "there are three options to this command, but we're only going to tell you about two of them." :) Thanks! gabrielle ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [PATCH] log_statement docs 2010-02-25 02:42 [PATCH] log_statement docs gabrielle <[email protected]> 2010-02-25 03:14 ` Re: [PATCH] log_statement docs Tom Lane <[email protected]> 2010-02-25 17:21 ` Re: [PATCH] log_statement docs gabrielle <[email protected]> @ 2010-02-25 18:47 ` Bruce Momjian <[email protected]> 2010-02-25 19:07 ` Re: [PATCH] log_statement docs Tom Lane <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Bruce Momjian @ 2010-02-25 18:47 UTC (permalink / raw) To: gabrielle <[email protected]>; +Cc: Tom Lane <[email protected]>; pgsql-docs gabrielle wrote: > On Wed, Feb 24, 2010 at 7:14 PM, Tom Lane <[email protected]> wrote: > > gabrielle <[email protected]> writes: > >> Patch amends description of log_statement to include definition of "all" option. > > > > Shouldn't it just say "all means all", if we think that needs to be > > explained? > > I think it should say something about the "all" option. I read & > re-read that section trying to figure out what the difference between > "mod" and "all" was, and finally asked on the irc channel. As it > stands, it essentially says "there are three options to this command, > but we're only going to tell you about two of them." :) Well, if you take a look at utility.c:GetCommandLogLevel() you will see that ALL includes a lot more commands than just SELECT. -- Bruce Momjian <[email protected]> http://momjian.us EnterpriseDB http://enterprisedb.com PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do + If your life is a hard drive, Christ can be your backup. + ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [PATCH] log_statement docs 2010-02-25 02:42 [PATCH] log_statement docs gabrielle <[email protected]> 2010-02-25 03:14 ` Re: [PATCH] log_statement docs Tom Lane <[email protected]> 2010-02-25 17:21 ` Re: [PATCH] log_statement docs gabrielle <[email protected]> 2010-02-25 18:47 ` Re: [PATCH] log_statement docs Bruce Momjian <[email protected]> @ 2010-02-25 19:07 ` Tom Lane <[email protected]> 2010-02-25 19:20 ` Re: [PATCH] log_statement docs Bruce Momjian <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Tom Lane @ 2010-02-25 19:07 UTC (permalink / raw) To: Bruce Momjian <[email protected]>; +Cc: gabrielle <[email protected]>; pgsql-docs Bruce Momjian <[email protected]> writes: > gabrielle wrote: >> On Wed, Feb 24, 2010 at 7:14 PM, Tom Lane <[email protected]> wrote: >>> Shouldn't it just say "all means all", if we think that needs to be >>> explained? >> >> I think it should say something about the "all" option. I read & >> re-read that section trying to figure out what the difference between >> "mod" and "all" was, and finally asked on the irc channel. As it >> stands, it essentially says "there are three options to this command, >> but we're only going to tell you about two of them." :) > Well, if you take a look at utility.c:GetCommandLogLevel() you will see > that ALL includes a lot more commands than just SELECT. Yeah. My objection was not to documenting ALL, it was to documenting it with exactly that sentence, which seems both needlessly complicated and subject to errors of omission. regards, tom lane ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [PATCH] log_statement docs 2010-02-25 02:42 [PATCH] log_statement docs gabrielle <[email protected]> 2010-02-25 03:14 ` Re: [PATCH] log_statement docs Tom Lane <[email protected]> 2010-02-25 17:21 ` Re: [PATCH] log_statement docs gabrielle <[email protected]> 2010-02-25 18:47 ` Re: [PATCH] log_statement docs Bruce Momjian <[email protected]> 2010-02-25 19:07 ` Re: [PATCH] log_statement docs Tom Lane <[email protected]> @ 2010-02-25 19:20 ` Bruce Momjian <[email protected]> 2010-02-25 19:27 ` Re: [PATCH] log_statement docs gabrielle <[email protected]> 0 siblings, 1 reply; 7+ messages in thread From: Bruce Momjian @ 2010-02-25 19:20 UTC (permalink / raw) To: Tom Lane <[email protected]>; +Cc: gabrielle <[email protected]>; pgsql-docs Tom Lane wrote: > Bruce Momjian <[email protected]> writes: > > gabrielle wrote: > >> On Wed, Feb 24, 2010 at 7:14 PM, Tom Lane <[email protected]> wrote: > >>> Shouldn't it just say "all means all", if we think that needs to be > >>> explained? > >> > >> I think it should say something about the "all" option. I read & > >> re-read that section trying to figure out what the difference between > >> "mod" and "all" was, and finally asked on the irc channel. As it > >> stands, it essentially says "there are three options to this command, > >> but we're only going to tell you about two of them." :) > > > Well, if you take a look at utility.c:GetCommandLogLevel() you will see > > that ALL includes a lot more commands than just SELECT. > > Yeah. My objection was not to documenting ALL, it was to documenting it > with exactly that sentence, which seems both needlessly complicated and > subject to errors of omission. I have applied the following patch with adds "off" and "all statements" identifiers. This is probaby the right level of detail for this. -- Bruce Momjian <[email protected]> http://momjian.us EnterpriseDB http://enterprisedb.com PG East: http://www.enterprisedb.com/community/nav-pg-east-2010.do + If your life is a hard drive, Christ can be your backup. + Attachments: [text/x-diff] /rtmp/diff (1.3K, 2-%2Frtmp%2Fdiff) download | inline diff: Index: doc/src/sgml/config.sgml =================================================================== RCS file: /cvsroot/pgsql/doc/src/sgml/config.sgml,v retrieving revision 1.253 diff -c -c -r1.253 config.sgml *** doc/src/sgml/config.sgml 25 Feb 2010 13:26:15 -0000 1.253 --- doc/src/sgml/config.sgml 25 Feb 2010 19:19:14 -0000 *************** *** 3392,3399 **** <listitem> <para> Controls which SQL statements are logged. Valid values are ! <literal>none</>, <literal>ddl</>, <literal>mod</>, and ! <literal>all</>. <literal>ddl</> logs all data definition statements, such as <command>CREATE</>, <command>ALTER</>, and <command>DROP</> statements. <literal>mod</> logs all <literal>ddl</> statements, plus data-modifying statements --- 3392,3399 ---- <listitem> <para> Controls which SQL statements are logged. Valid values are ! <literal>none</> (off), <literal>ddl</>, <literal>mod</>, and ! <literal>all</> (all statements). <literal>ddl</> logs all data definition statements, such as <command>CREATE</>, <command>ALTER</>, and <command>DROP</> statements. <literal>mod</> logs all <literal>ddl</> statements, plus data-modifying statements ^ permalink raw reply [nested|flat] 7+ messages in thread
* Re: [PATCH] log_statement docs 2010-02-25 02:42 [PATCH] log_statement docs gabrielle <[email protected]> 2010-02-25 03:14 ` Re: [PATCH] log_statement docs Tom Lane <[email protected]> 2010-02-25 17:21 ` Re: [PATCH] log_statement docs gabrielle <[email protected]> 2010-02-25 18:47 ` Re: [PATCH] log_statement docs Bruce Momjian <[email protected]> 2010-02-25 19:07 ` Re: [PATCH] log_statement docs Tom Lane <[email protected]> 2010-02-25 19:20 ` Re: [PATCH] log_statement docs Bruce Momjian <[email protected]> @ 2010-02-25 19:27 ` gabrielle <[email protected]> 0 siblings, 0 replies; 7+ messages in thread From: gabrielle @ 2010-02-25 19:27 UTC (permalink / raw) To: Bruce Momjian <[email protected]>; +Cc: Tom Lane <[email protected]>; pgsql-docs On Thu, Feb 25, 2010 at 11:20 AM, Bruce Momjian <[email protected]> wrote: > I have applied the following patch with adds "off" and "all statements" > identifiers. This is probaby the right level of detail for this. Thank you! gabrielle ^ permalink raw reply [nested|flat] 7+ messages in thread
end of thread, other threads:[~2010-02-25 19:27 UTC | newest] Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2010-02-25 02:42 [PATCH] log_statement docs gabrielle <[email protected]> 2010-02-25 03:14 ` Tom Lane <[email protected]> 2010-02-25 17:21 ` gabrielle <[email protected]> 2010-02-25 18:47 ` Bruce Momjian <[email protected]> 2010-02-25 19:07 ` Tom Lane <[email protected]> 2010-02-25 19:20 ` Bruce Momjian <[email protected]> 2010-02-25 19:27 ` gabrielle <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox