public inbox for [email protected]help / color / mirror / Atom feed
bloom documentation patch 4+ messages / 3 participants [nested] [flat]
* bloom documentation patch @ 2018-10-14 21:14 Oleg Bartunov <[email protected]> 2018-10-14 21:47 ` Re: bloom documentation patch Thomas Munro <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Oleg Bartunov @ 2018-10-14 21:14 UTC (permalink / raw) To: [email protected] Hi, Please, consider attached patch, which improves contrib/bloom documentation. Best regards, Oleg -- Postgres Professional: http://www.postgrespro.com The Russian Postgres Company Attachments: [application/octet-stream] bloom.sgml.patch (943B, 2-bloom.sgml.patch) download | inline diff: --- bloom.sgml.old 2018-07-24 16:40:23.000000000 +0300 +++ bloom.sgml 2018-10-15 00:11:01.000000000 +0300 @@ -51,8 +51,8 @@ <term><literal>length</literal></term> <listitem> <para> - Length of each signature (index entry) in bits. The default - is <literal>80</literal> bits and maximum is <literal>4096</literal>. + Length of each signature (index entry) in bits, it is rounded up to the nearest + multiple of 16. The default is <literal>80</literal> bits and maximum is <literal>4096</literal>. </para> </listitem> </varlistentry> @@ -242,6 +242,16 @@ operations in the future. </para> </listitem> + + <listitem> + <para> + Bloom AM doesn't supports <literal>unique</literal> indexes. + </listitem> + + <listitem> + <para> + Bloom AM doesn't supports <literal>NULL</literal> values. + </listitem> </itemizedlist> </para> </sect2> ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: bloom documentation patch 2018-10-14 21:14 bloom documentation patch Oleg Bartunov <[email protected]> @ 2018-10-14 21:47 ` Thomas Munro <[email protected]> 2018-10-17 20:45 ` Re: bloom documentation patch Oleg Bartunov <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Thomas Munro @ 2018-10-14 21:47 UTC (permalink / raw) To: [email protected]; +Cc: [email protected] On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov <[email protected]> wrote: > Please, consider attached patch, which improves contrib/bloom documentation. Hello Oleg, I have no comment on the technical details but here is some proof-reading of the English: + Length of each signature (index entry) in bits, it is rounded up to the nearest + multiple of 16. The default is <literal>80</literal> bits and maximum is s/, it is/. It is/ s/and maximum/and the maximum/ + Bloom AM doesn't supports <literal>unique</literal> indexes. s/supports/support/ + Bloom AM doesn't supports <literal>NULL</literal> values. s/supports/support/ -- Thomas Munro http://www.enterprisedb.com ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: bloom documentation patch 2018-10-14 21:14 bloom documentation patch Oleg Bartunov <[email protected]> 2018-10-14 21:47 ` Re: bloom documentation patch Thomas Munro <[email protected]> @ 2018-10-17 20:45 ` Oleg Bartunov <[email protected]> 2018-10-21 21:33 ` Re: bloom documentation patch Alexander Korotkov <[email protected]> 0 siblings, 1 reply; 4+ messages in thread From: Oleg Bartunov @ 2018-10-17 20:45 UTC (permalink / raw) To: Thomas Munro <[email protected]>; Alexander Korotkov <[email protected]>; +Cc: [email protected] On Mon, Oct 15, 2018 at 12:48 AM Thomas Munro <[email protected]> wrote: > > On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov <[email protected]> wrote: > > Please, consider attached patch, which improves contrib/bloom documentation. > > Hello Oleg, I have no comment on the technical details but here is > some proof-reading of the English: > > + Length of each signature (index entry) in bits, it is rounded > up to the nearest > + multiple of 16. The default is <literal>80</literal> bits and maximum is > > s/, it is/. It is/ > s/and maximum/and the maximum/ > > + Bloom AM doesn't supports <literal>unique</literal> indexes. > > s/supports/support/ > > + Bloom AM doesn't supports <literal>NULL</literal> values. > > s/supports/support/ > Thanks, Thomas, new patch attached. > -- > Thomas Munro > http://www.enterprisedb.com > -- Postgres Professional: http://www.postgrespro.com The Russian Postgres Company Attachments: [application/octet-stream] bloom.sgml.patch (623B, 2-bloom.sgml.patch) download | inline diff: --- bloom.sgml.old 2018-10-15 11:56:17.000000000 +0300 +++ bloom.sgml 2018-10-17 23:40:30.000000000 +0300 @@ -51,9 +51,9 @@ <term><literal>length</literal></term> <listitem> <para> - Length of each signature (index entry) in bits, it is rounded up to the + Length of each signature (index entry) in bits. It is rounded up to the nearest multiple of <literal>16</literal>. The default is - <literal>80</literal> bits and maximum is <literal>4096</literal>. + <literal>80</literal> bits and the maximum is <literal>4096</literal>. </para> </listitem> </varlistentry> ^ permalink raw reply [nested|flat] 4+ messages in thread
* Re: bloom documentation patch 2018-10-14 21:14 bloom documentation patch Oleg Bartunov <[email protected]> 2018-10-14 21:47 ` Re: bloom documentation patch Thomas Munro <[email protected]> 2018-10-17 20:45 ` Re: bloom documentation patch Oleg Bartunov <[email protected]> @ 2018-10-21 21:33 ` Alexander Korotkov <[email protected]> 0 siblings, 0 replies; 4+ messages in thread From: Alexander Korotkov @ 2018-10-21 21:33 UTC (permalink / raw) To: Oleg Bartunov <[email protected]>; +Cc: Thomas Munro <[email protected]>; [email protected] On Wed, Oct 17, 2018 at 11:45 PM Oleg Bartunov <[email protected]> wrote: > On Mon, Oct 15, 2018 at 12:48 AM Thomas Munro > <[email protected]> wrote: > > > > On Mon, Oct 15, 2018 at 10:15 AM Oleg Bartunov <[email protected]> wrote: > > > Please, consider attached patch, which improves contrib/bloom documentation. > > > > Hello Oleg, I have no comment on the technical details but here is > > some proof-reading of the English: > > > > + Length of each signature (index entry) in bits, it is rounded > > up to the nearest > > + multiple of 16. The default is <literal>80</literal> bits and maximum is > > > > s/, it is/. It is/ > > s/and maximum/and the maximum/ Thank you for these corrections. They are pushed. > > + Bloom AM doesn't supports <literal>unique</literal> indexes. > > > > s/supports/support/ > > > > + Bloom AM doesn't supports <literal>NULL</literal> values. > > > > s/supports/support/ These two were already fixed in the version I've pushed before. ------ Alexander Korotkov Postgres Professional: http://www.postgrespro.com The Russian Postgres Company ^ permalink raw reply [nested|flat] 4+ messages in thread
end of thread, other threads:[~2018-10-21 21:33 UTC | newest] Thread overview: 4+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2018-10-14 21:14 bloom documentation patch Oleg Bartunov <[email protected]> 2018-10-14 21:47 ` Thomas Munro <[email protected]> 2018-10-17 20:45 ` Oleg Bartunov <[email protected]> 2018-10-21 21:33 ` Alexander Korotkov <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox