From: Tom Lane <tgl@sss.pgh.pa.us>
To: Sergei Kornilov <sk@zsrv.org>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: Ildar Musin <i.musin@postgrespro.ru>
Cc: Stephen Frost <sfrost@snowman.net>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
Date: Tue, 06 Mar 2018 13:51:53 -0500
Message-ID: <1142.1520362313@sss.pgh.pa.us> (raw)
In-Reply-To: <1715451520361128@web26o.yandex.ru>
References: <880511520351578@web5j.yandex.ru>
<20180306172528.xnelm3xcq2qeyd2g@alvherre.pgsql>
<1715451520361128@web26o.yandex.ru>
Sergei Kornilov <sk@zsrv.org> writes:
>> ISTM that depending on DEBUG messages is bad because debugging lines
>> added elsewhere will make your tests fail;
> I agree and this is reason why i not used DEBUG message in tests as was proposed. I found INFO messages in tests and decided that this was an acceptable option year ago.
INFO is for user-facing messages, such as output from VACUUM VERBOSE,
where the user has specifically requested the output. I do not think
this falls into that category. Even if you persuade some committer
to commit it like that, there will be user pushback asking us to get
this noise out of their faces ... and then we'll have to find some
other way to test it.
Do you actually need test output proving that this code path was taken
rather than the default one? Seems like looking at the code coverage
report might be enough.
> In this case we need remove INFO from ALTER TABLE ATTACH PARTITION code and tests. I think is a bad idea of using different rules for same stuff, right? Probably i can do this work too.
I did not see any INFO messages in a quick test of ALTER TABLE ATTACH
PARTITION, but if there are any lurking in there, they probably need
to be downgraded.
regards, tom lane
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: tgl@sss.pgh.pa.us, sk@zsrv.org, alvherre@alvh.no-ip.org, i.musin@postgrespro.ru, sfrost@snowman.net, robertmhaas@gmail.com
Subject: Re: using index or check in ALTER TABLE SET NOT NULL
In-Reply-To: <1142.1520362313@sss.pgh.pa.us>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox