pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed
From: Nathan Bossart <nathandbossart@gmail.com>
To: Daniel Gustafsson <daniel@yesql.se>
Cc: bt23nguyent <bt23nguyent@oss.nttdata.com>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
Date: Mon, 4 Mar 2024 15:50:48 -0600
Message-ID: <20240304215048.GA3367383@nathanxps13> (raw)
In-Reply-To: <1DFBEAE6-01A6-49E8-8360-BA9113E33092@yesql.se>
References: <D3038255-EAB5-4164-A9E3-7967B6738993@yesql.se>
	<18cbd8ca6f5390cda2920644f891a419@oss.nttdata.com>
	<20230925222047.GA3173226@nathanxps13>
	<482056B1-D930-417C-9473-CB1A045E42AE@yesql.se>
	<20231013022559.GA1266364@nathanxps13>
	<E863EDCA-EFEA-4DFA-9E93-024D464DE260@yesql.se>
	<20240105230357.GA2425960@nathanxps13>
	<AB31C950-5BA6-49F2-ADF9-F8E8334EB4A2@yesql.se>
	<20240304172252.GA3161951@nathanxps13>
	<1DFBEAE6-01A6-49E8-8360-BA9113E33092@yesql.se>

On Mon, Mar 04, 2024 at 09:27:23PM +0100, Daniel Gustafsson wrote:
> Looks good from a read-through, I like it.  A few comments on the commit
> message only:
> 
> actionable details about the source of the miconfiguration.  This
> s/miconfiguration/misconfiguration/

I reworded the commit message a bit to avoid the word "misconfiguration,"
as it felt a bit misleading to me.  In any case, this was fixed, albeit
indirectly.

> Reviewed-by: Daniel Gustafsson, ¡lvaro Herrera
> Alvaro's name seems wrong.

Hm.  It looks alright to me.  I copied the name from his e-mail signature,
which has an accent over the first 'A'.  I assume that's why it's not
showing up correctly in some places.

Anyway, I've committed this now.  Thanks for taking a look!

-- 
Nathan Bossart
Amazon Web Services: https://aws.amazon.com





view thread (22+ messages)  latest in thread

Message-ID: <20240304215048.GA3367383@nathanxps13>
Permalink:  ../20240304215048.GA3367383@nathanxps13/
Also on:    postgresql.org/message-id/20240304215048.GA3367383@nathanxps13

 · 

reply
Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: nathandbossart@gmail.com, daniel@yesql.se, bt23nguyent@oss.nttdata.com, alvherre@alvh.no-ip.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: Improve the log message output of basic_archive when basic_archive.archive_directory parameter is not set
  In-Reply-To: <20240304215048.GA3367383@nathanxps13>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox