pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Dave Page <dpage@pgadmin.org>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pl/perl extension fails on Windows
Date: Fri, 28 Jul 2017 12:35:22 -0400
Message-ID: <21578.1501259722@sss.pgh.pa.us> (raw)
In-Reply-To: <CAE9k0PkRSv7dskzo2pBCWvCk9YSQo1b3jfyBYUVT1v6uoEV+Bw@mail.gmail.com>
References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com>
	<CAE9k0PkWhEeNS4b5bnoQLeZsnqe4zqkr=4GhN2Ybt1nSsBFk2g@mail.gmail.com>
	<184f1fb9-dfa2-ef2d-024b-7933486e018a@2ndQuadrant.com>
	<16093.1499956602@sss.pgh.pa.us>
	<bb3d3eb6-e310-471c-1d8c-d239ecaf52ad@2ndQuadrant.com>
	<7480.1499965218@sss.pgh.pa.us>
	<CAE9k0Pnvw63MLR=dT1NYdL_t_ptyFqW1ueJwixcsmobadpFWng@mail.gmail.com>
	<30585.1500480763@sss.pgh.pa.us>
	<CAE9k0PnQzRRYEGy1j51D6F-fZeHWoy2GAghewBORWNjwg44y5g@mail.gmail.com>
	<32468.1500498091@sss.pgh.pa.us>
	<CA+TgmoY=3ApjWL0Y0Z_qdDVuK_koP9H_euHMewG06ukWxBW2Cw@mail.gmail.com>
	<CA+TgmoYqTcE8Q-GsfHJvndQPit7iqf63YY=BtGhZM7+qGjfy+g@mail.gmail.com>
	<20729.1501039314@sss.pgh.pa.us>
	<CAE9k0Pkya48GWPF7CViFu7zrJeQGm7Jzs0Wvkx2O1yAsi7EPgQ@mail.gmail.com>
	<22864.1501165302@sss.pgh.pa.us>
	<CA+Tgmobkc5u1hGP48XvtgLFuK8CFYpBVMDGQFqtGpV2Xetz1cQ@mail.gmail.com>
	<29418.1501187612@sss.pgh.pa.us>
	<03b6bc63-93d9-59c5-6e56-822bee04f739@2ndQuadrant.com>
	<CAE9k0P=hMFew=VxNGTeOJJr32+UD! y-o2qWXrThHg524EBqvnZQ@mail.gmail.com>
	<25190.1501249960@sss.pgh.pa.us>
	<CAE9k0PkRSv7dskzo2pBCWvCk9YSQo1b3jfyBYUVT1v6uoEV+Bw@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Ashutosh Sharma <ashu.coek88@gmail.com> writes:
> On Fri, Jul 28, 2017 at 7:22 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Assuming that the Perl crew know what they're doing and this list is
>> complete, I notice that not one of the symbols they show as relevant
>> starts with an underscore.  So I'm thinking that my previous semi-
>> joking idea of absorbing only -D switches for names that *don't*
>> start with an underscore was actually a good solution.

> Okay, as per your suggestion, I have modified my earlier patches that
> imports the -D switches used by perl into plperl accordingly i.e. it
> now ignores the switches whose name starts with underscore. Please
> find plperl_win_v3 and plperl_linux_v2 patches attached with this
> email.

OK, thanks.  I've pushed the XSUB/dTHX patch after another round of
code-reading and some minor comment improvements; we'll soon see
what the buildfarm thinks of it.  In the meantime I'll work on these
two patches.

>> (BTW, you never did tell us exactly what defines you're getting
>> out of Perl's flags on the problem installation.)

> I am really sorry about that. I just missed that in my earlier email.
> Here are the defines used in the perl where i could reproduce the
> issue,

> C:\Users\ashu>perl -MConfig -e "print $Config{ccflags}"
> -nologo -GF -W3 -O1 -MD -Zi -DNDEBUG -GL -fp:precise -DWIN32
> -D_CONSOLE -DNO_STRICT -DWIN64 -DCONSERVATIVE  -DUSE_SITECUSTOMIZE
> -DPERL_TEXTMODE_SCRIPTS -DPERL_IMPLICIT_CONTEXT -DPERL_IMPLICIT_SYS

Uh-huh.  So the issue is indeed that they're injecting PERL_IMPLICIT_SYS
via a command-line #define rather than putting it into perl's config.h,
and that results in a change in the apparent size of the PerlInterp
struct (because of IMem and friends).  We'd expected as much, but it's
good to have clear confirmation.

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (94+ messages)  latest in thread

Message-ID: <21578.1501259722@sss.pgh.pa.us>
Permalink:  ../21578.1501259722@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/21578.1501259722@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, ashu.coek88@gmail.com, andrew.dunstan@2ndquadrant.com, robertmhaas@gmail.com, dpage@pgadmin.org, sandeep.thakkar@enterprisedb.com
  Subject: Re: pl/perl extension fails on Windows
  In-Reply-To: <21578.1501259722@sss.pgh.pa.us>
  References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com> <16093.1499956602@sss.pgh.pa.us> <bb3d3eb6-e310-471c-1d8c-d239ecaf52ad@2ndQuadrant.com> <7480.1499965218@sss.pgh.pa.us> <CAE9k0Pnvw63MLR=dT1NYdL_t_ptyFqW1ueJwixcsmobadpFWng@mail.gmail.com> <30585.1500480763@sss.pgh.pa.us> <CAE9k0PnQzRRYEGy1j51D6F-fZeHWoy2GAghewBORWNjwg44y5g@mail.gmail.com> <32468.1500498091@sss.pgh.pa.us> <CA+TgmoY=3ApjWL0Y0Z_qdDVuK_koP9H_euHMewG06ukWxBW2Cw@mail.gmail.com> <CA+TgmoYqTcE8Q-GsfHJvndQPit7iqf63YY=BtGhZM7+qGjfy+g@mail.gmail.com> <20729.1501039314@sss.pgh.pa.us> <CAE9k0Pkya48GWPF7CViFu7zrJeQGm7Jzs0Wvkx2O1yAsi7EPgQ@mail.gmail.com> <22864.1501165302@sss.pgh.pa.us> <CA+Tgmobkc5u1hGP48XvtgLFuK8CFYpBVMDGQFqtGpV2Xetz1cQ@mail.gmail.com> <29418.1501187612@sss.pgh.pa.us> <03b6bc63-93d9-59c5-6e56-822bee04f739@2ndQuadrant.com> <25190.1501249960@sss.pgh.pa.us> <CAE9k0PkRSv7dskzo2pBCWvCk9YSQo1b3jfyBYUVT1v6uoEV+Bw@mail.gmail.com> <21578.1501259722@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox