pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Ashutosh Sharma <ashu.coek88@gmail.com>
Cc: Magnus Hagander <magnus@hagander.net>
Cc: Andrew Dunstan <andrew.dunstan@2ndquadrant.com>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Dave Page <dpage@pgadmin.org>
Cc: Sandeep Thakkar <sandeep.thakkar@enterprisedb.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: pl/perl extension fails on Windows
Date: Fri, 28 Jul 2017 14:35:21 -0400
Message-ID: <25248.1501266921@sss.pgh.pa.us> (raw)
In-Reply-To: <CAE9k0PkP0posQmy6B1GJnHOhrcj7k1oxW8gU4N6mc5Z6AbsgmQ@mail.gmail.com>
References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com>
	<CAE9k0PkWhEeNS4b5bnoQLeZsnqe4zqkr=4GhN2Ybt1nSsBFk2g@mail.gmail.com>
	<184f1fb9-dfa2-ef2d-024b-7933486e018a@2ndQuadrant.com>
	<16093.1499956602@sss.pgh.pa.us>
	<bb3d3eb6-e310-471c-1d8c-d239ecaf52ad@2ndQuadrant.com>
	<7480.1499965218@sss.pgh.pa.us>
	<CAE9k0Pnvw63MLR=dT1NYdL_t_ptyFqW1ueJwixcsmobadpFWng@mail.gmail.com>
	<30585.1500480763@sss.pgh.pa.us>
	<CAE9k0PnQzRRYEGy1j51D6F-fZeHWoy2GAghewBORWNjwg44y5g@mail.gmail.com>
	<32468.1500498091@sss.pgh.pa.us>
	<CA+TgmoY=3ApjWL0Y0Z_qdDVuK_koP9H_euHMewG06ukWxBW2Cw@mail.gmail.com>
	<CA+TgmoYqTcE8Q-GsfHJvndQPit7iqf63YY=BtGhZM7+qGjfy+g@mail.gmail.com>
	<20729.1501039314@sss.pgh.pa.us>
	<CAE9k0Pkya48GWPF7CViFu7zrJeQGm7Jzs0Wvkx2O1yAsi7EPgQ@mail.gmail.com>
	<22864.1501165302@sss.pgh.pa.us>
	<CA+Tgmobkc5u1hGP48XvtgLFuK8CFYpBVMDGQFqtGpV2Xetz1cQ@mail.gmail.com>
	<29418.1501187612@sss.pgh.pa.us>
	<03b6bc63-93d9-59c5-6e56-822bee04f739@2ndQuadrant.com>
	<25190.1501249960@sss.pgh.pa.u! s>
	<CAE9k0PkRSv7dskzo2pBCWvCk9YSQo1b3jfyBYUVT1v6uoEV+Bw@mail.gmail.com>
	<21578.1501259722@sss.pgh.pa.us>
	<CAE9k0PkP0posQmy6B1GJnHOhrcj7k1oxW8gU4N6mc5Z6AbsgmQ@mail.gmail.com>
List-Unsubscribe: <mailto:majordomo@postgresql.org?body=unsub%20pgsql-hackers>

Ashutosh Sharma <ashu.coek88@gmail.com> writes:
> On Fri, Jul 28, 2017 at 10:05 PM, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> Uh-huh.  So the issue is indeed that they're injecting PERL_IMPLICIT_SYS
>> via a command-line #define rather than putting it into perl's config.h,
>> and that results in a change in the apparent size of the PerlInterp
>> struct (because of IMem and friends).

> Yes, That's right. We would have seen different result if the
> PERL_IMPLICIT_SYS would not have been defined globally.

I've pushed the changes to the build scripts now.  I had to revise the
Mkvcbuild.pm part a bit, because you'd forgotten to propagate the extra
defines into hstore_plperl.  So that code is untested; please confirm
that HEAD works in your problem environment now.

I notice that Mkvcbuild.pm is artificially injecting a define for
PLPERL_HAVE_UID_GID.  I strongly suspect that that was a hack meant
to work around the lack of this mechanism, and that we could now
get rid of it or clean it up.  But there's no evidence in the commit
log about the reason for it --- it seems to go back to the original
addition of MSVC support.  Anybody remember?

			regards, tom lane


-- 
Sent via pgsql-hackers mailing list (pgsql-hackers@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-hackers



view thread (94+ messages)  latest in thread

Message-ID: <25248.1501266921@sss.pgh.pa.us>
Permalink:  ../25248.1501266921@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/25248.1501266921@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, ashu.coek88@gmail.com, magnus@hagander.net, andrew.dunstan@2ndquadrant.com, robertmhaas@gmail.com, dpage@pgadmin.org, sandeep.thakkar@enterprisedb.com
  Subject: Re: pl/perl extension fails on Windows
  In-Reply-To: <25248.1501266921@sss.pgh.pa.us>
  References: <CANFyU97OVQ3+Mzfmt3MhuUm5NwPU=-FtbNH5Eb7nZL9ua8=rcA@mail.gmail.com> <7480.1499965218@sss.pgh.pa.us> <CAE9k0Pnvw63MLR=dT1NYdL_t_ptyFqW1ueJwixcsmobadpFWng@mail.gmail.com> <30585.1500480763@sss.pgh.pa.us> <CAE9k0PnQzRRYEGy1j51D6F-fZeHWoy2GAghewBORWNjwg44y5g@mail.gmail.com> <32468.1500498091@sss.pgh.pa.us> <CA+TgmoY=3ApjWL0Y0Z_qdDVuK_koP9H_euHMewG06ukWxBW2Cw@mail.gmail.com> <CA+TgmoYqTcE8Q-GsfHJvndQPit7iqf63YY=BtGhZM7+qGjfy+g@mail.gmail.com> <20729.1501039314@sss.pgh.pa.us> <CAE9k0Pkya48GWPF7CViFu7zrJeQGm7Jzs0Wvkx2O1yAsi7EPgQ@mail.gmail.com> <22864.1501165302@sss.pgh.pa.us> <CA+Tgmobkc5u1hGP48XvtgLFuK8CFYpBVMDGQFqtGpV2Xetz1cQ@mail.gmail.com> <29418.1501187612@sss.pgh.pa.us> <03b6bc63-93d9-59c5-6e56-822bee04f739@2ndQuadrant.com> <CAE9k0PkRSv7dskzo2pBCWvCk9YSQo1b3jfyBYUVT1v6uoEV+Bw@mail.gmail.com> <21578.1501259722@sss.pgh.pa.us> <CAE9k0PkP0posQmy6B1GJnHOhrcj7k1oxW8gU4N6mc5Z6AbsgmQ@mail.gmail.com> <25248.1501266921@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox