pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Noah Misch <noah@leadboat.com>
Cc: Andres Freund <andres@anarazel.de>
Cc: Alvaro Herrera <alvherre@alvh.no-ip.org>
Cc: pgsql-hackers@lists.postgresql.org
Subject: Re: Improving isolationtester's data output
Date: Wed, 16 Jun 2021 10:03:52 -0400
Message-ID: <645784.1623852232@sss.pgh.pa.us> (raw)
In-Reply-To: <20210616034323.GA965392@rfd.leadboat.com>
References: <202106152320.xfiprkh4sp5c@alvherre.pgsql>
	<583674.1623799585@sss.pgh.pa.us>
	<20210616013115.2otscs7rwictsolv@alap3.anarazel.de>
	<592938.1623807811@sss.pgh.pa.us>
	<20210616034323.GA965392@rfd.leadboat.com>

Noah Misch <noah@leadboat.com> writes:
> I'm +1 for back-patching this class of change.  I've wasted time adapting a
> back-patch's test case to account for non-back-patched test infrastructure
> changes.  Every back-patch of test infrastructure has been a strict win from
> my perspective.

Hearing few objections, I'll plan on back-patching.  I'm thinking that the
best thing to do is apply these changes after beta2 wraps, but before we
branch v14.  Waiting till after the branch would just create duplicate
work.

BTW, as long as we're thinking of back-patching nontrivial specfile
changes, I have another modest proposal.  What do people think of
removing the requirement for step/session names to be double-quoted,
and instead letting them work like SQL identifiers?  A quick grep
shows that practically all the existing names are plain identifiers,
so we could just drop their quotes for a useful notational savings.
While I haven't actually tried yet, I doubt it'd be hard to adopt
scan.l's identifier rules into specscanner.l.  (Probably wouldn't
bother with auto case-folding, though.)

			regards, tom lane





view thread (17+ messages)  latest in thread

Message-ID: <645784.1623852232@sss.pgh.pa.us>
Permalink:  ../645784.1623852232@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/645784.1623852232@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, noah@leadboat.com, andres@anarazel.de, alvherre@alvh.no-ip.org
  Subject: Re: Improving isolationtester's data output
  In-Reply-To: <645784.1623852232@sss.pgh.pa.us>
  References: <202106152320.xfiprkh4sp5c@alvherre.pgsql> <583674.1623799585@sss.pgh.pa.us> <20210616013115.2otscs7rwictsolv@alap3.anarazel.de> <592938.1623807811@sss.pgh.pa.us> <20210616034323.GA965392@rfd.leadboat.com> <645784.1623852232@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox