pg.ddx.io  pgsql-hackers@postgresql.org mailing list archive  

help / color / mirror / Atom feed

From: Tom Lane <tgl@sss.pgh.pa.us>
To: Peter Eisentraut <peter.eisentraut@enterprisedb.com>
Cc: Jacob Champion <pchampion@vmware.com>
Cc: pgsql-hackers@postgresql.org <pgsql-hackers@postgresql.org>
Subject: Re: SSL SNI
Date: Mon, 07 Jun 2021 11:34:24 -0400
Message-ID: <878795.1623080064@sss.pgh.pa.us> (raw)
In-Reply-To: <5df46438-c1b4-161c-4669-f6e6ab6797f0@enterprisedb.com>
References: <7289d5eb-62a5-a732-c3b9-438cee2cb709@enterprisedb.com>
	<ef3d4b460ae7da59a8811f4e8e8fde0cd38a6cc8.camel@vmware.com>
	<9407b344-7342-b2b7-004f-d5250687be42@enterprisedb.com>
	<ecb6a57d176a396feb959fbb0c53b3c794e8d8e5.camel@vmware.com>
	<4eaa2b56-c3d0-67b6-4716-010d001c7601@enterprisedb.com>
	<4bf3ae1c-b28e-8960-e89f-c390c5cf01a2@enterprisedb.com>
	<504c276ab6eee000bb23d571ea9b0ced4250774e.camel@vmware.com>
	<14368.1622742108@sss.pgh.pa.us>
	<14840.1622742761@sss.pgh.pa.us>
	<15936.1622744081@sss.pgh.pa.us>
	<5df46438-c1b4-161c-4669-f6e6ab6797f0@enterprisedb.com>

Peter Eisentraut <peter.eisentraut@enterprisedb.com> writes:
> Patch attached.  Empty host string was handled implicitly by the IP 
> detection expression, but I added an explicit check for sanity.  (I 
> wasn't actually able to get an empty string to this point, but it's 
> clearly better to be prepared for it.)

Yeah, I'd include the empty-string test just because it's standard
practice in this area of libpq.  Whether those tests are actually
triggerable in every case is obscure, but ...

Patch looks sane by eyeball, though I didn't test it.

			regards, tom lane

view thread (24+ messages)  latest in thread

Message-ID: <878795.1623080064@sss.pgh.pa.us>
Permalink:  ../878795.1623080064@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/878795.1623080064@sss.pgh.pa.us

copy link · copy postgr.es

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-hackers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, peter.eisentraut@enterprisedb.com, pchampion@vmware.com
  Subject: Re: SSL SNI
  In-Reply-To: <878795.1623080064@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox