public inbox for [email protected]help / color / mirror / Atom feed
[PATCH 08/10] Default to zstd.. 3+ messages / 3 participants [nested] [flat]
* [PATCH 08/10] Default to zstd.. @ 2021-03-12 21:35 Justin Pryzby <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Justin Pryzby @ 2021-03-12 21:35 UTC (permalink / raw) for CI, not for merge --- configure | 6 ++++-- configure.ac | 2 +- src/backend/access/transam/xlog.c | 2 +- src/backend/utils/misc/guc.c | 2 +- 4 files changed, 7 insertions(+), 5 deletions(-) diff --git a/configure b/configure index 20c6e08c02..dffe70208b 100755 --- a/configure +++ b/configure @@ -1582,7 +1582,7 @@ Optional Packages: use system time zone data in DIR --without-zlib do not use Zlib --without-lz4 build without LZ4 support - --with-zstd build with Zstd compression library + --without-zstd build without Zstd compression library --with-gnu-ld assume the C compiler uses GNU ld [default=no] --with-ssl=LIB use LIB for SSL/TLS support (openssl) --with-openssl obsolete spelling of --with-ssl=openssl @@ -8740,7 +8740,9 @@ $as_echo "#define USE_ZSTD 1" >>confdefs.h esac else - with_zstd=no + with_zstd=yes + +$as_echo "#define USE_ZSTD 1" >>confdefs.h fi diff --git a/configure.ac b/configure.ac index c4956745ce..780c0e785f 100644 --- a/configure.ac +++ b/configure.ac @@ -1005,7 +1005,7 @@ fi # ZSTD # AC_MSG_CHECKING([whether to build with zstd support]) -PGAC_ARG_BOOL(with, zstd, no, [build with Zstd compression library], +PGAC_ARG_BOOL(with, zstd, yes, [build without Zstd compression library], [AC_DEFINE([USE_ZSTD], 1, [Define to 1 to build with zstd support. (--with-zstd)])]) AC_MSG_RESULT([$with_zstd]) AC_SUBST(with_zstd) diff --git a/src/backend/access/transam/xlog.c b/src/backend/access/transam/xlog.c index 9bac79b579..5a8447a525 100644 --- a/src/backend/access/transam/xlog.c +++ b/src/backend/access/transam/xlog.c @@ -99,7 +99,7 @@ bool EnableHotStandby = false; bool fullPageWrites = true; bool wal_log_hints = false; bool wal_compression = false; -int wal_compression_method = WAL_COMPRESSION_LZ4; +int wal_compression_method = WAL_COMPRESSION_ZSTD; char *wal_consistency_checking_string = NULL; bool *wal_consistency_checking = NULL; bool wal_init_zero = true; diff --git a/src/backend/utils/misc/guc.c b/src/backend/utils/misc/guc.c index 52f9cd0242..8031e027aa 100644 --- a/src/backend/utils/misc/guc.c +++ b/src/backend/utils/misc/guc.c @@ -4728,7 +4728,7 @@ static struct config_enum ConfigureNamesEnum[] = NULL }, &wal_compression_method, - WAL_COMPRESSION_LZ4, wal_compression_options, + WAL_COMPRESSION_ZSTD, wal_compression_options, NULL, NULL, NULL }, -- 2.17.0 --0qVF/w3MHQqLSynd Content-Type: text/x-diff; charset=us-ascii Content-Disposition: attachment; filename="0009-Add-zstd-compression-levels.patch" ^ permalink raw reply [nested|flat] 3+ messages in thread
* Add --check option to pgindent @ 2023-12-12 00:09 Tristan Partin <[email protected]> 0 siblings, 1 reply; 3+ messages in thread From: Tristan Partin @ 2023-12-12 00:09 UTC (permalink / raw) To: pgsql-hackers Not sold on the name, but --check is a combination of --silent-diff and --show-diff. I envision --check mostly being used in CI environments. I recently came across a situation where this behavior would have been useful. Without --check, you're left to capture the output of --show-diff and exit 2 if the output isn't empty by yourself. -- Tristan Partin Neon (https://neon.tech) Attachments: [text/x-patch] v1-0001-Add-check-option-to-pgindent.patch (2.3K, ../../[email protected]/2-v1-0001-Add-check-option-to-pgindent.patch) download | inline diff: From 1001252d49a47e660045cee3d2ba5abd87e925d9 Mon Sep 17 00:00:00 2001 From: Tristan Partin <[email protected]> Date: Mon, 11 Dec 2023 17:34:17 -0600 Subject: [PATCH v1] Add --check option to pgindent The option is a combination of --show-diff and --silent-diff. It is useful for situations such as CI checks where the diff can be logged, but will also cause the build to fail. Without such an option, people are left to re-implement the same logic over and over again. --- src/tools/pgindent/pgindent | 20 +++++++++++++++++--- 1 file changed, 17 insertions(+), 3 deletions(-) diff --git a/src/tools/pgindent/pgindent b/src/tools/pgindent/pgindent index bce63d95da..a285015c76 100755 --- a/src/tools/pgindent/pgindent +++ b/src/tools/pgindent/pgindent @@ -23,7 +23,8 @@ my $devnull = File::Spec->devnull; my ($typedefs_file, $typedef_str, @excludes, $indent, $build, $show_diff, - $silent_diff, $help, @commits,); + $silent_diff, $help, @commits, + $check,); $help = 0; @@ -35,7 +36,8 @@ my %options = ( "excludes=s" => \@excludes, "indent=s" => \$indent, "show-diff" => \$show_diff, - "silent-diff" => \$silent_diff,); + "silent-diff" => \$silent_diff, + "check" => \$check,); GetOptions(%options) || usage("bad command line argument"); usage() if $help; @@ -43,6 +45,12 @@ usage() if $help; usage("Cannot have both --silent-diff and --show-diff") if $silent_diff && $show_diff; +usage("Cannot have both --check and --show-diff") + if $check && $show_diff; + +usage("Cannot have both --check and --silent-diff") + if $check && $silent_diff; + usage("Cannot use --commit with command line file list") if (@commits && @ARGV); @@ -325,6 +333,7 @@ Options: --indent=PATH path to pg_bsd_indent program --show-diff show the changes that would be made --silent-diff exit with status 2 if any changes would be made + --check combination of --show-diff and --silent-diff The --excludes and --commit options can be given more than once. EOF if ($help) @@ -417,7 +426,12 @@ foreach my $source_filename (@files) if ($source ne $orig_source) { - if ($silent_diff) + if ($check) + { + print show_diff($source, $source_filename); + exit 2; + } + elsif ($silent_diff) { exit 2; } -- Tristan Partin Neon (https://neon.tech) ^ permalink raw reply [nested|flat] 3+ messages in thread
* Re: Add --check option to pgindent @ 2023-12-12 00:21 Daniel Gustafsson <[email protected]> parent: Tristan Partin <[email protected]> 0 siblings, 0 replies; 3+ messages in thread From: Daniel Gustafsson @ 2023-12-12 00:21 UTC (permalink / raw) To: Tristan Partin <[email protected]>; +Cc: pgsql-hackers > On 12 Dec 2023, at 01:09, Tristan Partin <[email protected]> wrote: > > Not sold on the name, but --check is a combination of --silent-diff and --show-diff. I envision --check mostly being used in CI environments. I recently came across a situation where this behavior would have been useful. Without --check, you're left to capture the output of --show-diff and exit 2 if the output isn't empty by yourself. I haven’t studied the patch but I can see that being useful. ./daniel ^ permalink raw reply [nested|flat] 3+ messages in thread
end of thread, other threads:[~2023-12-12 00:21 UTC | newest] Thread overview: 3+ messages (download: mbox mbox.gz follow: Atom feed) -- links below jump to the message on this page -- 2021-03-12 21:35 [PATCH 08/10] Default to zstd.. Justin Pryzby <[email protected]> 2023-12-12 00:09 Add --check option to pgindent Tristan Partin <[email protected]> 2023-12-12 00:21 ` Re: Add --check option to pgindent Daniel Gustafsson <[email protected]>
This inbox is served by agora; see mirroring instructions for how to clone and mirror all data and code used for this inbox