From: Benoit Lobréau <benoit.lobreau@dalibo.com>
To: Michael Paquier <michael@paquier.xyz>
To: David Steele <david@pgbackrest.org>
Cc: Andrey M. Borodin <x4mmm@yandex-team.ru>
Cc: Pg Hackers <pgsql-hackers@postgresql.org>
Subject: Re: Fix logging for invalid recovery timeline
Date: Tue, 25 Feb 2025 11:07:42 +0100
Message-ID: <e5666a9d-8bbe-4aaa-a4c0-87ab13595a29@dalibo.com> (raw)
In-Reply-To: <Z7zzpAv-D1iWVQok@paquier.xyz>
References: <d0b27c08-d30f-4a1d-990d-5c90ca0a650a@pgbackrest.org>
<4ed10bc8-5513-4d8e-8643-8abcaa08336d@dalibo.com>
<2765f538-b06f-4e57-bcb2-9ca1dc6f487d@pgbackrest.org>
<Z7aJU2_ZAplbpTsL@paquier.xyz>
<6273ef0b-033b-4ac7-ab05-71a04e7ac626@pgbackrest.org>
<173a9a4a-bad3-4a42-91e1-637f70e9512f@dalibo.com>
<5336e68a-30d0-473f-a0a0-9e61cd9a5a63@pgbackrest.org>
<Z7vF1hyg5JOFTWst@paquier.xyz>
<f0e04cf5-e7e3-4c16-9c7a-dc7a2aa2c069@dalibo.com>
<26fd4e28-8b75-4e61-a3fd-aed3b7442606@pgbackrest.org>
<Z7zzpAv-D1iWVQok@paquier.xyz>
On 2/24/25 11:33 PM, Michael Paquier wrote:
> On Mon, Feb 24, 2025 at 05:30:35PM +0000, David Steele wrote:
>> + /* translator: %s is a backup_label or
>> pg_control file */
>
> See for example PostmasterMain() with the "/* translator: %s is a
> configuration file */".
Thank you Michael and David.
I never paid attention to thoses...
--
Benoit Lobréau
Consultant
http://dalibo.comAttachments:V3_0001-Adjust-logging-for-invalid-recovery-timeline.patch (text/x-patch, 1.6K) download
From 9a12cad29afb86f2277bf76bc53757702715afd5 Mon Sep 17 00:00:00 2001
From: benoit <benoit.lobreau@dalibo.com>
Date: Fri, 21 Feb 2025 14:09:56 +0100
Subject: [PATCH] Adjust logging for invalid recovery timeline
The original message doesn't mention where the checkpoint was read from.
It refers to the "Latest checkpoint", the terminology is used for some
records from the control file (specifically, the pg_controldata output).
The backup label uses "Checkpoint location".
---
src/backend/access/transam/xlogrecovery.c | 4 +++-
1 file changed, 3 insertions(+), 1 deletion(-)
diff --git a/src/backend/access/transam/xlogrecovery.c b/src/backend/access/transam/xlogrecovery.cindex 915cb330295..65335e542ad 100644--- a/src/backend/access/transam/xlogrecovery.c+++ b/src/backend/access/transam/xlogrecovery.c@@ -849,7 +849,9 @@ InitWalRecovery(ControlFileData *ControlFile, bool *wasShutdown_ptr,
ereport(FATAL,
(errmsg("requested timeline %u is not a child of this server's history",
recoveryTargetTLI),
- errdetail("Latest checkpoint is at %X/%X on timeline %u, but in the history of the requested timeline, the server forked off from that timeline at %X/%X.",+ /* translator: %s is a backup_label or pg_control file */+ errdetail("Latest checkpoint in %s is at %X/%X on timeline %u, but in the history of the requested timeline, the server forked off from that timeline at %X/%X.",+ haveBackupLabel ? "backup_label" : "pg_control",
LSN_FORMAT_ARGS(CheckPointLoc),
CheckPointTLI,
LSN_FORMAT_ARGS(switchpoint))));
--
2.48.1
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Reply to all the recipients using the --to and --cc options:
reply via email
To: pgsql-hackers@postgresql.org
Cc: benoit.lobreau@dalibo.com, michael@paquier.xyz, david@pgbackrest.org, x4mmm@yandex-team.ru
Subject: Re: Fix logging for invalid recovery timeline
In-Reply-To: <e5666a9d-8bbe-4aaa-a4c0-87ab13595a29@dalibo.com>
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox