public inbox for [email protected]
help / color / mirror / Atom feedBug in Database Nodes in the Tree
9+ messages / 3 participants
[nested] [flat]
* Bug in Database Nodes in the Tree
@ 2019-07-17 17:18 Yosry Muhammad <[email protected]>
2019-07-18 05:27 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Yosry Muhammad @ 2019-07-17 17:18 UTC (permalink / raw)
To: Khushboo Vashi <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers
Hi Khushboo,
There's a minor bug that I noticed a while back that when you right click a
disconnected database (to drop it for example) it automatically connects to
the database and expands the node. This behaviour is a little annoying to
users (me too), I am trying to fix it.
I looked around the code in the browser module (node.js, database.js,
menu.js) and I couldn't find a way to modify this behaviour. Is this
handled internally by jQuery? Is modifying this behaviour feasible?
I think the problem is that the right click event triggers the left event
click too. Am I correct?
Thanks!
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Bug in Database Nodes in the Tree
2019-07-17 17:18 Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
@ 2019-07-18 05:27 ` Khushboo Vashi <[email protected]>
2019-07-18 05:40 ` Re: Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Khushboo Vashi @ 2019-07-18 05:27 UTC (permalink / raw)
To: Yosry Muhammad <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers
Hi Yosry,
On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad <[email protected]> wrote:
> Hi Khushboo,
>
> There's a minor bug that I noticed a while back that when you right click
> a disconnected database (to drop it for example) it automatically connects
> to the database and expands the node. This behaviour is a little annoying
> to users (me too), I am trying to fix it.
>
> This behavior is by design as we have considered some of the pgAdmin
III behavior. One behavior we can change is that on the selection of the
database node, we can just connect it and not expand it and when we expand
the database node (by arrow icon or double click), we can connect and
expand both.
We need Dave's approval to change this.
I looked around the code in the browser module (node.js, database.js,
> menu.js) and I couldn't find a way to modify this behaviour. Is this
> handled internally by jQuery? Is modifying this behaviour feasible?
>
>
I think the problem is that the right click event triggers the left event
> click too. Am I correct?
>
> Basically, the browser tree is generated through the aciTree library, so
when required, the public APIs (provided by aciTree) of the events are
being called.
In this case, on the selection of the database node, the selected event is
used in the database.js file.
Thanks,
Khushboo
Thanks!
>
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Bug in Database Nodes in the Tree
2019-07-17 17:18 Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-18 05:27 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
@ 2019-07-18 05:40 ` Yosry Muhammad <[email protected]>
2019-07-18 08:14 ` Re: Bug in Database Nodes in the Tree Dave Page <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Yosry Muhammad @ 2019-07-18 05:40 UTC (permalink / raw)
To: Khushboo Vashi <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers
Hi,
On Thu, Jul 18, 2019, 7:27 AM Khushboo Vashi <
[email protected]> wrote:
> Hi Yosry,
>
> On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad <[email protected]>
> wrote:
>
>> Hi Khushboo,
>>
>> There's a minor bug that I noticed a while back that when you right click
>> a disconnected database (to drop it for example) it automatically connects
>> to the database and expands the node. This behaviour is a little annoying
>> to users (me too), I am trying to fix it.
>>
>> This behavior is by design as we have considered some of the pgAdmin
> III behavior. One behavior we can change is that on the selection of the
> database node, we can just connect it and not expand it and when we expand
> the database node (by arrow icon or double click), we can connect and
> expand both.
>
> We need Dave's approval to change this.
>
I think this makes more sense.
> I looked around the code in the browser module (node.js, database.js,
>> menu.js) and I couldn't find a way to modify this behaviour. Is this
>> handled internally by jQuery? Is modifying this behaviour feasible?
>>
>>
> I think the problem is that the right click event triggers the left event
>> click too. Am I correct?
>>
>> Basically, the browser tree is generated through the aciTree library, so
> when required, the public APIs (provided by aciTree) of the events are
> being called.
> In this case, on the selection of the database node, the selected event is
> used in the database.js file.
>
> Thanks for the clarification.
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Bug in Database Nodes in the Tree
2019-07-17 17:18 Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-18 05:27 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
2019-07-18 05:40 ` Re: Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
@ 2019-07-18 08:14 ` Dave Page <[email protected]>
2019-07-19 05:00 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Dave Page @ 2019-07-18 08:14 UTC (permalink / raw)
To: Yosry Muhammad <[email protected]>; +Cc: Khushboo Vashi <[email protected]>; pgadmin-hackers
Hi
On Thu, Jul 18, 2019 at 6:40 AM Yosry Muhammad <[email protected]> wrote:
> Hi,
>
> On Thu, Jul 18, 2019, 7:27 AM Khushboo Vashi <
> [email protected]> wrote:
>
>> Hi Yosry,
>>
>> On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad <[email protected]>
>> wrote:
>>
>>> Hi Khushboo,
>>>
>>> There's a minor bug that I noticed a while back that when you right
>>> click a disconnected database (to drop it for example) it automatically
>>> connects to the database and expands the node. This behaviour is a little
>>> annoying to users (me too), I am trying to fix it.
>>>
>>> This behavior is by design as we have considered some of the pgAdmin
>> III behavior. One behavior we can change is that on the selection of the
>> database node, we can just connect it and not expand it and when we expand
>> the database node (by arrow icon or double click), we can connect and
>> expand both.
>>
>> We need Dave's approval to change this.
>>
>
> I think this makes more sense.
>
pgAdmin 3 automatically connects databases on select but not servers. I'd
be fine with only connecting databases and servers on expand, and not on
select. That should not affect auto-expand and treeview state restore at
all, but will mean you can right-click a database or server without it
connecting. FYI, I've found this behaviour annoying too.
I can't imagine it would require hacking aciTree to make that happen - we'd
basically just move the connect function call from the onSelect handler (or
whatever it's called) to onExpand wouldn't we?
>
>
>> I looked around the code in the browser module (node.js, database.js,
>>> menu.js) and I couldn't find a way to modify this behaviour. Is this
>>> handled internally by jQuery? Is modifying this behaviour feasible?
>>>
>>>
>> I think the problem is that the right click event triggers the left event
>>> click too. Am I correct?
>>>
>>> Basically, the browser tree is generated through the aciTree library, so
>> when required, the public APIs (provided by aciTree) of the events are
>> being called.
>> In this case, on the selection of the database node, the selected event
>> is used in the database.js file.
>>
>> Thanks for the clarification.
>
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Bug in Database Nodes in the Tree
2019-07-17 17:18 Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-18 05:27 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
2019-07-18 05:40 ` Re: Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-18 08:14 ` Re: Bug in Database Nodes in the Tree Dave Page <[email protected]>
@ 2019-07-19 05:00 ` Khushboo Vashi <[email protected]>
2019-07-22 20:47 ` Re: Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Khushboo Vashi @ 2019-07-19 05:00 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Yosry Muhammad <[email protected]>; pgadmin-hackers
On Thu, Jul 18, 2019 at 1:44 PM Dave Page <[email protected]> wrote:
> Hi
>
> On Thu, Jul 18, 2019 at 6:40 AM Yosry Muhammad <[email protected]> wrote:
>
>> Hi,
>>
>> On Thu, Jul 18, 2019, 7:27 AM Khushboo Vashi <
>> [email protected]> wrote:
>>
>>> Hi Yosry,
>>>
>>> On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad <[email protected]>
>>> wrote:
>>>
>>>> Hi Khushboo,
>>>>
>>>> There's a minor bug that I noticed a while back that when you right
>>>> click a disconnected database (to drop it for example) it automatically
>>>> connects to the database and expands the node. This behaviour is a little
>>>> annoying to users (me too), I am trying to fix it.
>>>>
>>>> This behavior is by design as we have considered some of the pgAdmin
>>> III behavior. One behavior we can change is that on the selection of the
>>> database node, we can just connect it and not expand it and when we expand
>>> the database node (by arrow icon or double click), we can connect and
>>> expand both.
>>>
>>> We need Dave's approval to change this.
>>>
>>
>> I think this makes more sense.
>>
>
> pgAdmin 3 automatically connects databases on select but not servers. I'd
> be fine with only connecting databases and servers on expand, and not on
> select. That should not affect auto-expand and treeview state restore at
> all, but will mean you can right-click a database or server without it
> connecting. FYI, I've found this behaviour annoying too.
>
> This change will definitely affect the auto-expand and tree-view state
restore, but that can be handled by some code changes.
> I can't imagine it would require hacking aciTree to make that happen -
> we'd basically just move the connect function call from the onSelect
> handler (or whatever it's called) to onExpand wouldn't we?
>
Right, as we have implemented both expand and select calls, we just need to
remove the select handler.
>
>
>>
>>
>>> I looked around the code in the browser module (node.js, database.js,
>>>> menu.js) and I couldn't find a way to modify this behaviour. Is this
>>>> handled internally by jQuery? Is modifying this behaviour feasible?
>>>>
>>>>
>>> I think the problem is that the right click event triggers the left
>>>> event click too. Am I correct?
>>>>
>>>> Basically, the browser tree is generated through the aciTree library,
>>> so when required, the public APIs (provided by aciTree) of the events are
>>> being called.
>>> In this case, on the selection of the database node, the selected event
>>> is used in the database.js file.
>>>
>>> Thanks for the clarification.
>>
>
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Bug in Database Nodes in the Tree
2019-07-17 17:18 Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-18 05:27 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
2019-07-18 05:40 ` Re: Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-18 08:14 ` Re: Bug in Database Nodes in the Tree Dave Page <[email protected]>
2019-07-19 05:00 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
@ 2019-07-22 20:47 ` Yosry Muhammad <[email protected]>
2019-07-23 03:15 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Yosry Muhammad @ 2019-07-22 20:47 UTC (permalink / raw)
To: Khushboo Vashi <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers
Hi,
I tried just removing the lines responsible for connecting to the database
on selecting a database node and it seem to work fine. Specifically the
lines 254-257 in database.js (callbacks.selected function).
Are there any specific scenarios I need to test to make sure everything is
okay? Anywhere else in the code where I need to make changes?
I also checked the tree state restore and it seems to work fine.
Thanks.
On Fri, Jul 19, 2019 at 7:01 AM Khushboo Vashi <
[email protected]> wrote:
>
>
> On Thu, Jul 18, 2019 at 1:44 PM Dave Page <[email protected]> wrote:
>
>> Hi
>>
>> On Thu, Jul 18, 2019 at 6:40 AM Yosry Muhammad <[email protected]>
>> wrote:
>>
>>> Hi,
>>>
>>> On Thu, Jul 18, 2019, 7:27 AM Khushboo Vashi <
>>> [email protected]> wrote:
>>>
>>>> Hi Yosry,
>>>>
>>>> On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad <[email protected]>
>>>> wrote:
>>>>
>>>>> Hi Khushboo,
>>>>>
>>>>> There's a minor bug that I noticed a while back that when you right
>>>>> click a disconnected database (to drop it for example) it automatically
>>>>> connects to the database and expands the node. This behaviour is a little
>>>>> annoying to users (me too), I am trying to fix it.
>>>>>
>>>>> This behavior is by design as we have considered some of the pgAdmin
>>>> III behavior. One behavior we can change is that on the selection of the
>>>> database node, we can just connect it and not expand it and when we expand
>>>> the database node (by arrow icon or double click), we can connect and
>>>> expand both.
>>>>
>>>> We need Dave's approval to change this.
>>>>
>>>
>>> I think this makes more sense.
>>>
>>
>> pgAdmin 3 automatically connects databases on select but not servers. I'd
>> be fine with only connecting databases and servers on expand, and not on
>> select. That should not affect auto-expand and treeview state restore at
>> all, but will mean you can right-click a database or server without it
>> connecting. FYI, I've found this behaviour annoying too.
>>
>> This change will definitely affect the auto-expand and tree-view state
> restore, but that can be handled by some code changes.
>
>> I can't imagine it would require hacking aciTree to make that happen -
>> we'd basically just move the connect function call from the onSelect
>> handler (or whatever it's called) to onExpand wouldn't we?
>>
> Right, as we have implemented both expand and select calls, we just need
> to remove the select handler.
>
>>
>>
>>>
>>>
>>>> I looked around the code in the browser module (node.js, database.js,
>>>>> menu.js) and I couldn't find a way to modify this behaviour. Is this
>>>>> handled internally by jQuery? Is modifying this behaviour feasible?
>>>>>
>>>>>
>>>> I think the problem is that the right click event triggers the left
>>>>> event click too. Am I correct?
>>>>>
>>>>> Basically, the browser tree is generated through the aciTree library,
>>>> so when required, the public APIs (provided by aciTree) of the events are
>>>> being called.
>>>> In this case, on the selection of the database node, the selected event
>>>> is used in the database.js file.
>>>>
>>>> Thanks for the clarification.
>>>
>>
>>
>> --
>> Dave Page
>> Blog: http://pgsnake.blogspot.com
>> Twitter: @pgsnake
>>
>> EnterpriseDB UK: http://www.enterprisedb.com
>> The Enterprise PostgreSQL Company
>>
>
--
*Yosry Muhammad Yosry*
Computer Engineering student,
The Faculty of Engineering,
Cairo University (2021).
Class representative of CMP 2021.
https://www.linkedin.com/in/yosrym93/
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Bug in Database Nodes in the Tree
2019-07-17 17:18 Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-18 05:27 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
2019-07-18 05:40 ` Re: Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-18 08:14 ` Re: Bug in Database Nodes in the Tree Dave Page <[email protected]>
2019-07-19 05:00 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
2019-07-22 20:47 ` Re: Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
@ 2019-07-23 03:15 ` Khushboo Vashi <[email protected]>
2019-07-23 08:01 ` Re: Bug in Database Nodes in the Tree Dave Page <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Khushboo Vashi @ 2019-07-23 03:15 UTC (permalink / raw)
To: Yosry Muhammad <[email protected]>; +Cc: Dave Page <[email protected]>; pgadmin-hackers
On Tue, Jul 23, 2019 at 2:17 AM Yosry Muhammad <[email protected]> wrote:
> Hi,
>
> I tried just removing the lines responsible for connecting to the database
> on selecting a database node and it seem to work fine. Specifically the
> lines 254-257 in database.js (callbacks.selected function).
>
> Are there any specific scenarios I need to test to make sure everything is
> okay? Anywhere else in the code where I need to make changes?
>
> I think all the right side panels (i.e. Properties, SQL, etc...) will be
affected.
> I also checked the tree state restore and it seems to work fine.
>
> Thanks.
>
>
> On Fri, Jul 19, 2019 at 7:01 AM Khushboo Vashi <
> [email protected]> wrote:
>
>>
>>
>> On Thu, Jul 18, 2019 at 1:44 PM Dave Page <[email protected]> wrote:
>>
>>> Hi
>>>
>>> On Thu, Jul 18, 2019 at 6:40 AM Yosry Muhammad <[email protected]>
>>> wrote:
>>>
>>>> Hi,
>>>>
>>>> On Thu, Jul 18, 2019, 7:27 AM Khushboo Vashi <
>>>> [email protected]> wrote:
>>>>
>>>>> Hi Yosry,
>>>>>
>>>>> On Wed, Jul 17, 2019 at 10:49 PM Yosry Muhammad <[email protected]>
>>>>> wrote:
>>>>>
>>>>>> Hi Khushboo,
>>>>>>
>>>>>> There's a minor bug that I noticed a while back that when you right
>>>>>> click a disconnected database (to drop it for example) it automatically
>>>>>> connects to the database and expands the node. This behaviour is a little
>>>>>> annoying to users (me too), I am trying to fix it.
>>>>>>
>>>>>> This behavior is by design as we have considered some of the pgAdmin
>>>>> III behavior. One behavior we can change is that on the selection of the
>>>>> database node, we can just connect it and not expand it and when we expand
>>>>> the database node (by arrow icon or double click), we can connect and
>>>>> expand both.
>>>>>
>>>>> We need Dave's approval to change this.
>>>>>
>>>>
>>>> I think this makes more sense.
>>>>
>>>
>>> pgAdmin 3 automatically connects databases on select but not servers.
>>> I'd be fine with only connecting databases and servers on expand, and not
>>> on select. That should not affect auto-expand and treeview state restore at
>>> all, but will mean you can right-click a database or server without it
>>> connecting. FYI, I've found this behaviour annoying too.
>>>
>>> This change will definitely affect the auto-expand and tree-view state
>> restore, but that can be handled by some code changes.
>>
>>> I can't imagine it would require hacking aciTree to make that happen -
>>> we'd basically just move the connect function call from the onSelect
>>> handler (or whatever it's called) to onExpand wouldn't we?
>>>
>> Right, as we have implemented both expand and select calls, we just need
>> to remove the select handler.
>>
>>>
>>>
>>>>
>>>>
>>>>> I looked around the code in the browser module (node.js, database.js,
>>>>>> menu.js) and I couldn't find a way to modify this behaviour. Is this
>>>>>> handled internally by jQuery? Is modifying this behaviour feasible?
>>>>>>
>>>>>>
>>>>> I think the problem is that the right click event triggers the left
>>>>>> event click too. Am I correct?
>>>>>>
>>>>>> Basically, the browser tree is generated through the aciTree library,
>>>>> so when required, the public APIs (provided by aciTree) of the events are
>>>>> being called.
>>>>> In this case, on the selection of the database node, the selected
>>>>> event is used in the database.js file.
>>>>>
>>>>> Thanks for the clarification.
>>>>
>>>
>>>
>>> --
>>> Dave Page
>>> Blog: http://pgsnake.blogspot.com
>>> Twitter: @pgsnake
>>>
>>> EnterpriseDB UK: http://www.enterprisedb.com
>>> The Enterprise PostgreSQL Company
>>>
>>
>
> --
> *Yosry Muhammad Yosry*
>
> Computer Engineering student,
> The Faculty of Engineering,
> Cairo University (2021).
> Class representative of CMP 2021.
> https://www.linkedin.com/in/yosrym93/
>
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Bug in Database Nodes in the Tree
2019-07-17 17:18 Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-18 05:27 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
2019-07-18 05:40 ` Re: Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-18 08:14 ` Re: Bug in Database Nodes in the Tree Dave Page <[email protected]>
2019-07-19 05:00 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
2019-07-22 20:47 ` Re: Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-23 03:15 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
@ 2019-07-23 08:01 ` Dave Page <[email protected]>
2019-07-23 08:56 ` Re: Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
0 siblings, 1 reply; 9+ messages in thread
From: Dave Page @ 2019-07-23 08:01 UTC (permalink / raw)
To: Khushboo Vashi <[email protected]>; +Cc: Yosry Muhammad <[email protected]>; pgadmin-hackers
On Tue, Jul 23, 2019 at 4:15 AM Khushboo Vashi <
[email protected]> wrote:
>
>
> On Tue, Jul 23, 2019 at 2:17 AM Yosry Muhammad <[email protected]> wrote:
>
>> Hi,
>>
>> I tried just removing the lines responsible for connecting to the
>> database on selecting a database node and it seem to work fine.
>> Specifically the lines 254-257 in database.js (callbacks.selected function).
>>
>> Are there any specific scenarios I need to test to make sure everything
>> is okay? Anywhere else in the code where I need to make changes?
>>
>> I think all the right side panels (i.e. Properties, SQL, etc...) will be
> affected.
>
They're populated on select. It may mean that we have to show a "Please
connect to the server" message in them, if a database or server is selected
but not connected.
--
Dave Page
Blog: http://pgsnake.blogspot.com
Twitter: @pgsnake
EnterpriseDB UK: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
^ permalink raw reply [nested|flat] 9+ messages in thread
* Re: Bug in Database Nodes in the Tree
2019-07-17 17:18 Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-18 05:27 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
2019-07-18 05:40 ` Re: Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-18 08:14 ` Re: Bug in Database Nodes in the Tree Dave Page <[email protected]>
2019-07-19 05:00 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
2019-07-22 20:47 ` Re: Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-23 03:15 ` Re: Bug in Database Nodes in the Tree Khushboo Vashi <[email protected]>
2019-07-23 08:01 ` Re: Bug in Database Nodes in the Tree Dave Page <[email protected]>
@ 2019-07-23 08:56 ` Yosry Muhammad <[email protected]>
0 siblings, 0 replies; 9+ messages in thread
From: Yosry Muhammad @ 2019-07-23 08:56 UTC (permalink / raw)
To: Dave Page <[email protected]>; +Cc: Khushboo Vashi <[email protected]>; pgadmin-hackers
Thanks for making things clear.
On Tue, Jul 23, 2019, 10:01 AM Dave Page <[email protected]> wrote:
>
>
> On Tue, Jul 23, 2019 at 4:15 AM Khushboo Vashi <
> [email protected]> wrote:
>
>>
>>
>> On Tue, Jul 23, 2019 at 2:17 AM Yosry Muhammad <[email protected]>
>> wrote:
>>
>>> Hi,
>>>
>>> I tried just removing the lines responsible for connecting to the
>>> database on selecting a database node and it seem to work fine.
>>> Specifically the lines 254-257 in database.js (callbacks.selected function).
>>>
>>> Are there any specific scenarios I need to test to make sure everything
>>> is okay? Anywhere else in the code where I need to make changes?
>>>
>>> I think all the right side panels (i.e. Properties, SQL, etc...) will be
>> affected.
>>
>
> They're populated on select. It may mean that we have to show a "Please
> connect to the server" message in them, if a database or server is selected
> but not connected.
>
> --
> Dave Page
> Blog: http://pgsnake.blogspot.com
> Twitter: @pgsnake
>
> EnterpriseDB UK: http://www.enterprisedb.com
> The Enterprise PostgreSQL Company
>
^ permalink raw reply [nested|flat] 9+ messages in thread
end of thread, other threads:[~2019-07-23 08:56 UTC | newest]
Thread overview: 9+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2019-07-17 17:18 Bug in Database Nodes in the Tree Yosry Muhammad <[email protected]>
2019-07-18 05:27 ` Khushboo Vashi <[email protected]>
2019-07-18 05:40 ` Yosry Muhammad <[email protected]>
2019-07-18 08:14 ` Dave Page <[email protected]>
2019-07-19 05:00 ` Khushboo Vashi <[email protected]>
2019-07-22 20:47 ` Yosry Muhammad <[email protected]>
2019-07-23 03:15 ` Khushboo Vashi <[email protected]>
2019-07-23 08:01 ` Dave Page <[email protected]>
2019-07-23 08:56 ` Yosry Muhammad <[email protected]>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox