pg.ddx.io pgsql-bugs@postgresql.org mailing list archive
help / color / mirror / Atom feedBUG #19450: Where is checksum_block.inc.c after master install?
6+ messages / 3 participants
[nested] [flat]
* BUG #19450: Where is checksum_block.inc.c after master install?
@ 2026-04-05 11:39 PG Bug reporting form <noreply@postgresql.org>
0 siblings, 1 reply; 6+ messages in thread
From: PG Bug reporting form @ 2026-04-05 11:39 UTC (permalink / raw)
To: pgsql-bugs@lists.postgresql.org; +Cc: rekgrpth@gmail.com
The following bug has been logged on the website:
Bug reference: 19450
Logged by: RekGRpth
Email address: rekgrpth@gmail.com
PostgreSQL version: 18.3
Operating system: docker alpine
Description:
There is no checksum_block.inc.c after master install
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: BUG #19450: Where is checksum_block.inc.c after master install?
@ 2026-04-06 02:43 John Naylor <johncnaylorls@gmail.com>
parent: PG Bug reporting form <noreply@postgresql.org>
0 siblings, 1 reply; 6+ messages in thread
From: John Naylor @ 2026-04-06 02:43 UTC (permalink / raw)
To: rekgrpth@gmail.com; pgsql-bugs@lists.postgresql.org
On Sun, Apr 5, 2026 at 8:40 PM PG Bug reporting form
<noreply@postgresql.org> wrote:
>
> The following bug has been logged on the website:
>
> Bug reference: 19450
> Logged by: RekGRpth
> Email address: rekgrpth@gmail.com
> PostgreSQL version: 18.3
> Operating system: docker alpine
> Description:
>
> There is no checksum_block.inc.c after master install
I'll look into that. What broke, so I can reproduce?
BTW, the bug reporting form is meant for released versions, and this
does not affect 18.3.
--
John Naylor
Amazon Web Services
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: BUG #19450: Where is checksum_block.inc.c after master install?
@ 2026-04-06 02:50 Tom Lane <tgl@sss.pgh.pa.us>
parent: John Naylor <johncnaylorls@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Tom Lane @ 2026-04-06 02:50 UTC (permalink / raw)
To: John Naylor <johncnaylorls@gmail.com>; +Cc: rekgrpth@gmail.com; pgsql-bugs@lists.postgresql.org
John Naylor <johncnaylorls@gmail.com> writes:
>> There is no checksum_block.inc.c after master install
> I'll look into that. What broke, so I can reproduce?
src/include/Makefile knows what it's supposed to install out
of that subtree, and it thinks storage/*.h is sufficient.
I didn't check to see if the meson system has the same oversight.
One could argue that the real bug is having put a .c file into
the include/ tree in the first place. Why was it done like that?
Couldn't it be a .h file?
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: BUG #19450: Where is checksum_block.inc.c after master install?
@ 2026-04-06 02:57 John Naylor <johncnaylorls@gmail.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 6+ messages in thread
From: John Naylor @ 2026-04-06 02:57 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: rekgrpth@gmail.com; pgsql-bugs@lists.postgresql.org
On Mon, Apr 6, 2026 at 9:50 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> src/include/Makefile knows what it's supposed to install out
> of that subtree, and it thinks storage/*.h is sufficient.
> I didn't check to see if the meson system has the same oversight.
>
> One could argue that the real bug is having put a .c file into
> the include/ tree in the first place. Why was it done like that?
> Couldn't it be a .h file?
That was the way it was first coded. I thought of this way to avoid
adding an exception to headerscheck. I can reverse that decision
easily, but I may not get to it today.
--
John Naylor
Amazon Web Services
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: BUG #19450: Where is checksum_block.inc.c after master install?
@ 2026-04-06 03:07 Tom Lane <tgl@sss.pgh.pa.us>
parent: John Naylor <johncnaylorls@gmail.com>
0 siblings, 1 reply; 6+ messages in thread
From: Tom Lane @ 2026-04-06 03:07 UTC (permalink / raw)
To: John Naylor <johncnaylorls@gmail.com>; +Cc: rekgrpth@gmail.com; pgsql-bugs@lists.postgresql.org
John Naylor <johncnaylorls@gmail.com> writes:
> On Mon, Apr 6, 2026 at 9:50 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> One could argue that the real bug is having put a .c file into
>> the include/ tree in the first place. Why was it done like that?
>> Couldn't it be a .h file?
> That was the way it was first coded. I thought of this way to avoid
> adding an exception to headerscheck. I can reverse that decision
> easily, but I may not get to it today.
Ah, the good ol' law of conservation of cruft. But on the whole
I think naming it .h not .c is less crufty. Agreed that there's
no great urgency about changing it.
regards, tom lane
^ permalink raw reply [nested|flat] 6+ messages in thread
* Re: BUG #19450: Where is checksum_block.inc.c after master install?
@ 2026-04-07 08:56 John Naylor <johncnaylorls@gmail.com>
parent: Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 6+ messages in thread
From: John Naylor @ 2026-04-07 08:56 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: rekgrpth@gmail.com; pgsql-bugs@lists.postgresql.org
On Mon, Apr 6, 2026 at 10:07 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> John Naylor <johncnaylorls@gmail.com> writes:
> > On Mon, Apr 6, 2026 at 9:50 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> One could argue that the real bug is having put a .c file into
> >> the include/ tree in the first place. Why was it done like that?
> >> Couldn't it be a .h file?
>
> > That was the way it was first coded. I thought of this way to avoid
> > adding an exception to headerscheck. I can reverse that decision
> > easily, but I may not get to it today.
>
> Ah, the good ol' law of conservation of cruft. But on the whole
> I think naming it .h not .c is less crufty. Agreed that there's
> no great urgency about changing it.
Okay, done that way as of commit 8c3e22a8f.
--
John Naylor
Amazon Web Services
^ permalink raw reply [nested|flat] 6+ messages in thread
end of thread, other threads:[~2026-04-07 08:56 UTC | newest]
Thread overview: 6+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2026-04-05 11:39 BUG #19450: Where is checksum_block.inc.c after master install? PG Bug reporting form <noreply@postgresql.org>
2026-04-06 02:43 ` John Naylor <johncnaylorls@gmail.com>
2026-04-06 02:50 ` Tom Lane <tgl@sss.pgh.pa.us>
2026-04-06 02:57 ` John Naylor <johncnaylorls@gmail.com>
2026-04-06 03:07 ` Tom Lane <tgl@sss.pgh.pa.us>
2026-04-07 08:56 ` John Naylor <johncnaylorls@gmail.com>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox