pg.ddx.io  pgsql-bugs@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Michael Paquier <michael@paquier.xyz>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andres Freund <andres@anarazel.de>
Cc: Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
Cc: Yuli Khodorkovskiy <yuli.khodorkovskiy@crunchydata.com>
Cc: pgsql-bugs@lists.postgresql.org
Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
Date: Sun, 19 May 2019 09:43:45 +0900
Message-ID: <20190519004344.GA3653@paquier.xyz> (raw)
In-Reply-To: <28565.1558196308@sss.pgh.pa.us>
References: <20190516021903.GB1415@paquier.xyz>
	<28927.1557977558@sss.pgh.pa.us>
	<20190516035617.GC1415@paquier.xyz>
	<20190516043618.GD1415@paquier.xyz>
	<31437.1557982294@sss.pgh.pa.us>
	<20190516060628.GE1415@paquier.xyz>
	<20190517042536.GM20887@paquier.xyz>
	<20190517202443.gw4zdfkpwgsjdel6@alap3.anarazel.de>
	<20190518093522.GA19212@paquier.xyz>
	<28565.1558196308@sss.pgh.pa.us>

On Sat, May 18, 2019 at 12:18:28PM -0400, Tom Lane wrote:
> At this point I agree with Michael that reverting 57431a911 is the most
> prudent thing to do for beta1.  While it's probably not *that* hard to
> fix, it will require Windows-specific testing.  Moreover, the fact that
> there are race conditions involved means that one person's testing might
> not catch everything.  So I do not think we have enough time to get a
> trustworthy fix in place by Monday.  And we do have other things to
> worry about.

Thanks for confirming.  There is little time for doing the revert, and
it would have been nice seeing comments from Peter.  Anyway, I should
be able to do that myself in 24 hours or so after coming back in
front of my desk so as the buildfarm can have a couple of cycles for
its work.  If you prefer doing that yourself, that's of course fine by
me.

> I wouldn't be totally opposed to un-reverting after beta1, if a
> better-tested patch emerges.  But we don't have such a patch today
> and I don't see how we'll get there this weekend.

Possible.  My recommendation is to keep this as potential v13 work and
focus on v12 stability.  I have no doubt that after beta1 emerges we
will get enough reports to work on.
--
Michael

Attachments:

  [application/pgp-signature] signature.asc (832B, ../20190519004344.GA3653@paquier.xyz/2-signature.asc)
  download

view thread (40+ messages)  latest in thread

Message-ID: <20190519004344.GA3653@paquier.xyz>
Permalink:  ../20190519004344.GA3653@paquier.xyz/
Also on:    postgresql.org/message-id/20190519004344.GA3653@paquier.xyz

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-bugs@postgresql.org
  Cc: michael@paquier.xyz, tgl@sss.pgh.pa.us, andres@anarazel.de, peter.eisentraut@2ndquadrant.com, yuli.khodorkovskiy@crunchydata.com, pgsql-bugs@lists.postgresql.org
  Subject: Re: BUG #15804: Assertion failure when using logging_collector with EXEC_BACKEND
  In-Reply-To: <20190519004344.GA3653@paquier.xyz>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox