pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Explicitly bind gettext to the correct encoding on Windows.
5+ messages / 4 participants
[nested] [flat]
* pgsql: Explicitly bind gettext to the correct encoding on Windows.
@ 2009-01-22 10:09 Magnus Hagander <mha@postgresql.org>
0 siblings, 1 reply; 5+ messages in thread
From: mha@postgresql.org @ 2009-01-22 10:09 UTC (permalink / raw)
To: pgsql-committers
Log Message:
-----------
Explicitly bind gettext to the correct encoding on Windows.
Original patch from Hiroshi Inoue.
Modified Files:
--------------
pgsql/src/backend/utils/mb:
mbutils.c (r1.77 -> r1.78)
(http://anoncvs.postgresql.org/cvsweb.cgi/pgsql/src/backend/utils/mb/mbutils.c?r1=1.77&r2=1.78)
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
@ 2009-01-22 23:27 Tom Lane <tgl@sss.pgh.pa.us>
parent: Magnus Hagander <mha@postgresql.org>
0 siblings, 2 replies; 5+ messages in thread
From: Tom Lane @ 2009-01-22 23:27 UTC (permalink / raw)
To: Magnus Hagander <magnus@hagander.net>; +Cc: pgsql-hackers@postgreSQL.org
mha@postgresql.org (Magnus Hagander) writes:
> Explicitly bind gettext to the correct encoding on Windows.
I have a couple of objections to this patch. First, what happens if
it fails to find a matching table entry? (The existing answer is
"nothing", but that doesn't seem right.) Second and more critical,
it adds still another data structure that has to be maintained when
the list of encodings changes, and it doesn't even live in the same
file as any existing encoding-information table.
What makes more sense to me is to add a table to encnames.c that
provides the gettext name of every encoding that we support.
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
@ 2009-02-07 15:11 Bruce Momjian <bruce@momjian.us>
parent: Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 0 replies; 5+ messages in thread
From: Bruce Momjian @ 2009-02-07 15:11 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Magnus Hagander <magnus@hagander.net>; pgsql-hackers@postgresql.org
Tom Lane wrote:
> mha@postgresql.org (Magnus Hagander) writes:
> > Explicitly bind gettext to the correct encoding on Windows.
>
> I have a couple of objections to this patch. First, what happens if
> it fails to find a matching table entry? (The existing answer is
> "nothing", but that doesn't seem right.) Second and more critical,
> it adds still another data structure that has to be maintained when
> the list of encodings changes, and it doesn't even live in the same
> file as any existing encoding-information table.
>
> What makes more sense to me is to add a table to encnames.c that
> provides the gettext name of every encoding that we support.
Would someone please comment on Tom's questions above.
--
Bruce Momjian <bruce@momjian.us> http://momjian.us
EnterpriseDB http://enterprisedb.com
+ If your life is a hard drive, Christ can be your backup. +
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
@ 2009-02-15 14:08 Magnus Hagander <magnus@hagander.net>
parent: Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 1 reply; 5+ messages in thread
From: Magnus Hagander @ 2009-02-15 14:08 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-hackers@postgreSQL.org
Tom Lane wrote:
> mha@postgresql.org (Magnus Hagander) writes:
>> Explicitly bind gettext to the correct encoding on Windows.
>
> I have a couple of objections to this patch. First, what happens if
> it fails to find a matching table entry? (The existing answer is
> "nothing", but that doesn't seem right.) Second and more critical,
> it adds still another data structure that has to be maintained when
> the list of encodings changes, and it doesn't even live in the same
> file as any existing encoding-information table.
>
> What makes more sense to me is to add a table to encnames.c that
> provides the gettext name of every encoding that we support.
Do you mean a separate table there, or should we add a new column to one
of the existing tables?
//Magnus
^ permalink raw reply [nested|flat] 5+ messages in thread
* Re: [COMMITTERS] pgsql: Explicitly bind gettext to the correct encoding on Windows.
@ 2009-02-15 17:21 Tom Lane <tgl@sss.pgh.pa.us>
parent: Magnus Hagander <magnus@hagander.net>
0 siblings, 0 replies; 5+ messages in thread
From: Tom Lane @ 2009-02-15 17:21 UTC (permalink / raw)
To: Magnus Hagander <magnus@hagander.net>; +Cc: pgsql-hackers@postgreSQL.org
Magnus Hagander <magnus@hagander.net> writes:
> Tom Lane wrote:
>> What makes more sense to me is to add a table to encnames.c that
>> provides the gettext name of every encoding that we support.
> Do you mean a separate table there, or should we add a new column to one
> of the existing tables?
Whichever seems to make more sense is fine with me. I just don't want
add-an-encoding maintenance requirements spread across N different
source files.
regards, tom lane
^ permalink raw reply [nested|flat] 5+ messages in thread
end of thread, other threads:[~2009-02-15 17:21 UTC | newest]
Thread overview: 5+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2009-01-22 10:09 pgsql: Explicitly bind gettext to the correct encoding on Windows. Magnus Hagander <mha@postgresql.org>
2009-01-22 23:27 ` Tom Lane <tgl@sss.pgh.pa.us>
2009-02-07 15:11 ` Bruce Momjian <bruce@momjian.us>
2009-02-15 14:08 ` Magnus Hagander <magnus@hagander.net>
2009-02-15 17:21 ` Tom Lane <tgl@sss.pgh.pa.us>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox