pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Noah Misch <noah@leadboat.com>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Postgres hackers <pgsql-hackers@lists.postgresql.org>
Cc: Craig Ringer <craig.ringer@enterprisedb.com>
Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
Date: Sat, 9 Oct 2021 12:23:33 -0700
Message-ID: <20211009192333.GA450252@rfd.leadboat.com> (raw)
In-Reply-To: <234637.1633709021@sss.pgh.pa.us>
References: <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se>
	<161525.1633632402@sss.pgh.pa.us>
	<162421.1633633360@sss.pgh.pa.us>
	<12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se>
	<173186.1633635888@sss.pgh.pa.us>
	<20211008025659.GA398563@rfd.leadboat.com>
	<197091.1633664351@sss.pgh.pa.us>
	<20211008042454.GB398563@rfd.leadboat.com>
	<03177128-BE87-4520-90D1-D5FA16B79EB6@yesql.se>
	<234637.1633709021@sss.pgh.pa.us>

On Fri, Oct 08, 2021 at 12:03:41PM -0400, Tom Lane wrote:
> Daniel Gustafsson <daniel@yesql.se> writes:
> > On 8 Oct 2021, at 06:24, Noah Misch <noah@leadboat.com> wrote:
> >> That's obvious from "cpanm install IPC::Run".  Surely if any other non-core
> >> module were allowed, the recipe would list it in a similar way.
> 
> > The proposed changes talks about with core modules are allowed to use, I think
> > that's a different thing.  The distinction between core and non-core modules
> > may not be known/clear to people who haven't used Perl in the past.
> 
> Yeah, I don't really think that this recipe makes it plain that we have
> a policy.  It certainly fails to explain that you're allowed to use
> additional modules if you're willing to skip the relevant tests.

True, +1 for mentioning that tests can use less-available modules if they skip
when those modules are absent.  I'm only -0 for adding the other English
(unlike the -1 for the original proposal of removing the shell commands).

> >> If there's something to change, it's improving the actual recipe:
> 
> > That we should do as well.
> 
> You're not going to get far with "improving the recipe", because it's
> just not possible.  To check this, I installed perlbrew on a Fedora 34

Your test result is evidence that "cpanm install Test::More@0.87" is the wrong
shell command, but it's quite a leap to "just not possible".  Surely there
exist other shell commands that install
http://backpan.perl.org/modules/by-authors/id/M/MS/MSCHWERN/Test-Simple-0.87_03.tar.gz.
(Perhaps none of us will care enough to identify them, but they exist.)

By the way, I suspect 93fb39e introduced a regression in the recipe.  (I
haven't tested, though.)  Before commit 93fb39e, "cpanm install IPC::Run"
would update Test::More.  As of 5.8.3, the core version of Test::More is new
enough for IPC::Run but not new enough for PostgreSQL.  I recommend adding
"cpanm install Test::More" to restore the pre-93fb39e functionality.





view thread (33+ messages)  latest in thread

Message-ID: <20211009192333.GA450252@rfd.leadboat.com>
Permalink:  ../20211009192333.GA450252@rfd.leadboat.com/
Also on:    postgresql.org/message-id/20211009192333.GA450252@rfd.leadboat.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: noah@leadboat.com, tgl@sss.pgh.pa.us, daniel@yesql.se, pgsql-hackers@lists.postgresql.org, craig.ringer@enterprisedb.com
  Subject: Re: pgsql: Adjust configure to insist on Perl version >= 5.8.3.
  In-Reply-To: <20211009192333.GA450252@rfd.leadboat.com>
  References: <150C7533-8A64-4829-ABEA-50F0D49FC598@yesql.se> <161525.1633632402@sss.pgh.pa.us> <162421.1633633360@sss.pgh.pa.us> <12C3DA75-ACE1-486B-A432-9E23C68E7D34@yesql.se> <173186.1633635888@sss.pgh.pa.us> <20211008025659.GA398563@rfd.leadboat.com> <197091.1633664351@sss.pgh.pa.us> <20211008042454.GB398563@rfd.leadboat.com> <03177128-BE87-4520-90D1-D5FA16B79EB6@yesql.se> <234637.1633709021@sss.pgh.pa.us> <20211009192333.GA450252@rfd.leadboat.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox