pg.ddx.io pgsql-committers@postgresql.org mailing list archivehelp / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Robert Haas <robertmhaas@gmail.com>
Cc: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: Wed, 30 Mar 2022 12:12:51 -0700
Message-ID: <20220330191251.sgxjox64k3eteylb@alap3.anarazel.de> (raw)
In-Reply-To: <CA+TgmoY7smOGpvcNJwzsK5Y4TyA-Wk=8dnRGjaDRqUOoGfUSTA@mail.gmail.com>
References: <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de>
<CA+TgmoY-x99HMUcV0a+SBWrzcdREHkE69+Xw620BVBjGqvrc4g@mail.gmail.com>
<144620.1648326272@sss.pgh.pa.us>
<20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de>
<20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de>
<228044.1648658074@sss.pgh.pa.us>
<20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de>
<230838.1648659506@sss.pgh.pa.us>
<A544F34E-7CEC-4CBD-A692-7D1DC9FC79EE@anarazel.de>
<CA+TgmoY7smOGpvcNJwzsK5Y4TyA-Wk=8dnRGjaDRqUOoGfUSTA@mail.gmail.com>
Hi,
On 2022-03-30 13:16:47 -0400, Robert Haas wrote:
> On Wed, Mar 30, 2022 at 1:11 PM Andres Freund <andres@anarazel.de> wrote:
> > On March 30, 2022 9:58:26 AM PDT, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> > >Andres Freund <andres@anarazel.de> writes:
> > >> Random aside: Am I the only one bothered by a bunch of places in
> > >> Makefile.global.in quoting like
> > >> $(MAKE) -C '$(top_builddir)' DESTDIR='$(abs_top_builddir)'/tmp_install install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1
> > >> and
> > >> rm -rf '$(CURDIR)'/tmp_check &&
> > >> etc
> > >
> > >Don't we need that to handle, say, build paths with spaces in them?
> >
> > My concern is about the quote in the middle of the path, not about quoting at all... I.e. the ' should be after /tmp_install, not before.
>
> Makes no difference. We know that the string /tmp_install contains no
> shell metacharacters, so why does it need to be in quotes? I would've
> probably written it the way it is here, rather than what you are
> proposing.
It looks ugly, and it can't be copy-pasted as easily. Seems I'm alone on this,
so I'll leave it be...
Greetings,
Andres Freund
view thread (66+ messages) latest in thread
Message-ID: <20220330191251.sgxjox64k3eteylb@alap3.anarazel.de> Permalink: ../20220330191251.sgxjox64k3eteylb@alap3.anarazel.de/ Also on: postgresql.org/message-id/20220330191251.sgxjox64k3eteylb@alap3.anarazel.de ·
reply
Reply instructions: You may reply publicly to this message via plain-text email using any one of the following methods: * Reply to all the recipients from your mail client; the link fills in the headers below: reply via email Some clients, webmail especially, drop In-Reply-To and References from a link, and the reply then starts a new thread: use the mbox below. To: pgsql-committers@postgresql.org Cc: andres@anarazel.de, robertmhaas@gmail.com, tgl@sss.pgh.pa.us, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org, magnus@hagander.net Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module. In-Reply-To: <20220330191251.sgxjox64k3eteylb@alap3.anarazel.de> References: <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> <CA+TgmoY-x99HMUcV0a+SBWrzcdREHkE69+Xw620BVBjGqvrc4g@mail.gmail.com> <144620.1648326272@sss.pgh.pa.us> <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de> <228044.1648658074@sss.pgh.pa.us> <20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de> <230838.1648659506@sss.pgh.pa.us> <A544F34E-7CEC-4CBD-A692-7D1DC9FC79EE@anarazel.de> <CA+TgmoY7smOGpvcNJwzsK5Y4TyA-Wk=8dnRGjaDRqUOoGfUSTA@mail.gmail.com> <20220330191251.sgxjox64k3eteylb@alap3.anarazel.de> * Save the following mbox file, import it into your mail client, and reply-to-all from there: mbox
This inbox is served by DDX for PostgreSQL; see mirroring instructions for how to clone and mirror all data and code used for this inbox