pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Andres Freund <andres@anarazel.de>
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Robert Haas <robertmhaas@gmail.com>
Cc: Andrew Dunstan <andrew@dunslane.net>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Cc: Magnus Hagander <magnus@hagander.net>
Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
Date: Wed, 30 Mar 2022 10:11:49 -0700
Message-ID: <A544F34E-7CEC-4CBD-A692-7D1DC9FC79EE@anarazel.de> (raw)
In-Reply-To: <230838.1648659506@sss.pgh.pa.us>
References: <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de>
	<CA+TgmoZ6DdRe0=YYv-dXfKCpfwaoKdUXP6gXg7qVB=3FwON1GA@mail.gmail.com>
	<7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net>
	<CA+TgmoYwwTgNPJz34p6MJPAv8OYH77+-sMbae13Ygv8ENfGXdA@mail.gmail.com>
	<20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de>
	<CA+TgmoY-x99HMUcV0a+SBWrzcdREHkE69+Xw620BVBjGqvrc4g@mail.gmail.com>
	<144620.1648326272@sss.pgh.pa.us>
	<20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de>
	<20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de>
	<228044.1648658074@sss.pgh.pa.us>
	<20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de>
	<230838.1648659506@sss.pgh.pa.us>

Hi, 

On March 30, 2022 9:58:26 AM PDT, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Andres Freund <andres@anarazel.de> writes:
>> Random aside: Am I the only one bothered by a bunch of places in
>> Makefile.global.in quoting like
>>   $(MAKE) -C '$(top_builddir)' DESTDIR='$(abs_top_builddir)'/tmp_install install >'$(abs_top_builddir)'/tmp_install/log/install.log 2>&1
>> and
>>   rm -rf '$(CURDIR)'/tmp_check &&
>> etc
>
>Don't we need that to handle, say, build paths with spaces in them?

My concern is about the quote in the middle of the path, not about quoting at all... I.e. the ' should be after /tmp_install, not before.


>Admittedly we're probably not completely clean for such paths,
>but that's not an excuse to break the places that do it right.
>
>(I occasionally think about setting up a BF animal configured
>like that, but haven't tried yet.)

That might be a fun exercise. Not so much for the build aspect, but to make sure our tools handle it.

Andres
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.





view thread (66+ messages)  latest in thread

Message-ID: <A544F34E-7CEC-4CBD-A692-7D1DC9FC79EE@anarazel.de>
Permalink:  ../A544F34E-7CEC-4CBD-A692-7D1DC9FC79EE@anarazel.de/
Also on:    postgresql.org/message-id/A544F34E-7CEC-4CBD-A692-7D1DC9FC79EE@anarazel.de

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients from your mail client; the link fills in
  the headers below: reply via email
  Some clients, webmail especially, drop In-Reply-To and References from
  a link, and the reply then starts a new thread: use the mbox below.

  To: pgsql-committers@postgresql.org
  Cc: andres@anarazel.de, tgl@sss.pgh.pa.us, robertmhaas@gmail.com, andrew@dunslane.net, pgsql-hackers@lists.postgresql.org, magnus@hagander.net
  Subject: Re: pgsql: Add 'basebackup_to_shell' contrib module.
  In-Reply-To: <A544F34E-7CEC-4CBD-A692-7D1DC9FC79EE@anarazel.de>
  References: <626827E9-4A50-493D-A8EE-EB3C238BB47F@anarazel.de> <CA+TgmoZ6DdRe0=YYv-dXfKCpfwaoKdUXP6gXg7qVB=3FwON1GA@mail.gmail.com> <7b5c224e-c9c0-fd93-2b51-b399de2d1d4b@dunslane.net> <CA+TgmoYwwTgNPJz34p6MJPAv8OYH77+-sMbae13Ygv8ENfGXdA@mail.gmail.com> <20220326193528.rabb66n6i7ghhesx@alap3.anarazel.de> <CA+TgmoY-x99HMUcV0a+SBWrzcdREHkE69+Xw620BVBjGqvrc4g@mail.gmail.com> <144620.1648326272@sss.pgh.pa.us> <20220326205135.e47br5qj7urgqoqy@alap3.anarazel.de> <20220330162311.uxaxpt2e46c3q6lk@alap3.anarazel.de> <228044.1648658074@sss.pgh.pa.us> <20220330165039.3zseuiraxfjkksf5@alap3.anarazel.de> <230838.1648659506@sss.pgh.pa.us> <A544F34E-7CEC-4CBD-A692-7D1DC9FC79EE@anarazel.de>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox