pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tom Lane <tgl@sss.pgh.pa.us>
To: Michael Paquier <michael@paquier.xyz>
Cc: pgsql-committers@lists.postgresql.org
Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
Date: Mon, 05 Apr 2021 20:40:13 -0400
Message-ID: <936576.1617669613@sss.pgh.pa.us> (raw)
In-Reply-To: <YGuq7obSb5BviTHz@paquier.xyz>
References: <E1lTDox-0006rF-OV@gemulon.postgresql.org>
	<513200.1617634642@sss.pgh.pa.us>
	<YGuSe6Q484Eshj2n@paquier.xyz>
	<932059.1617663467@sss.pgh.pa.us>
	<933130.1617665023@sss.pgh.pa.us>
	<YGunFpb3U9zi5DV4@paquier.xyz>
	<935457.1617668131@sss.pgh.pa.us>
	<YGuq7obSb5BviTHz@paquier.xyz>

Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Apr 05, 2021 at 08:15:31PM -0400, Tom Lane wrote:
>> Dunno.  Certainly most animals that enable TAP at all should be
>> running the "authentication" test, but those others all need to
>> be manually enabled, I believe.  My own animals run the SSL test
>> but not LDAP or kerberos.

> The SSL tests have always sent down a query even for scenarios where
> the connection would fail, but they have used command_fails_like()
> rather than PostgresNode::psql.  The puzzle does not seem complete.

Well, since it's a race condition it's obviously going to be sensitive to
machine speed.  I think that Perl version, or more likely version of
IPC::Run or a related module, may enter into it too.  prairiedog has
gotten through the tests several times since yesterday without failing,
yet it's significantly slower than the other PPC Mac I was able to
consistently reproduce the problem on.  I don't think those two have
the same vintage of Perl installation, though, so Perl version seems
like a likely explanation.

			regards, tom lane





view thread (15+ messages)  latest in thread

Message-ID: <936576.1617669613@sss.pgh.pa.us>
Permalink:  ../936576.1617669613@sss.pgh.pa.us/
Also on:    postgresql.org/message-id/936576.1617669613@sss.pgh.pa.us

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tgl@sss.pgh.pa.us, michael@paquier.xyz, pgsql-committers@lists.postgresql.org
  Subject: Re: pgsql: Refactor all TAP test suites doing connection checks
  In-Reply-To: <936576.1617669613@sss.pgh.pa.us>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox