pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
7+ messages / 2 participants
[nested] [flat]

* pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
@ 2023-02-12 18:06 Tom Lane <tgl@sss.pgh.pa.us>
  2023-02-12 20:12 ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Andres Freund <andres@anarazel.de>
  0 siblings, 1 reply; 7+ messages in thread

From: Tom Lane @ 2023-02-12 18:06 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org

Make pg_bsd_indent's .h files inclusion-order-safe.

As-is, they failed headerscheck.  Per buildfarm.

Branch
------
master

Details
-------
https://git.postgresql.org/pg/commitdiff/6ded4a5a3de1e8d5f3ec50efd4a2d7a39d2550a6

Modified Files
--------------
src/tools/pg_bsd_indent/indent.h | 2 ++
1 file changed, 2 insertions(+)



^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
  2023-02-12 18:06 pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
@ 2023-02-12 20:12 ` Andres Freund <andres@anarazel.de>
  2023-02-12 21:11   ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 7+ messages in thread

From: Andres Freund @ 2023-02-12 20:12 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>

Hi, 

On February 12, 2023 10:06:55 AM PST, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Make pg_bsd_indent's .h files inclusion-order-safe.
>
>As-is, they failed headerscheck.  Per buildfarm.

Cfbot didn't catch this, because it only triggered a warning, not a failure.  We probably should add -Werror?


Greetings,

Andres 
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.





^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
  2023-02-12 18:06 pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
  2023-02-12 20:12 ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Andres Freund <andres@anarazel.de>
@ 2023-02-12 21:11   ` Tom Lane <tgl@sss.pgh.pa.us>
  2023-02-12 21:20     ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Andres Freund <andres@anarazel.de>
  0 siblings, 1 reply; 7+ messages in thread

From: Tom Lane @ 2023-02-12 21:11 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org

Andres Freund <andres@anarazel.de> writes:
> Cfbot didn't catch this, because it only triggered a warning, not a failure.  We probably should add -Werror?

Yeah -- nobody is going to go digging through cfbot logs for warnings,
especially when they know that the Compiler Warnings task is supposed
to complain about those.

I don't think -Werror helps any though; it's a matter of whether the
cfbot is paying attention to headerscheck's exit status ...

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
  2023-02-12 18:06 pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
  2023-02-12 20:12 ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Andres Freund <andres@anarazel.de>
  2023-02-12 21:11   ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
@ 2023-02-12 21:20     ` Andres Freund <andres@anarazel.de>
  2023-02-12 21:25       ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 7+ messages in thread

From: Andres Freund @ 2023-02-12 21:20 UTC (permalink / raw)
  To: pgsql-committers@lists.postgresql.org, Tom Lane <tgl@sss.pgh.pa.us>

Hi, 

On February 12, 2023 1:11:08 PM PST, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>Andres Freund <andres@anarazel.de> writes:
>> Cfbot didn't catch this, because it only triggered a warning, not a failure.  We probably should add -Werror?
>
>Yeah -- nobody is going to go digging through cfbot logs for warnings,
>especially when they know that the Compiler Warnings task is supposed
>to complain about those.
>
>I don't think -Werror helps any though; it's a matter of whether the
>cfbot is paying attention to headerscheck's exit status ...

Thomas fixed that part a while ago, but it'll just return 0 if it just is a warning...

Andres
-- 
Sent from my Android device with K-9 Mail. Please excuse my brevity.





^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
  2023-02-12 18:06 pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
  2023-02-12 20:12 ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Andres Freund <andres@anarazel.de>
  2023-02-12 21:11   ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
  2023-02-12 21:20     ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Andres Freund <andres@anarazel.de>
@ 2023-02-12 21:25       ` Tom Lane <tgl@sss.pgh.pa.us>
  2023-02-12 22:21         ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Andres Freund <andres@anarazel.de>
  0 siblings, 1 reply; 7+ messages in thread

From: Tom Lane @ 2023-02-12 21:25 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org

Andres Freund <andres@anarazel.de> writes:
> On February 12, 2023 1:11:08 PM PST, Tom Lane <tgl@sss.pgh.pa.us> wrote:
>> I don't think -Werror helps any though; it's a matter of whether the
>> cfbot is paying attention to headerscheck's exit status ...

> Thomas fixed that part a while ago, but it'll just return 0 if it just is a warning...

Hmm, but why'd the buildfarm complain then? ... oh, because it checks
for nonempty output as well as nonzero exit status.

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
  2023-02-12 18:06 pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
  2023-02-12 20:12 ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Andres Freund <andres@anarazel.de>
  2023-02-12 21:11   ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
  2023-02-12 21:20     ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Andres Freund <andres@anarazel.de>
  2023-02-12 21:25       ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
@ 2023-02-12 22:21         ` Andres Freund <andres@anarazel.de>
  2023-02-12 22:30           ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 1 reply; 7+ messages in thread

From: Andres Freund @ 2023-02-12 22:21 UTC (permalink / raw)
  To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: pgsql-committers@lists.postgresql.org

Hi,

On 2023-02-12 16:25:28 -0500, Tom Lane wrote:
> Andres Freund <andres@anarazel.de> writes:
> > On February 12, 2023 1:11:08 PM PST, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> >> I don't think -Werror helps any though; it's a matter of whether the
> >> cfbot is paying attention to headerscheck's exit status ...
> 
> > Thomas fixed that part a while ago, but it'll just return 0 if it just is a warning...
> 
> Hmm, but why'd the buildfarm complain then? ... oh, because it checks
> for nonempty output as well as nonzero exit status.

Right.

Obviously that approach could be re-implemented for CI, but givent that it
additionally is somewhat required to make use of headerscheck/cpluspluscheck
locally, it feels better to solve it in headerscheck. And the easiest way for
that seems to be -Werror?

Greetings,

Andres Freund





^ permalink  raw  reply  [nested|flat] 7+ messages in thread

* Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe.
  2023-02-12 18:06 pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
  2023-02-12 20:12 ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Andres Freund <andres@anarazel.de>
  2023-02-12 21:11   ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
  2023-02-12 21:20     ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Andres Freund <andres@anarazel.de>
  2023-02-12 21:25       ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
  2023-02-12 22:21         ` Re: pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Andres Freund <andres@anarazel.de>
@ 2023-02-12 22:30           ` Tom Lane <tgl@sss.pgh.pa.us>
  0 siblings, 0 replies; 7+ messages in thread

From: Tom Lane @ 2023-02-12 22:30 UTC (permalink / raw)
  To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org

Andres Freund <andres@anarazel.de> writes:
> Obviously that approach could be re-implemented for CI, but givent that it
> additionally is somewhat required to make use of headerscheck/cpluspluscheck
> locally, it feels better to solve it in headerscheck. And the easiest way for
> that seems to be -Werror?

Agreed --- although right now, headerscheck goes out of its way to be
agnostic about what compiler and cflags are used.  Having it assume
that -Werror will work seems a bit ugly.  Not sure that it's a problem
in practice though.

(BTW, we'll have to fix these scripts sometime to work in non-Make
builds.)

			regards, tom lane





^ permalink  raw  reply  [nested|flat] 7+ messages in thread


end of thread, other threads:[~2023-02-12 22:30 UTC | newest]

Thread overview: 7+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2023-02-12 18:06 pgsql: Make pg_bsd_indent's .h files inclusion-order-safe. Tom Lane <tgl@sss.pgh.pa.us>
2023-02-12 20:12 ` Andres Freund <andres@anarazel.de>
2023-02-12 21:11   ` Tom Lane <tgl@sss.pgh.pa.us>
2023-02-12 21:20     ` Andres Freund <andres@anarazel.de>
2023-02-12 21:25       ` Tom Lane <tgl@sss.pgh.pa.us>
2023-02-12 22:21         ` Andres Freund <andres@anarazel.de>
2023-02-12 22:30           ` Tom Lane <tgl@sss.pgh.pa.us>

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox