pg.ddx.io pgsql-committers@postgresql.org mailing list archive
help / color / mirror / Atom feedpgsql: Build all Flex files standalone
14+ messages / 5 participants
[nested] [flat]
Commits from this thread:
2022-09-06 829906fb6c Fix headerscheck in vpath builds
2022-09-06 8c06a282fe Add missing exceptions to cpluspluscheck
* pgsql: Build all Flex files standalone
@ 2022-09-04 05:11 John Naylor <john.naylor@postgresql.org>
2022-09-04 06:19 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-04 09:36 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
0 siblings, 2 replies; 14+ messages in thread
From: John Naylor @ 2022-09-04 05:11 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org
Build all Flex files standalone
The proposed Meson build system will need a way to ignore certain
generated files in order to coexist with the autoconf build system,
and C files generated by Flex which are #include'd into .y files make
this more difficult. In similar vein to 72b1e3a21, arrange for all Flex
C files to compile to their own .o targets.
Reviewed by Andres Freund
Discussion: https://www.postgresql.org/message-id/20220810171935.7k5zgnjwqzalzmtm%40awork3.anarazel.de
Discussion: https://www.postgresql.org/message-id/CAFBsxsF8Gc2StS3haXofshHCzqNMRXiSxvQEYGwnFsTmsdwNeg@mail.gmail...
Branch
------
master
Details
-------
https://git.postgresql.org/pg/commitdiff/dac048f71ebbcf2f980d280711f8ff8001331c5d
Modified Files
--------------
contrib/cube/.gitignore | 1 +
contrib/cube/Makefile | 16 +++++----
contrib/cube/cube.c | 6 ++--
contrib/cube/cubedata.h | 6 ++--
contrib/cube/cubeparse.y | 6 +---
contrib/cube/cubescan.l | 44 ++++++++++++++---------
contrib/seg/.gitignore | 1 +
contrib/seg/Makefile | 15 +++++---
contrib/seg/segparse.y | 3 --
contrib/seg/segscan.l | 28 +++++++++------
src/backend/Makefile | 7 ++--
src/backend/bootstrap/.gitignore | 1 +
src/backend/bootstrap/Makefile | 11 ++++--
src/backend/bootstrap/bootparse.y | 2 --
src/backend/bootstrap/bootscanner.l | 60 +++++++++++++++++--------------
src/backend/replication/.gitignore | 2 ++
src/backend/replication/Makefile | 22 +++++++++---
src/backend/replication/repl_gram.y | 2 --
src/backend/replication/repl_scanner.l | 31 ++++++++++------
src/backend/replication/syncrep_gram.y | 2 --
src/backend/replication/syncrep_scanner.l | 21 +++++++----
src/backend/utils/adt/.gitignore | 1 +
src/backend/utils/adt/Makefile | 11 ++++--
src/backend/utils/adt/jsonpath_gram.y | 27 +-------------
src/backend/utils/adt/jsonpath_internal.h | 32 +++++++++++++++++
src/backend/utils/adt/jsonpath_scan.l | 29 +++++++++------
src/backend/utils/misc/Makefile | 5 +--
src/backend/utils/misc/guc-file.l | 8 +++--
src/backend/utils/misc/guc.c | 2 --
src/bin/pgbench/.gitignore | 1 +
src/bin/pgbench/Makefile | 13 +++++--
src/bin/pgbench/exprparse.y | 15 --------
src/bin/pgbench/exprscan.l | 12 ++++++-
src/test/isolation/.gitignore | 1 +
src/test/isolation/Makefile | 15 +++++---
src/test/isolation/specparse.y | 2 --
src/test/isolation/specscanner.l | 28 ++++++++++-----
src/tools/pginclude/headerscheck | 8 +++++
38 files changed, 307 insertions(+), 190 deletions(-)
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: Build all Flex files standalone
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
@ 2022-09-04 06:19 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-04 13:34 ` Re: pgsql: Build all Flex files standalone Andrew Dunstan <andrew@dunslane.net>
2022-09-04 21:08 ` Re: pgsql: Build all Flex files standalone Andres Freund <andres@anarazel.de>
1 sibling, 2 replies; 14+ messages in thread
From: John Naylor @ 2022-09-04 06:19 UTC (permalink / raw)
To: John Naylor <john.naylor@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
Crake fails with
headerscheck:
Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2:
Sep 04 01:56:01
/home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
fatal error: jsonpath_gram.h: No such file or directory
Sep 04 01:56:01 26 | #include "jsonpath_gram.h"
Sep 04 01:56:01 | ^~~~~~~~~~~~~~~~~
Sep 04 01:56:01 compilation terminated.
Sep 04 01:56:14 make: *** [GNUmakefile:138: headerscheck] Error 1
cpluspluscheck:
Sep 04 01:57:19 In file included from /tmp/cpluspluscheck.HhRV5k/test.cpp:3:
Sep 04 01:57:19
/home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
fatal error: jsonpath_gram.h: No such file or directory
Sep 04 01:57:19 26 | #include "jsonpath_gram.h"
Sep 04 01:57:19 | ^~~~~~~~~~~~~~~~~
I don't get the same in an already-built tree. I also don't see an
exception for gramparse.h, which I imagine would have the same issue?
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: Build all Flex files standalone
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
2022-09-04 06:19 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
@ 2022-09-04 13:34 ` Andrew Dunstan <andrew@dunslane.net>
2022-09-05 04:20 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-06 03:33 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
1 sibling, 2 replies; 14+ messages in thread
From: Andrew Dunstan @ 2022-09-04 13:34 UTC (permalink / raw)
To: John Naylor <john.naylor@enterprisedb.com>; John Naylor <john.naylor@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
On 2022-09-04 Su 02:19, John Naylor wrote:
> Crake fails with
>
> headerscheck:
> Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2:
> Sep 04 01:56:01
> /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
> fatal error: jsonpath_gram.h: No such file or directory
> Sep 04 01:56:01 26 | #include "jsonpath_gram.h"
> Sep 04 01:56:01 | ^~~~~~~~~~~~~~~~~
> Sep 04 01:56:01 compilation terminated.
> Sep 04 01:56:14 make: *** [GNUmakefile:138: headerscheck] Error 1
> cpluspluscheck:
> Sep 04 01:57:19 In file included from /tmp/cpluspluscheck.HhRV5k/test.cpp:3:
> Sep 04 01:57:19
> /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
> fatal error: jsonpath_gram.h: No such file or directory
> Sep 04 01:57:19 26 | #include "jsonpath_gram.h"
> Sep 04 01:57:19 | ^~~~~~~~~~~~~~~~~
>
> I don't get the same in an already-built tree. I also don't see an
> exception for gramparse.h, which I imagine would have the same issue?
Probably happens because crake does vpath builds. I think you're going
to have to set up EXTRAINCLUDES for it - see near the bottom of the
headerscheck script. Possibly something like
src/backend/utils/adt/*)
EXTRAINCLUDES="-I $builddir/src/backend/utils/adt" ;;
cheers
andrew
--
Andrew Dunstan
EDB: https://www.enterprisedb.com
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: Build all Flex files standalone
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
2022-09-04 06:19 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-04 13:34 ` Re: pgsql: Build all Flex files standalone Andrew Dunstan <andrew@dunslane.net>
@ 2022-09-05 04:20 ` John Naylor <john.naylor@enterprisedb.com>
1 sibling, 0 replies; 14+ messages in thread
From: John Naylor @ 2022-09-05 04:20 UTC (permalink / raw)
To: Andrew Dunstan <andrew@dunslane.net>; +Cc: John Naylor <john.naylor@postgresql.org>; pgsql-committers@lists.postgresql.org
On Sun, Sep 4, 2022 at 8:34 PM Andrew Dunstan <andrew@dunslane.net> wrote:
> Probably happens because crake does vpath builds. I think you're going
> to have to set up EXTRAINCLUDES for it - see near the bottom of the
> headerscheck script. Possibly something like
>
>
> src/backend/utils/adt/*)
>
> EXTRAINCLUDES="-I $builddir/src/backend/utils/adt" ;;
Okay, I'll look at this and the cpp header check within 24 hours.
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: Build all Flex files standalone
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
2022-09-04 06:19 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-04 13:34 ` Re: pgsql: Build all Flex files standalone Andrew Dunstan <andrew@dunslane.net>
@ 2022-09-06 03:33 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-06 03:54 ` Re: pgsql: Build all Flex files standalone Andres Freund <andres@anarazel.de>
1 sibling, 1 reply; 14+ messages in thread
From: John Naylor @ 2022-09-06 03:33 UTC (permalink / raw)
To: Andrew Dunstan <andrew@dunslane.net>; +Cc: John Naylor <john.naylor@postgresql.org>; pgsql-committers@lists.postgresql.org
On Sun, Sep 4, 2022 at 8:34 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>
>
> On 2022-09-04 Su 02:19, John Naylor wrote:
> > Crake fails with
> >
> > headerscheck:
> > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2:
> > Sep 04 01:56:01
> > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
> > fatal error: jsonpath_gram.h: No such file or directory
> > Sep 04 01:56:01 26 | #include "jsonpath_gram.h"
> > Sep 04 01:56:01 | ^~~~~~~~~~~~~~~~~
> > Sep 04 01:56:01 compilation terminated.
> > Sep 04 01:56:14 make: *** [GNUmakefile:138: headerscheck] Error 1
> > cpluspluscheck:
> > Sep 04 01:57:19 In file included from /tmp/cpluspluscheck.HhRV5k/test.cpp:3:
> > Sep 04 01:57:19
> > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
> > fatal error: jsonpath_gram.h: No such file or directory
> > Sep 04 01:57:19 26 | #include "jsonpath_gram.h"
> > Sep 04 01:57:19 | ^~~~~~~~~~~~~~~~~
> >
> > I don't get the same in an already-built tree. I also don't see an
> > exception for gramparse.h, which I imagine would have the same issue?
>
>
>
> Probably happens because crake does vpath builds. I think you're going
> to have to set up EXTRAINCLUDES for it - see near the bottom of the
> headerscheck script. Possibly something like
>
>
> src/backend/utils/adt/*)
>
> EXTRAINCLUDES="-I $builddir/src/backend/utils/adt" ;;
I just tried a vpath build and the failing check doesn't reproduce for
me there. Any ideas?
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: Build all Flex files standalone
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
2022-09-04 06:19 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-04 13:34 ` Re: pgsql: Build all Flex files standalone Andrew Dunstan <andrew@dunslane.net>
2022-09-06 03:33 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
@ 2022-09-06 03:54 ` Andres Freund <andres@anarazel.de>
2022-09-06 04:20 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
0 siblings, 1 reply; 14+ messages in thread
From: Andres Freund @ 2022-09-06 03:54 UTC (permalink / raw)
To: pgsql-committers@lists.postgresql.org, John Naylor <john.naylor@enterprisedb.com>; Andrew Dunstan <andrew@dunslane.net>; +Cc: John Naylor <john.naylor@postgresql.org>
Hi,
On September 5, 2022 8:33:37 PM PDT, John Naylor <john.naylor@enterprisedb.com> wrote:
>On Sun, Sep 4, 2022 at 8:34 PM Andrew Dunstan <andrew@dunslane.net> wrote:
>>
>>
>> On 2022-09-04 Su 02:19, John Naylor wrote:
>> > Crake fails with
>> >
>> > headerscheck:
>> > Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2:
>> > Sep 04 01:56:01
>> > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
>> > fatal error: jsonpath_gram.h: No such file or directory
>> > Sep 04 01:56:01 26 | #include "jsonpath_gram.h"
>> > Sep 04 01:56:01 | ^~~~~~~~~~~~~~~~~
>> > Sep 04 01:56:01 compilation terminated.
>> > Sep 04 01:56:14 make: *** [GNUmakefile:138: headerscheck] Error 1
>> > cpluspluscheck:
>> > Sep 04 01:57:19 In file included from /tmp/cpluspluscheck.HhRV5k/test.cpp:3:
>> > Sep 04 01:57:19
>> > /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
>> > fatal error: jsonpath_gram.h: No such file or directory
>> > Sep 04 01:57:19 26 | #include "jsonpath_gram.h"
>> > Sep 04 01:57:19 | ^~~~~~~~~~~~~~~~~
>> >
>> > I don't get the same in an already-built tree. I also don't see an
>> > exception for gramparse.h, which I imagine would have the same issue?
>>
>>
>>
>> Probably happens because crake does vpath builds. I think you're going
>> to have to set up EXTRAINCLUDES for it - see near the bottom of the
>> headerscheck script. Possibly something like
>>
>>
>> src/backend/utils/adt/*)
>>
>> EXTRAINCLUDES="-I $builddir/src/backend/utils/adt" ;;
>
>I just tried a vpath build and the failing check doesn't reproduce for
>me there. Any ideas?
Presumably it only happens if you previously triggered the parsers to be generated.
Andres
--
Sent from my Android device with K-9 Mail. Please excuse my brevity.
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: Build all Flex files standalone
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
2022-09-04 06:19 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-04 13:34 ` Re: pgsql: Build all Flex files standalone Andrew Dunstan <andrew@dunslane.net>
2022-09-06 03:33 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-06 03:54 ` Re: pgsql: Build all Flex files standalone Andres Freund <andres@anarazel.de>
@ 2022-09-06 04:20 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-06 04:49 ` Re: pgsql: Build all Flex files standalone Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 14+ messages in thread
From: John Naylor @ 2022-09-06 04:20 UTC (permalink / raw)
To: Andres Freund <andres@anarazel.de>; +Cc: pgsql-committers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>; John Naylor <john.naylor@postgresql.org>
On Tue, Sep 6, 2022 at 10:54 AM Andres Freund <andres@anarazel.de> wrote:
> >I just tried a vpath build and the failing check doesn't reproduce for
> >me there. Any ideas?
>
> Presumably it only happens if you previously triggered the parsers to be generated.
If you attempt to run the check before building, the first thing you get is
fatal error: utils/errcodes.h: No such file or directory
so not sure what you mean.
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: Build all Flex files standalone
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
2022-09-04 06:19 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-04 13:34 ` Re: pgsql: Build all Flex files standalone Andrew Dunstan <andrew@dunslane.net>
2022-09-06 03:33 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-06 03:54 ` Re: pgsql: Build all Flex files standalone Andres Freund <andres@anarazel.de>
2022-09-06 04:20 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
@ 2022-09-06 04:49 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-09-06 04:57 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
0 siblings, 1 reply; 14+ messages in thread
From: Tom Lane @ 2022-09-06 04:49 UTC (permalink / raw)
To: John Naylor <john.naylor@enterprisedb.com>; +Cc: Andres Freund <andres@anarazel.de>; pgsql-committers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
John Naylor <john.naylor@enterprisedb.com> writes:
> On Tue, Sep 6, 2022 at 10:54 AM Andres Freund <andres@anarazel.de> wrote:
>> Presumably it only happens if you previously triggered the parsers to be generated.
> If you attempt to run the check before building, the first thing you get is
> fatal error: utils/errcodes.h: No such file or directory
> so not sure what you mean.
crake is still unhappy:
Sep 06 00:09:55 In file included from /tmp/headerscheck.AwLxya/test.c:2:
Sep 06 00:09:55 /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: fatal error: jsonpath_gram.h: No such file or directory
Sep 06 00:09:55 26 | #include "jsonpath_gram.h"
Sep 06 00:09:55 | ^~~~~~~~~~~~~~~~~
I wonder if that file is not getting installed in a directory that
this test expects to search.
regards, tom lane
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: Build all Flex files standalone
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
2022-09-04 06:19 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-04 13:34 ` Re: pgsql: Build all Flex files standalone Andrew Dunstan <andrew@dunslane.net>
2022-09-06 03:33 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-06 03:54 ` Re: pgsql: Build all Flex files standalone Andres Freund <andres@anarazel.de>
2022-09-06 04:20 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-06 04:49 ` Re: pgsql: Build all Flex files standalone Tom Lane <tgl@sss.pgh.pa.us>
@ 2022-09-06 04:57 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-06 05:30 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
0 siblings, 1 reply; 14+ messages in thread
From: John Naylor @ 2022-09-06 04:57 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Andres Freund <andres@anarazel.de>; pgsql-committers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
On Tue, Sep 6, 2022 at 11:49 AM Tom Lane <tgl@sss.pgh.pa.us> wrote:
>
> crake is still unhappy:
>
> Sep 06 00:09:55 In file included from /tmp/headerscheck.AwLxya/test.c:2:
> Sep 06 00:09:55 /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10: fatal error: jsonpath_gram.h: No such file or directory
> Sep 06 00:09:55 26 | #include "jsonpath_gram.h"
> Sep 06 00:09:55 | ^~~~~~~~~~~~~~~~~
>
> I wonder if that file is not getting installed in a directory that
> this test expects to search.
There are two proposed fixes upthread, which I will copy below, but if
I can't reproduce locally, I don't have much confidence in which one
is the way to go to get crake green again:
Andrew:
> Probably happens because crake does vpath builds. I think you're going
> to have to set up EXTRAINCLUDES for it - see near the bottom of the
> headerscheck script. Possibly something like
>
>
> src/backend/utils/adt/*)
>
> EXTRAINCLUDES="-I $builddir/src/backend/utils/adt" ;;
Andres:
> It doesn't happen for gramparse.h because gram.h is copied to
> src/include/parser (see src/backend/Makefile), and included as parser/gram.h.
>
> I think this could be addressed by always adding something like
> -iquote $builddir/$(dirname "$f") -iquote $srcdir/$(dirname "$f") \
> to cpluspluscheck/headerscheck.
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: Build all Flex files standalone
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
2022-09-04 06:19 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-04 13:34 ` Re: pgsql: Build all Flex files standalone Andrew Dunstan <andrew@dunslane.net>
2022-09-06 03:33 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-06 03:54 ` Re: pgsql: Build all Flex files standalone Andres Freund <andres@anarazel.de>
2022-09-06 04:20 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-06 04:49 ` Re: pgsql: Build all Flex files standalone Tom Lane <tgl@sss.pgh.pa.us>
2022-09-06 04:57 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
@ 2022-09-06 05:30 ` John Naylor <john.naylor@enterprisedb.com>
0 siblings, 0 replies; 14+ messages in thread
From: John Naylor @ 2022-09-06 05:30 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Andres Freund <andres@anarazel.de>; pgsql-committers@lists.postgresql.org, Andrew Dunstan <andrew@dunslane.net>
I see why I couldn't reproduce: I neglected to add jsonpath_gram.h to
the backend's maintainer-clean so it failed to be deleted. Working on
the fix now.
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: Build all Flex files standalone
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
2022-09-04 06:19 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
@ 2022-09-04 21:08 ` Andres Freund <andres@anarazel.de>
1 sibling, 0 replies; 14+ messages in thread
From: Andres Freund @ 2022-09-04 21:08 UTC (permalink / raw)
To: John Naylor <john.naylor@enterprisedb.com>; +Cc: John Naylor <john.naylor@postgresql.org>; pgsql-committers@lists.postgresql.org
Hi,
On 2022-09-04 13:19:56 +0700, John Naylor wrote:
> Crake fails with
>
> headerscheck:
> Sep 04 01:56:01 In file included from /tmp/headerscheck.UNgmKy/test.c:2:
> Sep 04 01:56:01
> /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
> fatal error: jsonpath_gram.h: No such file or directory
> Sep 04 01:56:01 26 | #include "jsonpath_gram.h"
> Sep 04 01:56:01 | ^~~~~~~~~~~~~~~~~
> Sep 04 01:56:01 compilation terminated.
> Sep 04 01:56:14 make: *** [GNUmakefile:138: headerscheck] Error 1
> cpluspluscheck:
> Sep 04 01:57:19 In file included from /tmp/cpluspluscheck.HhRV5k/test.cpp:3:
> Sep 04 01:57:19
> /home/andrew/bf/root/HEAD/pgsql.build/../pgsql/src/backend/utils/adt/jsonpath_internal.h:26:10:
> fatal error: jsonpath_gram.h: No such file or directory
> Sep 04 01:57:19 26 | #include "jsonpath_gram.h"
> Sep 04 01:57:19 | ^~~~~~~~~~~~~~~~~
>
> I don't get the same in an already-built tree. I also don't see an
> exception for gramparse.h, which I imagine would have the same issue?
It doesn't happen for gramparse.h because gram.h is copied to
src/include/parser (see src/backend/Makefile), and included as parser/gram.h.
I think this could be addressed by always adding something like
-iquote $builddir/$(dirname "$f") -iquote $srcdir/$(dirname "$f") \
to cpluspluscheck/headerscheck.
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: Build all Flex files standalone
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
@ 2022-09-04 09:36 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-04 11:04 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
1 sibling, 1 reply; 14+ messages in thread
From: John Naylor @ 2022-09-04 09:36 UTC (permalink / raw)
To: John Naylor <john.naylor@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
The second failure is on drongo (MSVC):
"c:\\prog\\bf\\root\\HEAD\\pgsql.build\\pgsql.sln" (default target) (1) ->
"c:\\prog\\bf\\root\\HEAD\\pgsql.build\\isolationtester.vcxproj"
(default target) (13) ->
(Link target) ->
specparse.obj : error LNK2019: unresolved external symbol spec_yylex
referenced in function spec_yyparse
[c:\\prog\\bf\\root\\HEAD\\pgsql.build\\isolationtester.vcxproj]
specparse.obj : error LNK2019: unresolved external symbol
spec_yyerror referenced in function spec_yyparse
[c:\\prog\\bf\\root\\HEAD\\pgsql.build\\isolationtester.vcxproj]
.\\Release\\isolationtester\\isolationtester.exe : fatal error
LNK1120: 2 unresolved externals
[c:\\prog\\bf\\root\\HEAD\\pgsql.build\\isolationtester.vcxproj]
For this, Mkvcbuild.pm specifies specparse.c explicitly, so maybe
something like the following is needed:
inline patch 1: src/tools/msvc/Mkvcbuild.pm (+1/-1 lines) download inline-1.patch
--- a/src/tools/msvc/Mkvcbuild.pm
+++ b/src/tools/msvc/Mkvcbuild.pm
@@ -362,6 +362,7 @@ sub mkvcbuild
$isolation_tester->AddFile('src/test/isolation/specparse.y');
$isolation_tester->AddFile('src/test/isolation/specscanner.l');
$isolation_tester->AddFile('src/test/isolation/specparse.c');
+ $isolation_tester->AddFile('src/test/isolation/specscanner.c');
$isolation_tester->AddIncludeDir('src/test/isolation');
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: Build all Flex files standalone
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
2022-09-04 09:36 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
@ 2022-09-04 11:04 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-04 20:57 ` Re: pgsql: Build all Flex files standalone Andres Freund <andres@anarazel.de>
0 siblings, 1 reply; 14+ messages in thread
From: John Naylor @ 2022-09-04 11:04 UTC (permalink / raw)
To: John Naylor <john.naylor@postgresql.org>; +Cc: pgsql-committers@lists.postgresql.org
On Sun, Sep 4, 2022 at 4:36 PM John Naylor <john.naylor@enterprisedb.com> wrote:
>
> For this, Mkvcbuild.pm specifies specparse.c explicitly, so maybe
> something like the following is needed:
>
> --- a/src/tools/msvc/Mkvcbuild.pm
> +++ b/src/tools/msvc/Mkvcbuild.pm
> @@ -362,6 +362,7 @@ sub mkvcbuild
> $isolation_tester->AddFile('src/test/isolation/specparse.y');
> $isolation_tester->AddFile('src/test/isolation/specscanner.l');
> $isolation_tester->AddFile('src/test/isolation/specparse.c');
> + $isolation_tester->AddFile('src/test/isolation/specscanner.c');
> $isolation_tester->AddIncludeDir('src/test/isolation');
This gets CI green (tip o' the hat to Thomas Munro for off-list advice
on getting that working), so pushed.
--
John Naylor
EDB: http://www.enterprisedb.com
^ permalink raw reply [nested|flat] 14+ messages in thread
* Re: pgsql: Build all Flex files standalone
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
2022-09-04 09:36 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
2022-09-04 11:04 ` Re: pgsql: Build all Flex files standalone John Naylor <john.naylor@enterprisedb.com>
@ 2022-09-04 20:57 ` Andres Freund <andres@anarazel.de>
0 siblings, 0 replies; 14+ messages in thread
From: Andres Freund @ 2022-09-04 20:57 UTC (permalink / raw)
To: John Naylor <john.naylor@enterprisedb.com>; +Cc: John Naylor <john.naylor@postgresql.org>; pgsql-committers@lists.postgresql.org
Hi,
On 2022-09-04 18:04:13 +0700, John Naylor wrote:
> On Sun, Sep 4, 2022 at 4:36 PM John Naylor <john.naylor@enterprisedb.com> wrote:
> >
> > For this, Mkvcbuild.pm specifies specparse.c explicitly, so maybe
> > something like the following is needed:
> >
> > --- a/src/tools/msvc/Mkvcbuild.pm
> > +++ b/src/tools/msvc/Mkvcbuild.pm
> > @@ -362,6 +362,7 @@ sub mkvcbuild
> > $isolation_tester->AddFile('src/test/isolation/specparse.y');
> > $isolation_tester->AddFile('src/test/isolation/specscanner.l');
> > $isolation_tester->AddFile('src/test/isolation/specparse.c');
> > + $isolation_tester->AddFile('src/test/isolation/specscanner.c');
> > $isolation_tester->AddIncludeDir('src/test/isolation');
>
> This gets CI green (tip o' the hat to Thomas Munro for off-list advice
> on getting that working), so pushed.
It doesn't seem to have gotten all of CI green, cpluspluscheck fails:
https://cirrus-ci.com/task/6561938334285824
I think this just needs a copy the logic you added to headerscheck also to
cpluspluscheck (and yes, we should merge these files one of these days).
Greetings,
Andres Freund
^ permalink raw reply [nested|flat] 14+ messages in thread
end of thread, other threads:[~2022-09-06 05:30 UTC | newest]
Thread overview: 14+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2022-09-04 05:11 pgsql: Build all Flex files standalone John Naylor <john.naylor@postgresql.org>
2022-09-04 06:19 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-04 13:34 ` Andrew Dunstan <andrew@dunslane.net>
2022-09-05 04:20 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-06 03:33 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-06 03:54 ` Andres Freund <andres@anarazel.de>
2022-09-06 04:20 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-06 04:49 ` Tom Lane <tgl@sss.pgh.pa.us>
2022-09-06 04:57 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-06 05:30 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-04 21:08 ` Andres Freund <andres@anarazel.de>
2022-09-04 09:36 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-04 11:04 ` John Naylor <john.naylor@enterprisedb.com>
2022-09-04 20:57 ` Andres Freund <andres@anarazel.de>
This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox