pg.ddx.io  pgsql-committers@postgresql.org mailing list archive  
help / color / mirror / Atom feed
From: Tomas Vondra <tomas.vondra@enterprisedb.com>
To: Christoph Berg <myon@debian.org>
Cc: Michael Paquier <michael@paquier.xyz>
Cc: Daniel Gustafsson <daniel@yesql.se>
Cc: Tomas Vondra <tomas.vondra@postgresql.org>
Cc: PostgreSQL Hackers <pgsql-hackers@lists.postgresql.org>
Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
Date: Tue, 14 Mar 2023 15:24:41 +0100
Message-ID: <ef0cbd4e-0e52-e634-da52-1609e27e939e@enterprisedb.com> (raw)
In-Reply-To: <ZBBNoNHRu7hFeeyf@msg.df7cb.de>
References: <E1pVI5z-000MHR-Ch@gemulon.postgresql.org>
	<ZAjL96N9ZW84U59p@msg.df7cb.de>
	<E6DD8AC9-3EE4-4E7B-A2BC-53FDF04D1ED0@yesql.se>
	<819f6883-f7cf-74fd-e918-4c06a9d76d0b@enterprisedb.com>
	<ZAkol+4UyWuBR7PS@paquier.xyz>
	<0e8e53fa-5087-2151-dcd6-a1d3ad3ed493@enterprisedb.com>
	<74f02417-d18a-71dd-a406-8af41cbeb6c4@enterprisedb.com>
	<ZBBNoNHRu7hFeeyf@msg.df7cb.de>

On 3/14/23 11:34, Christoph Berg wrote:
> Re: Tomas Vondra
>> and I don't think there's a good place to inject the 'rm' so I ended up
>> adding a 'cleanup_cmd' right after 'compress_cmd'. But it seems a bit
>> strange / hacky. Maybe there's a better way?
> 
> Does the file need to be removed at all? Could we leave it there and
> have "make clean" remove it?
> 

I don't think that'd work, because of the automatic "discovery" where we
check if a file exists, and if not we try to append .gz and .lz4. So if
you leave the .toc, we'd not find the .lz4, making the test useless ...


regards

-- 
Tomas Vondra
EnterpriseDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company





view thread (10+ messages)  latest in thread

Message-ID: <ef0cbd4e-0e52-e634-da52-1609e27e939e@enterprisedb.com>
Permalink:  ../ef0cbd4e-0e52-e634-da52-1609e27e939e@enterprisedb.com/
Also on:    postgresql.org/message-id/ef0cbd4e-0e52-e634-da52-1609e27e939e@enterprisedb.com

 · 

reply

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Reply to all the recipients using the --to and --cc options:
  reply via email

  To: pgsql-committers@postgresql.org
  Cc: tomas.vondra@enterprisedb.com, myon@debian.org, michael@paquier.xyz, daniel@yesql.se, tomas.vondra@postgresql.org, pgsql-hackers@lists.postgresql.org
  Subject: Re: lz4 --rm on Ubuntu 18.04 (Add LZ4 compression to pg_dump)
  In-Reply-To: <ef0cbd4e-0e52-e634-da52-1609e27e939e@enterprisedb.com>

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

This inbox is served by DDX for PostgreSQL; see mirroring instructions
for how to clone and mirror all data and code used for this inbox