agora inbox for pgsql-docs@postgresql.org
help / color / mirror / Atom feedTypo
43+ messages / 20 participants
[nested] [flat]
* Typo
@ 2016-06-04 07:28 gp0072000@gmail.com
2016-06-07 02:44 ` Re: Typo Michael Paquier <michael.paquier@gmail.com>
0 siblings, 1 reply; 43+ messages in thread
From: gp0072000@gmail.com @ 2016-06-04 07:28 UTC (permalink / raw)
To: pgsql-docs
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/9.5/static/backup-dump.html
Description:
Before restoring an SQL dump,
Should be
Before restoring a SQL dump,
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2016-06-04 07:28 Typo gp0072000@gmail.com
@ 2016-06-07 02:44 ` Michael Paquier <michael.paquier@gmail.com>
2016-06-07 02:56 ` Re: Typo Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 1 reply; 43+ messages in thread
From: Michael Paquier @ 2016-06-07 02:44 UTC (permalink / raw)
To: gp0072000@gmail.com; +Cc: pgsql-docs
On Sat, Jun 4, 2016 at 4:28 PM, <gp0072000@gmail.com> wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/9.5/static/backup-dump.html
> Description:
>
> Before restoring an SQL dump,
>
> Should be
>
> Before restoring a SQL dump,
The source code has a shared opinion on the matter:
$ git grep "a SQL" | wc -l
630
$ git grep "an SQL" | wc -l
238
Based on some past memories of some basic English lessons, this should
be "an" I think, because the S of SQL spells as "esse" :)
--
Michael
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2016-06-04 07:28 Typo gp0072000@gmail.com
2016-06-07 02:44 ` Re: Typo Michael Paquier <michael.paquier@gmail.com>
@ 2016-06-07 02:56 ` Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 0 replies; 43+ messages in thread
From: Tom Lane @ 2016-06-07 02:56 UTC (permalink / raw)
To: Michael Paquier <michael.paquier@gmail.com>; +Cc: gp0072000@gmail.com; pgsql-docs
Michael Paquier <michael.paquier@gmail.com> writes:
> On Sat, Jun 4, 2016 at 4:28 PM, <gp0072000@gmail.com> wrote:
>> Before restoring an SQL dump,
>> Should be
>> Before restoring a SQL dump,
> The source code has a shared opinion on the matter:
> $ git grep "a SQL" | wc -l
> 630
> $ git grep "an SQL" | wc -l
> 238
> Based on some past memories of some basic English lessons, this should
> be "an" I think, because the S of SQL spells as "esse" :)
It depends on whether you prefer to spell out the abbreviation or
pronounce it as a word. So I would read it as either "a sequel dump"
or "an ess-cue-ell dump". Either is correct on its own terms, which
is why there's not a very strong consensus in our code/docs. I'm not
excited about trying to standardize on one vs. the other.
regards, tom lane
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 43+ messages in thread
* Typo.
@ 2016-06-07 11:26 Dmitry Igrishin <dmitigr@gmail.com>
2016-06-07 12:08 ` Re: Typo. Dmitry Igrishin <dmitigr@gmail.com>
2016-06-07 12:44 ` Re: Typo. Kevin Grittner <kgrittn@gmail.com>
0 siblings, 2 replies; 43+ messages in thread
From: Dmitry Igrishin @ 2016-06-07 11:26 UTC (permalink / raw)
To: pgsql-docs
Hi,
In "Internal position: this is defined the same as the P field, but it
is used when the cursor position refers to an internally generated",
"internally generated" should be replaced with "internally-generated".
https://www.postgresql.org/docs/9.6/static/protocol-error-fields.html
--
// Dmitry.
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo.
2016-06-07 11:26 Typo. Dmitry Igrishin <dmitigr@gmail.com>
@ 2016-06-07 12:08 ` Dmitry Igrishin <dmitigr@gmail.com>
1 sibling, 0 replies; 43+ messages in thread
From: Dmitry Igrishin @ 2016-06-07 12:08 UTC (permalink / raw)
To: pgsql-docs
2016-06-07 14:26 GMT+03:00 Dmitry Igrishin <dmitigr@gmail.com>:
> Hi,
>
> In "Internal position: this is defined the same as the P field, but it
> is used when the cursor position refers to an internally generated",
> "internally generated" should be replaced with "internally-generated".
> https://www.postgresql.org/docs/9.6/static/protocol-error-fields.html
Yet another place with both of "internally generated" and "internall-generated"
https://www.postgresql.org/docs/9.6/static/libpq-exec.html
PS. By using FTS I see that there are another places with this inconsistency.
--
// Dmitry.
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo.
2016-06-07 11:26 Typo. Dmitry Igrishin <dmitigr@gmail.com>
@ 2016-06-07 12:44 ` Kevin Grittner <kgrittn@gmail.com>
2016-06-07 13:22 ` Re: Typo. Dmitry Igrishin <dmitigr@gmail.com>
1 sibling, 1 reply; 43+ messages in thread
From: Kevin Grittner @ 2016-06-07 12:44 UTC (permalink / raw)
To: Dmitry Igrishin <dmitigr@gmail.com>; +Cc: pgsql-docs
On Tue, Jun 7, 2016 at 6:26 AM, Dmitry Igrishin <dmitigr@gmail.com> wrote:
> In "Internal position: this is defined the same as the P field, but it
> is used when the cursor position refers to an internally generated",
> "internally generated" should be replaced with "internally-generated".
Not according to, for example, the Chicago Manual of Style:
http://www.chicagomanualofstyle.org/16/images/ch07_tab01.pdf
(See the "adverb ending in ly + participle or adjective" category.)
I'm pretty sure that this has been discussed on this list before
and decided in favor of omitting the hyphenation in such cases.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo.
2016-06-07 11:26 Typo. Dmitry Igrishin <dmitigr@gmail.com>
2016-06-07 12:44 ` Re: Typo. Kevin Grittner <kgrittn@gmail.com>
@ 2016-06-07 13:22 ` Dmitry Igrishin <dmitigr@gmail.com>
2016-06-07 13:37 ` Re: Typo. Kevin Grittner <kgrittn@gmail.com>
2016-06-07 13:47 ` Re: Typo. Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 2 replies; 43+ messages in thread
From: Dmitry Igrishin @ 2016-06-07 13:22 UTC (permalink / raw)
To: Kevin Grittner <kgrittn@gmail.com>; +Cc: pgsql-docs
2016-06-07 15:44 GMT+03:00 Kevin Grittner <kgrittn@gmail.com>:
> On Tue, Jun 7, 2016 at 6:26 AM, Dmitry Igrishin <dmitigr@gmail.com> wrote:
>
>> In "Internal position: this is defined the same as the P field, but it
>> is used when the cursor position refers to an internally generated",
>> "internally generated" should be replaced with "internally-generated".
>
> Not according to, for example, the Chicago Manual of Style:
>
> http://www.chicagomanualofstyle.org/16/images/ch07_tab01.pdf
>
> (See the "adverb ending in ly + participle or adjective" category.)
>
> I'm pretty sure that this has been discussed on this list before
> and decided in favor of omitting the hyphenation in such cases.
Hm, well, how about removing hypenation from
"Internal query: the text of a failed internally-generated command",
"procedural language functions and internally-generated queries",
at https://www.postgresql.org/docs/9.6/static/protocol-error-fields.html
and similar in other places?
--
// Dmitry.
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo.
2016-06-07 11:26 Typo. Dmitry Igrishin <dmitigr@gmail.com>
2016-06-07 12:44 ` Re: Typo. Kevin Grittner <kgrittn@gmail.com>
2016-06-07 13:22 ` Re: Typo. Dmitry Igrishin <dmitigr@gmail.com>
@ 2016-06-07 13:37 ` Kevin Grittner <kgrittn@gmail.com>
1 sibling, 0 replies; 43+ messages in thread
From: Kevin Grittner @ 2016-06-07 13:37 UTC (permalink / raw)
To: Dmitry Igrishin <dmitigr@gmail.com>; +Cc: pgsql-docs
On Tue, Jun 7, 2016 at 8:22 AM, Dmitry Igrishin <dmitigr@gmail.com> wrote:
> 2016-06-07 15:44 GMT+03:00 Kevin Grittner <kgrittn@gmail.com>:
>> On Tue, Jun 7, 2016 at 6:26 AM, Dmitry Igrishin <dmitigr@gmail.com> wrote:
>>
>>> In "Internal position: this is defined the same as the P field, but it
>>> is used when the cursor position refers to an internally generated",
>>> "internally generated" should be replaced with "internally-generated".
>>
>> Not according to, for example, the Chicago Manual of Style:
>>
>> http://www.chicagomanualofstyle.org/16/images/ch07_tab01.pdf
>>
>> (See the "adverb ending in ly + participle or adjective" category.)
>>
>> I'm pretty sure that this has been discussed on this list before
>> and decided in favor of omitting the hyphenation in such cases.
> Hm, well, how about removing hypenation from
> "Internal query: the text of a failed internally-generated command",
> "procedural language functions and internally-generated queries",
> at https://www.postgresql.org/docs/9.6/static/protocol-error-fields.html
> and similar in other places?
I think we should be consistent, especially on adjacent lines. Oddly,
a single commit 12 years ago used both in close proximity.
--
Kevin Grittner
EDB: http://www.enterprisedb.com
The Enterprise PostgreSQL Company
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo.
2016-06-07 11:26 Typo. Dmitry Igrishin <dmitigr@gmail.com>
2016-06-07 12:44 ` Re: Typo. Kevin Grittner <kgrittn@gmail.com>
2016-06-07 13:22 ` Re: Typo. Dmitry Igrishin <dmitigr@gmail.com>
@ 2016-06-07 13:47 ` Tom Lane <tgl@sss.pgh.pa.us>
2016-06-07 14:20 ` Re: Typo. Dmitry Igrishin <dmitigr@gmail.com>
1 sibling, 1 reply; 43+ messages in thread
From: Tom Lane @ 2016-06-07 13:47 UTC (permalink / raw)
To: Dmitry Igrishin <dmitigr@gmail.com>; +Cc: Kevin Grittner <kgrittn@gmail.com>; pgsql-docs
Dmitry Igrishin <dmitigr@gmail.com> writes:
> 2016-06-07 15:44 GMT+03:00 Kevin Grittner <kgrittn@gmail.com>:
>> I'm pretty sure that this has been discussed on this list before
>> and decided in favor of omitting the hyphenation in such cases.
> Hm, well, how about removing hypenation from
> "Internal query: the text of a failed internally-generated command",
> "procedural language functions and internally-generated queries",
> at https://www.postgresql.org/docs/9.6/static/protocol-error-fields.html
> and similar in other places?
They are both correct: it's just a matter of preference which one is used
in a particular place. Any particular instance might be that way because
whoever wrote it always writes that way, or maybe they actually thought
about it and decided a hyphen did or didn't read better there. (To my
taste, a hyphen is better if the phrase is being used as a compound
adjective, and otherwise probably not; but it's a minor thing.) It's just
make-work to try to make all the many hundreds of places where we have
such wording 100% consistent; and I seriously doubt that it would create
any improvement in readability.
If you're looking to improve the docs, there are many places where the
English is actually pretty bad ... but this isn't one.
regards, tom lane
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo.
2016-06-07 11:26 Typo. Dmitry Igrishin <dmitigr@gmail.com>
2016-06-07 12:44 ` Re: Typo. Kevin Grittner <kgrittn@gmail.com>
2016-06-07 13:22 ` Re: Typo. Dmitry Igrishin <dmitigr@gmail.com>
2016-06-07 13:47 ` Re: Typo. Tom Lane <tgl@sss.pgh.pa.us>
@ 2016-06-07 14:20 ` Dmitry Igrishin <dmitigr@gmail.com>
0 siblings, 0 replies; 43+ messages in thread
From: Dmitry Igrishin @ 2016-06-07 14:20 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Kevin Grittner <kgrittn@gmail.com>; pgsql-docs
2016-06-07 16:47 GMT+03:00 Tom Lane <tgl@sss.pgh.pa.us>:
> Dmitry Igrishin <dmitigr@gmail.com> writes:
>> 2016-06-07 15:44 GMT+03:00 Kevin Grittner <kgrittn@gmail.com>:
>>> I'm pretty sure that this has been discussed on this list before
>>> and decided in favor of omitting the hyphenation in such cases.
>
>> Hm, well, how about removing hypenation from
>> "Internal query: the text of a failed internally-generated command",
>> "procedural language functions and internally-generated queries",
>> at https://www.postgresql.org/docs/9.6/static/protocol-error-fields.html
>> and similar in other places?
>
> They are both correct: it's just a matter of preference which one is used
> in a particular place. Any particular instance might be that way because
> whoever wrote it always writes that way, or maybe they actually thought
> about it and decided a hyphen did or didn't read better there.
Hm, maybe. Shrug.
> (To my taste, a hyphen is better if the phrase is being used as a compound
> adjective, and otherwise probably not; but it's a minor thing.)
Yes, I agree here.
> It's just make-work to try to make all the many hundreds of places where we have
> such wording 100% consistent; and I seriously doubt that it would create
> any improvement in readability.
>
> If you're looking to improve the docs, there are many places where the
> English is actually pretty bad ... but this isn't one.
Well, I usually report here when I read the documentation to do my
work and see some annoying inconsistency. And often I stop myself, but
in certain cases I can't refrain not to report. Sorry if I too bother
for things that don't worth it.
--
// Dmitry.
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 43+ messages in thread
* typo
@ 2017-05-17 13:13 cyril.auburtin@gmail.com
2017-05-17 21:47 ` Re: typo David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 43+ messages in thread
From: cyril.auburtin@gmail.com @ 2017-05-17 13:13 UTC (permalink / raw)
To: pgsql-docs
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/9.6/static/ddl-constraints.html
Description:
https://www.postgresql.org/docs/9.6/static/ddl-constraints.html#DDL-CONSTRAINTS-FK
"If someone removes an order, the order items are removed as well"
should be " If someone removes a product..."
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: typo
2017-05-17 13:13 typo cyril.auburtin@gmail.com
@ 2017-05-17 21:47 ` David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 0 replies; 43+ messages in thread
From: David G. Johnston @ 2017-05-17 21:47 UTC (permalink / raw)
To: cyril.auburtin@gmail.com; +Cc: pgsql-docs
On Wed, May 17, 2017 at 6:13 AM, <cyril.auburtin@gmail.com> wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/9.6/static/ddl-constraints.html
> Description:
>
> https://www.postgresql.org/docs/9.6/static/ddl-constraints.html#DDL-
> CONSTRAINTS-FK
>
> "If someone removes an order, the order items are removed as
> well"
>
> should be " If someone removes a product..."
>
No, the wording in the docs is accurate. It might be better to say
"implement the following two policies"...that second sentence is part of
the overall policy being described. The policy has two components which is
why both FK constraints were changed.
David J.
^ permalink raw reply [nested|flat] 43+ messages in thread
* Typo
@ 2017-10-23 08:41 juergen@purtz.de
2017-10-23 09:13 ` Re: Typo Erik Rijkers <er@xs4all.nl>
0 siblings, 1 reply; 43+ messages in thread
From: juergen@purtz.de @ 2017-10-23 08:41 UTC (permalink / raw)
To: pgsql-docs
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/10/static/app-pgdump.html
Description:
There is a typo at "the old locution" (since 8.2) - probable shall be "the
old location".
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2017-10-23 08:41 Typo juergen@purtz.de
@ 2017-10-23 09:13 ` Erik Rijkers <er@xs4all.nl>
0 siblings, 0 replies; 43+ messages in thread
From: Erik Rijkers @ 2017-10-23 09:13 UTC (permalink / raw)
To: juergen@purtz.de; +Cc: pgsql-docs; pgsql-docs-owner@postgresql.org
On 2017-10-23 10:41, juergen@purtz.de wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/10/static/app-pgdump.html
> Description:
>
> There is a typo at "the old locution" (since 8.2) - probable
> shall be "the
> old location".
Your 'correction' is no improvement.
'locution' means something like 'way to say something' which is correct
here. (whereas 'location' seems nonsensical.)
or, at: http://www.dictionary.com/browse/locution
'a particular form of expression'
--
Sent via pgsql-docs mailing list (pgsql-docs@postgresql.org)
To make changes to your subscription:
http://www.postgresql.org/mailpref/pgsql-docs
^ permalink raw reply [nested|flat] 43+ messages in thread
* Typo
@ 2017-12-12 12:02 blaz@merela.org
2017-12-12 16:26 ` Re: Typo Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 1 reply; 43+ messages in thread
From: blaz@merela.org @ 2017-12-12 12:02 UTC (permalink / raw)
To: pgsql-docs
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/10/static/using-explain.html
Description:
"The costs of the loop node are then set on the basis of the cost of the
outer scan, plus one repetition of the inner scan for each outer row (10 *
7.87, here), plus a little CPU time for join processing."
Shouldn't it be "10 * 7.91" inside the braces?
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2017-12-12 12:02 Typo blaz@merela.org
@ 2017-12-12 16:26 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2017-12-18 21:14 ` Re: Typo Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 1 reply; 43+ messages in thread
From: Peter Eisentraut @ 2017-12-12 16:26 UTC (permalink / raw)
To: blaz@merela.org; pgsql-docs
On 12/12/17 07:02, blaz@merela.org wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/10/static/using-explain.html
> Description:
>
> "The costs of the loop node are then set on the basis of the cost of the
> outer scan, plus one repetition of the inner scan for each outer row (10 *
> 7.87, here), plus a little CPU time for join processing."
>
> Shouldn't it be "10 * 7.91" inside the braces?
Yes. That wasn't updated when the EXPLAIN output was regenerated some
time ago. Do you see any other numbers in the next that don't match the
EXPLAIN output?
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2017-12-12 12:02 Typo blaz@merela.org
2017-12-12 16:26 ` Re: Typo Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
@ 2017-12-18 21:14 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
0 siblings, 0 replies; 43+ messages in thread
From: Peter Eisentraut @ 2017-12-18 21:14 UTC (permalink / raw)
To: blaz@merela.org; pgsql-docs
On 12/12/17 11:26, Peter Eisentraut wrote:
> On 12/12/17 07:02, blaz@merela.org wrote:
>> The following documentation comment has been logged on the website:
>>
>> Page: https://www.postgresql.org/docs/10/static/using-explain.html
>> Description:
>>
>> "The costs of the loop node are then set on the basis of the cost of the
>> outer scan, plus one repetition of the inner scan for each outer row (10 *
>> 7.87, here), plus a little CPU time for join processing."
>>
>> Shouldn't it be "10 * 7.91" inside the braces?
>
> Yes. That wasn't updated when the EXPLAIN output was regenerated some
> time ago. Do you see any other numbers in the next that don't match the
> EXPLAIN output?
Fixes committed
--
Peter Eisentraut http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services
^ permalink raw reply [nested|flat] 43+ messages in thread
* typo
@ 2018-11-26 00:47 PG Doc comments form <noreply@postgresql.org>
2018-11-26 06:56 ` Re: typo Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 43+ messages in thread
From: PG Doc comments form @ 2018-11-26 00:47 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: nawaz@fast.au.fujitsu.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/11/storage-file-layout.html
Description:
I think I found a typo in the manuals in the below sentence. I have
highlighted the correction within double quotes (") and UPPERCASE text. Does
it sound right ?
URL: https://www.postgresql.org/docs/11/storage-file-layout.html
Typo: A table that has columns with potentially large entries will have an
associated TOAST table, which is used for out-of-line storage of field
values that are too large to keep in the table rows proper
Correction: A table that has columns with potentially large entries will
have an associated TOAST table, which is used for out-of-line storage of
field values that are too large to keep in the table rows "PROPERLY".
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: typo
2018-11-26 00:47 typo PG Doc comments form <noreply@postgresql.org>
@ 2018-11-26 06:56 ` Michael Paquier <michael@paquier.xyz>
2018-11-26 07:03 ` Re: typo Magnus Hagander <magnus@hagander.net>
0 siblings, 1 reply; 43+ messages in thread
From: Michael Paquier @ 2018-11-26 06:56 UTC (permalink / raw)
To: nawaz@fast.au.fujitsu.com; pgsql-docs@lists.postgresql.org
On Mon, Nov 26, 2018 at 12:47:51AM +0000, PG Doc comments form wrote:
> Correction: A table that has columns with potentially large entries will
> have an associated TOAST table, which is used for out-of-line storage of
> field values that are too large to keep in the table rows "PROPERLY".
Thanks, committed. I have fixed the docs to reflect your suggestion.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../20181126065643.GK1776@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: typo
2018-11-26 00:47 typo PG Doc comments form <noreply@postgresql.org>
2018-11-26 06:56 ` Re: typo Michael Paquier <michael@paquier.xyz>
@ 2018-11-26 07:03 ` Magnus Hagander <magnus@hagander.net>
2018-11-26 07:17 ` Re: typo Vik Fearing <vik.fearing@2ndquadrant.com>
0 siblings, 1 reply; 43+ messages in thread
From: Magnus Hagander @ 2018-11-26 07:03 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: nawaz@fast.au.fujitsu.com; pgsql-docs@lists.postgresql.org
On Mon, Nov 26, 2018, 07:56 Michael Paquier <michael@paquier.xyz wrote:
> On Mon, Nov 26, 2018 at 12:47:51AM +0000, PG Doc comments form wrote:
> > Correction: A table that has columns with potentially large entries will
> > have an associated TOAST table, which is used for out-of-line storage of
> > field values that are too large to keep in the table rows "PROPERLY".
>
> Thanks, committed. I have fixed the docs to reflect your suggestion.
> -
>
Are you sure that's right? To me the original wording of that sentence
seems to convey the message properly, and the update done does not?
/Magnus
>
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: typo
2018-11-26 00:47 typo PG Doc comments form <noreply@postgresql.org>
2018-11-26 06:56 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 07:03 ` Re: typo Magnus Hagander <magnus@hagander.net>
@ 2018-11-26 07:17 ` Vik Fearing <vik.fearing@2ndquadrant.com>
2018-11-26 07:42 ` Re: typo Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 43+ messages in thread
From: Vik Fearing @ 2018-11-26 07:17 UTC (permalink / raw)
To: Magnus Hagander <magnus@hagander.net>; Michael Paquier <michael@paquier.xyz>; +Cc: nawaz@fast.au.fujitsu.com; pgsql-docs@lists.postgresql.org
On 26/11/2018 08:03, Magnus Hagander wrote:
>
>
> On Mon, Nov 26, 2018, 07:56 Michael Paquier <michael@paquier.xyz
> <mailto:michael@paquier.xyz> wrote:
>
> On Mon, Nov 26, 2018 at 12:47:51AM +0000, PG Doc comments form wrote:
> > Correction: A table that has columns with potentially large
> entries will
> > have an associated TOAST table, which is used for out-of-line
> storage of
> > field values that are too large to keep in the table rows "PROPERLY".
>
> Thanks, committed. I have fixed the docs to reflect your suggestion.
> -
>
>
>
> Are you sure that's right? To me the original wording of that sentence
> seems to convey the message properly, and the update done does not?
Yeah, I just found this on the committers list and I disagree with the
change as well.
--
Vik Fearing +33 6 46 75 15 36
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: typo
2018-11-26 00:47 typo PG Doc comments form <noreply@postgresql.org>
2018-11-26 06:56 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 07:03 ` Re: typo Magnus Hagander <magnus@hagander.net>
2018-11-26 07:17 ` Re: typo Vik Fearing <vik.fearing@2ndquadrant.com>
@ 2018-11-26 07:42 ` Michael Paquier <michael@paquier.xyz>
2018-11-26 09:35 ` Re: typo Magnus Hagander <magnus@hagander.net>
2018-11-26 14:14 ` Re: typo Tom Lane <tgl@sss.pgh.pa.us>
0 siblings, 2 replies; 43+ messages in thread
From: Michael Paquier @ 2018-11-26 07:42 UTC (permalink / raw)
To: Vik Fearing <vik.fearing@2ndquadrant.com>; +Cc: Magnus Hagander <magnus@hagander.net>; nawaz@fast.au.fujitsu.com; pgsql-docs@lists.postgresql.org
On Mon, Nov 26, 2018 at 08:17:06AM +0100, Vik Fearing wrote:
> On 26/11/2018 08:03, Magnus Hagander wrote:
>> Are you sure that's right? To me the original wording of that sentence
>> seems to convey the message properly, and the update done does not?
>
> Yeah, I just found this on the committers list and I disagree with the
> change as well.
[... checking around ...]
Hm. I have read the sentence and the surroundings a couple of times
before doing anything, and using an adverb looked clearer than the
adjective. Is an adjective more appropriate than an adverb here because
it insists more on the fact that each row is involved? Just trying to
grab the difference.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../20181126074238.GL1776@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: typo
2018-11-26 00:47 typo PG Doc comments form <noreply@postgresql.org>
2018-11-26 06:56 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 07:03 ` Re: typo Magnus Hagander <magnus@hagander.net>
2018-11-26 07:17 ` Re: typo Vik Fearing <vik.fearing@2ndquadrant.com>
2018-11-26 07:42 ` Re: typo Michael Paquier <michael@paquier.xyz>
@ 2018-11-26 09:35 ` Magnus Hagander <magnus@hagander.net>
1 sibling, 0 replies; 43+ messages in thread
From: Magnus Hagander @ 2018-11-26 09:35 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: Vik Fearing <vik.fearing@2ndquadrant.com>; nawaz@fast.au.fujitsu.com; pgsql-docs@lists.postgresql.org
On Mon, Nov 26, 2018 at 8:42 AM Michael Paquier <michael@paquier.xyz> wrote:
> On Mon, Nov 26, 2018 at 08:17:06AM +0100, Vik Fearing wrote:
> > On 26/11/2018 08:03, Magnus Hagander wrote:
> >> Are you sure that's right? To me the original wording of that sentence
> >> seems to convey the message properly, and the update done does not?
> >
> > Yeah, I just found this on the committers list and I disagree with the
> > change as well.
>
> [... checking around ...]
> Hm. I have read the sentence and the surroundings a couple of times
> before doing anything, and using an adverb looked clearer than the
> adjective. Is an adjective more appropriate than an adverb here because
> it insists more on the fact that each row is involved? Just trying to
> grab the difference.
>
If the current text is unclear to people we should definitely fix it --
just to the right thing.
Maybe say something like "keep inline in the regular table rows" instead?
--
Magnus Hagander
Me: https://www.hagander.net/ <http://www.hagander.net/;
Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: typo
2018-11-26 00:47 typo PG Doc comments form <noreply@postgresql.org>
2018-11-26 06:56 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 07:03 ` Re: typo Magnus Hagander <magnus@hagander.net>
2018-11-26 07:17 ` Re: typo Vik Fearing <vik.fearing@2ndquadrant.com>
2018-11-26 07:42 ` Re: typo Michael Paquier <michael@paquier.xyz>
@ 2018-11-26 14:14 ` Tom Lane <tgl@sss.pgh.pa.us>
2018-11-26 14:29 ` Re: typo Vik Fearing <vik.fearing@2ndquadrant.com>
2018-11-26 14:34 ` Re: typo Erik Rijkers <er@xs4all.nl>
2018-11-27 01:35 ` Re: typo Michael Paquier <michael@paquier.xyz>
1 sibling, 3 replies; 43+ messages in thread
From: Tom Lane @ 2018-11-26 14:14 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: Vik Fearing <vik.fearing@2ndquadrant.com>; Magnus Hagander <magnus@hagander.net>; nawaz@fast.au.fujitsu.com; pgsql-docs@lists.postgresql.org
Michael Paquier <michael@paquier.xyz> writes:
> On Mon, Nov 26, 2018 at 08:17:06AM +0100, Vik Fearing wrote:
>> On 26/11/2018 08:03, Magnus Hagander wrote:
>>> Are you sure that's right? To me the original wording of that sentence
>>> seems to convey the message properly, and the update done does not?
>> Yeah, I just found this on the committers list and I disagree with the
>> change as well.
> [... checking around ...]
> Hm. I have read the sentence and the surroundings a couple of times
> before doing anything, and using an adverb looked clearer than the
> adjective. Is an adjective more appropriate than an adverb here because
> it insists more on the fact that each row is involved? Just trying to
> grab the difference.
I think that text is mine originally, and it was not a typo. The meaning
of "table rows proper", in this case, is basically "table rows themelves".
The first dictionary I looked at gives this example:
PROPER
Adjective [ chiefly British ]
... [ postpositive ] Strictly so called; in its true form.
"some of the dos and don'ts in espionage proper"
But I can see that a lot of people might not be familiar with that usage,
so I've got no objections to rewriting it more clearly --- any
suggestions?
regards, tom lane
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: typo
2018-11-26 00:47 typo PG Doc comments form <noreply@postgresql.org>
2018-11-26 06:56 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 07:03 ` Re: typo Magnus Hagander <magnus@hagander.net>
2018-11-26 07:17 ` Re: typo Vik Fearing <vik.fearing@2ndquadrant.com>
2018-11-26 07:42 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 14:14 ` Re: typo Tom Lane <tgl@sss.pgh.pa.us>
@ 2018-11-26 14:29 ` Vik Fearing <vik.fearing@2ndquadrant.com>
2 siblings, 0 replies; 43+ messages in thread
From: Vik Fearing @ 2018-11-26 14:29 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; Michael Paquier <michael@paquier.xyz>; +Cc: Magnus Hagander <magnus@hagander.net>; nawaz@fast.au.fujitsu.com; pgsql-docs@lists.postgresql.org
On 26/11/2018 15:14, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> On Mon, Nov 26, 2018 at 08:17:06AM +0100, Vik Fearing wrote:
>>> On 26/11/2018 08:03, Magnus Hagander wrote:
>>>> Are you sure that's right? To me the original wording of that sentence
>>>> seems to convey the message properly, and the update done does not?
>
>>> Yeah, I just found this on the committers list and I disagree with the
>>> change as well.
>
>> [... checking around ...]
>> Hm. I have read the sentence and the surroundings a couple of times
>> before doing anything, and using an adverb looked clearer than the
>> adjective. Is an adjective more appropriate than an adverb here because
>> it insists more on the fact that each row is involved? Just trying to
>> grab the difference.
>
> I think that text is mine originally, and it was not a typo. The meaning
> of "table rows proper", in this case, is basically "table rows themelves".
> The first dictionary I looked at gives this example:
>
> PROPER
> Adjective [ chiefly British ]
> ... [ postpositive ] Strictly so called; in its true form.
> "some of the dos and don'ts in espionage proper"
>
> But I can see that a lot of people might not be familiar with that usage,
> so I've got no objections to rewriting it more clearly --- any
> suggestions?
How about
A table that has columns with potentially large entries will have an
associated TOAST table, which is used for out-of-line storage of field
- values that are too large to keep in the table rows proper.
+ values that are too large to keep in the main table storage.
--
Vik Fearing +33 6 46 75 15 36
http://2ndQuadrant.fr PostgreSQL : Expertise, Formation et Support
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: typo
2018-11-26 00:47 typo PG Doc comments form <noreply@postgresql.org>
2018-11-26 06:56 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 07:03 ` Re: typo Magnus Hagander <magnus@hagander.net>
2018-11-26 07:17 ` Re: typo Vik Fearing <vik.fearing@2ndquadrant.com>
2018-11-26 07:42 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 14:14 ` Re: typo Tom Lane <tgl@sss.pgh.pa.us>
@ 2018-11-26 14:34 ` Erik Rijkers <er@xs4all.nl>
2018-11-27 01:24 ` RE: typo Ahmed, Nawaz <Nawaz@fast.au.fujitsu.com>
2 siblings, 1 reply; 43+ messages in thread
From: Erik Rijkers @ 2018-11-26 14:34 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Michael Paquier <michael@paquier.xyz>; Vik Fearing <vik.fearing@2ndquadrant.com>; Magnus Hagander <magnus@hagander.net>; nawaz@fast.au.fujitsu.com; pgsql-docs@lists.postgresql.org
On 2018-11-26 15:14, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> On Mon, Nov 26, 2018 at 08:17:06AM +0100, Vik Fearing wrote:
>>> On 26/11/2018 08:03, Magnus Hagander wrote:
>>>> Are you sure that's right? To me the original wording of that
>>>> sentence
>>>> seems to convey the message properly, and the update done does not?
>
>>> Yeah, I just found this on the committers list and I disagree with
>>> the
>>> change as well.
>
>> [... checking around ...]
>> Hm. I have read the sentence and the surroundings a couple of times
>> before doing anything, and using an adverb looked clearer than the
>> adjective. Is an adjective more appropriate than an adverb here
>> because
>> it insists more on the fact that each row is involved? Just trying to
>> grab the difference.
>
> I think that text is mine originally, and it was not a typo. The
> meaning
> of "table rows proper", in this case, is basically "table rows
> themelves".
Maybe that is not a bad alternative
"table rows themselves"
Even if that sounds slightly less idiomatic than the original, I think
it'd be less of a stumbling block for non-native readers.
^ permalink raw reply [nested|flat] 43+ messages in thread
* RE: typo
2018-11-26 00:47 typo PG Doc comments form <noreply@postgresql.org>
2018-11-26 06:56 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 07:03 ` Re: typo Magnus Hagander <magnus@hagander.net>
2018-11-26 07:17 ` Re: typo Vik Fearing <vik.fearing@2ndquadrant.com>
2018-11-26 07:42 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 14:14 ` Re: typo Tom Lane <tgl@sss.pgh.pa.us>
2018-11-26 14:34 ` Re: typo Erik Rijkers <er@xs4all.nl>
@ 2018-11-27 01:24 ` Ahmed, Nawaz <Nawaz@fast.au.fujitsu.com>
0 siblings, 0 replies; 43+ messages in thread
From: Ahmed, Nawaz @ 2018-11-27 01:24 UTC (permalink / raw)
To: Erik Rijkers <er@xs4all.nl>; Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Michael Paquier <michael@paquier.xyz>; Vik Fearing <vik.fearing@2ndquadrant.com>; Magnus Hagander <magnus@hagander.net>; pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
I think "table rows themselves" makes sense. I came up with another alternative as below, as long as it does not change the message, the sentence is trying to convey.
"TOAST table, which is used for out-of-line storage of field values that are too large to keep [or, be kept] within the original table."
Best Regards,
Nawaz Ahmed
Software Development Engineer
Fujitsu Australia Software Technology Pty Ltd
14 Rodborough Road, Frenchs Forest NSW 2086, Australia
T +61 2 9452 9027
Nawaz@fast.au.fujitsu.com
fastware.com.au
-----Original Message-----
From: Erik Rijkers [mailto:er@xs4all.nl]
Sent: Tuesday, 27 November 2018 1:35 AM
To: Tom Lane <tgl@sss.pgh.pa.us>
Cc: Michael Paquier <michael@paquier.xyz>; Vik Fearing <vik.fearing@2ndquadrant.com>; Magnus Hagander <magnus@hagander.net>; Ahmed, Nawaz <Nawaz@fast.au.fujitsu.com>; pgsql-docs@lists.postgresql.org
Subject: Re: typo
On 2018-11-26 15:14, Tom Lane wrote:
> Michael Paquier <michael@paquier.xyz> writes:
>> On Mon, Nov 26, 2018 at 08:17:06AM +0100, Vik Fearing wrote:
>>> On 26/11/2018 08:03, Magnus Hagander wrote:
>>>> Are you sure that's right? To me the original wording of that
>>>> sentence seems to convey the message properly, and the update done
>>>> does not?
>
>>> Yeah, I just found this on the committers list and I disagree with
>>> the change as well.
>
>> [... checking around ...]
>> Hm. I have read the sentence and the surroundings a couple of times
>> before doing anything, and using an adverb looked clearer than the
>> adjective. Is an adjective more appropriate than an adverb here
>> because it insists more on the fact that each row is involved? Just
>> trying to grab the difference.
>
> I think that text is mine originally, and it was not a typo. The
> meaning of "table rows proper", in this case, is basically "table rows
> themelves".
Maybe that is not a bad alternative
"table rows themselves"
Even if that sounds slightly less idiomatic than the original, I think it'd be less of a stumbling block for non-native readers.
Disclaimer
The information in this e-mail is confidential and may contain content that is subject to copyright and/or is commercial-in-confidence and is intended only for the use of the above named addressee. If you are not the intended recipient, you are hereby notified that dissemination, copying or use of the information is strictly prohibited. If you have received this e-mail in error, please telephone Fujitsu Australia Software Technology Pty Ltd on + 61 2 9452 9000 or by reply e-mail to the sender and delete the document and all copies thereof.
Whereas Fujitsu Australia Software Technology Pty Ltd would not knowingly transmit a virus within an email communication, it is the receiver’s responsibility to scan all communication and any files attached for computer viruses and other defects. Fujitsu Australia Software Technology Pty Ltd does not accept liability for any loss or damage (whether direct, indirect, consequential or economic) however caused, and whether by negligence or otherwise, which may result directly or indirectly from this communication or any files attached.
If you do not wish to receive commercial and/or marketing email messages from Fujitsu Australia Software Technology Pty Ltd, please email unsubscribe@fast.au.fujitsu.com
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: typo
2018-11-26 00:47 typo PG Doc comments form <noreply@postgresql.org>
2018-11-26 06:56 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 07:03 ` Re: typo Magnus Hagander <magnus@hagander.net>
2018-11-26 07:17 ` Re: typo Vik Fearing <vik.fearing@2ndquadrant.com>
2018-11-26 07:42 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 14:14 ` Re: typo Tom Lane <tgl@sss.pgh.pa.us>
@ 2018-11-27 01:35 ` Michael Paquier <michael@paquier.xyz>
2 siblings, 0 replies; 43+ messages in thread
From: Michael Paquier @ 2018-11-27 01:35 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Vik Fearing <vik.fearing@2ndquadrant.com>; Magnus Hagander <magnus@hagander.net>; nawaz@fast.au.fujitsu.com; pgsql-docs@lists.postgresql.org
On Mon, Nov 26, 2018 at 09:14:18AM -0500, Tom Lane wrote:
> But I can see that a lot of people might not be familiar with that usage,
> so I've got no objections to rewriting it more clearly --- any
> suggestions?
It has been suggested upthread to use "in the table rows themselves",
which does not sound bad to me. So that would give, quoting the whole
portion:
A table that has columns with potentially large entries will have an
associated <firstterm>TOAST</firstterm> table, which is used for
out-of-line storage of
-field values that are too large to keep in the table rows properly.
+field values that are too large to keep in the table rows themselves.
<structname>pg_class</structname>.<structfield>reltoastrelid</structfield>
links from a table to
its <acronym>TOAST</acronym> table, if any.
Now I cannot really stand as somebody able to decide the right thing on
this thread, proofs present on the table ;)
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../20181127013501.GB1716@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 43+ messages in thread
* Typo
@ 2019-04-10 16:30 PG Doc comments form <noreply@postgresql.org>
2019-04-10 19:11 ` Re: Typo Jonathan S. Katz <jkatz@postgresql.org>
0 siblings, 1 reply; 43+ messages in thread
From: PG Doc comments form @ 2019-04-10 16:30 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: ly.sitthykun@gmail.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/11/sql-createfunction.html
Description:
I have noted that it seems not convenient.
"
Writing
SECURITY DEFINER
Functions Safely
"
https://www.postgresql.org/docs/11/sql-createfunction.html
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2019-04-10 16:30 Typo PG Doc comments form <noreply@postgresql.org>
@ 2019-04-10 19:11 ` Jonathan S. Katz <jkatz@postgresql.org>
0 siblings, 0 replies; 43+ messages in thread
From: Jonathan S. Katz @ 2019-04-10 19:11 UTC (permalink / raw)
To: ly.sitthykun@gmail.com, pgsql-docs@lists.postgresql.org, PG Doc comments form <noreply@postgresql.org>
On 4/10/19 12:30 PM, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/11/sql-createfunction.html
> Description:
>
> I have noted that it seems not convenient.
> "
> Writing
> SECURITY DEFINER
> Functions Safely
> "
So it appears what's being generated is:
<h2>Writing <code class="literal">SECURITY DEFINER</code> Functions
Safely</h2>
where on pgweb, the CSS on the "<code>" block has no margins on the left
and right. Adding in the margins fixing the spacing in a large view
screen, but it looks funky on mobile. I could probably come up with some
sort of solution that works and is still responsive.
Jonathan
Attachments:
[application/pgp-signature] signature.asc (832B, ../../10000014-2ca9-bdad-ac5b-424d6a64ad36@postgresql.org/2-signature.asc)
download
^ permalink raw reply [nested|flat] 43+ messages in thread
* Typo
@ 2020-01-29 07:36 PG Doc comments form <noreply@postgresql.org>
2020-01-29 08:57 ` Re: Typo Magnus Hagander <magnus@hagander.net>
0 siblings, 1 reply; 43+ messages in thread
From: PG Doc comments form @ 2020-01-29 07:36 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: gshilin@gmail.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/11/libpq-ssl.html
Description:
On page https://www.postgresql.org/docs/11/libpq-ssl.html in phrase "if no
Subject Alternative Name of type dNSName is present." dNSName should be
DNSName
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2020-01-29 07:36 Typo PG Doc comments form <noreply@postgresql.org>
@ 2020-01-29 08:57 ` Magnus Hagander <magnus@hagander.net>
0 siblings, 0 replies; 43+ messages in thread
From: Magnus Hagander @ 2020-01-29 08:57 UTC (permalink / raw)
To: gshilin@gmail.com, Pg Docs <pgsql-docs@lists.postgresql.org>
On Wed, Jan 29, 2020 at 9:55 AM PG Doc comments form
<noreply@postgresql.org> wrote:
>
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/11/libpq-ssl.html
> Description:
>
> On page https://www.postgresql.org/docs/11/libpq-ssl.html in phrase "if no
> Subject Alternative Name of type dNSName is present." dNSName should be
> DNSName
No, that documentation is actually correct. The field name is actually
dNSName -- see https://tools.ietf.org/html/rfc5280 which defines it.
It's somewhat ridiculous, but you have the same thing with iPAdress
for example. I guess because the first letter has to be lowercase.
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
^ permalink raw reply [nested|flat] 43+ messages in thread
* Typo
@ 2021-01-13 03:59 PG Doc comments form <noreply@postgresql.org>
2021-01-13 04:11 ` Re: Typo Michael Vastola <mike@vasto.la>
0 siblings, 1 reply; 43+ messages in thread
From: PG Doc comments form @ 2021-01-13 03:59 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: mike@vasto.la
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/13/functions-string.html
Description:
Hi,
*Really* tiny issue, but the two the functions listed here have unbalanced
parenthesis. (Obviously this is super low priority.)
Best,
Mike
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2021-01-13 03:59 Typo PG Doc comments form <noreply@postgresql.org>
@ 2021-01-13 04:11 ` Michael Vastola <mike@vasto.la>
2021-01-13 10:10 ` Re: Typo Magnus Hagander <magnus@hagander.net>
0 siblings, 1 reply; 43+ messages in thread
From: Michael Vastola @ 2021-01-13 04:11 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org
Crap. Meant to include link.
See
https://www.postgresql.org/docs/current/functions-string.html#id-1.5.8.10.7.2.2.28.1.1.1
On 1/12/21 10:59 PM, PG Doc comments form wrote:
> The following documentation comment has been logged on the website:
>
> Page: https://www.postgresql.org/docs/13/functions-string.html
> Description:
>
> Hi,
> *Really* tiny issue, but the two the functions listed here have unbalanced
> parenthesis. (Obviously this is super low priority.)
>
> Best,
> Mike
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2021-01-13 03:59 Typo PG Doc comments form <noreply@postgresql.org>
2021-01-13 04:11 ` Re: Typo Michael Vastola <mike@vasto.la>
@ 2021-01-13 10:10 ` Magnus Hagander <magnus@hagander.net>
0 siblings, 0 replies; 43+ messages in thread
From: Magnus Hagander @ 2021-01-13 10:10 UTC (permalink / raw)
To: Michael Vastola <mike@vasto.la>; +Cc: Pg Docs <pgsql-docs@lists.postgresql.org>
On Wed, Jan 13, 2021 at 11:01 AM Michael Vastola <mike@vasto.la> wrote:
>
> Crap. Meant to include link.
>
> See
> https://www.postgresql.org/docs/current/functions-string.html#id-1.5.8.10.7.2.2.28.1.1.1
>
> On 1/12/21 10:59 PM, PG Doc comments form wrote:
> > The following documentation comment has been logged on the website:
> >
> > Page: https://www.postgresql.org/docs/13/functions-string.html
> > Description:
> >
> > Hi,
> > *Really* tiny issue, but the two the functions listed here have unbalanced
> > parenthesis. (Obviously this is super low priority.)
That looks to be a mistake made in the conversion of the table formats, yeah.
Fix applied, thanks for the report!
--
Magnus Hagander
Me: https://www.hagander.net/
Work: https://www.redpill-linpro.com/
^ permalink raw reply [nested|flat] 43+ messages in thread
* Typo
@ 2023-05-23 20:52 PG Doc comments form <noreply@postgresql.org>
2023-05-23 22:32 ` Re: Typo Michael Paquier <michael@paquier.xyz>
0 siblings, 1 reply; 43+ messages in thread
From: PG Doc comments form @ 2023-05-23 20:52 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: pspung@northcarolina.edu
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/15/history.html
Description:
Hi Folks, thank you for maintaining this great technical resource, which
I've only recently started to use.
There appears to be a typo, here:
https://www.postgresql.org/docs/current/history.html#:~:text=Postgres95%20code%20was%20completely%20....
A word or two should be added between 'completely' and 'ANSI C', such as
're-written in', or 're-coded using', or some such.
Thanks, Peter Spung | Raleigh, NC, USA
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2023-05-23 20:52 Typo PG Doc comments form <noreply@postgresql.org>
@ 2023-05-23 22:32 ` Michael Paquier <michael@paquier.xyz>
2023-05-23 23:44 ` Re: Typo David G. Johnston <david.g.johnston@gmail.com>
2023-05-24 04:02 ` Re: Typo Laurenz Albe <laurenz.albe@cybertec.at>
0 siblings, 2 replies; 43+ messages in thread
From: Michael Paquier @ 2023-05-23 22:32 UTC (permalink / raw)
To: pspung@northcarolina.edu; pgsql-docs@lists.postgresql.org
On Tue, May 23, 2023 at 08:52:25PM +0000, PG Doc comments form wrote:
> There appears to be a typo, here:
> https://www.postgresql.org/docs/current/history.html#:~:text=Postgres95%20code%20was%20completely%20....
> A word or two should be added between 'completely' and 'ANSI C', such as
> 're-written in', or 're-coded using', or some such.
This is the current sentence, and it sounds kind of OK to me, FWIW:
"Postgres95 code was completely ANSI C and trimmed in size by 25%.
--
Michael
Attachments:
[application/pgp-signature] signature.asc (832B, ../../ZG0+9kCWYg9tzL6m@paquier.xyz/2-signature.asc)
download
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2023-05-23 20:52 Typo PG Doc comments form <noreply@postgresql.org>
2023-05-23 22:32 ` Re: Typo Michael Paquier <michael@paquier.xyz>
@ 2023-05-23 23:44 ` David G. Johnston <david.g.johnston@gmail.com>
1 sibling, 0 replies; 43+ messages in thread
From: David G. Johnston @ 2023-05-23 23:44 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; +Cc: pspung@northcarolina.edu; pgsql-docs@lists.postgresql.org
On Tue, May 23, 2023 at 3:32 PM Michael Paquier <michael@paquier.xyz> wrote:
> On Tue, May 23, 2023 at 08:52:25PM +0000, PG Doc comments form wrote:
> > There appears to be a typo, here:
> >
> https://www.postgresql.org/docs/current/history.html#:~:text=Postgres95%20code%20was%20completely%20...
> .
> > A word or two should be added between 'completely' and 'ANSI C', such as
> > 're-written in', or 're-coded using', or some such.
>
> This is the current sentence, and it sounds kind of OK to me, FWIW:
> "Postgres95 code was completely ANSI C and trimmed in size by 25%.
>
>
I agree with the OP, that is missing something. Maybe:
Between the 4.2 release and the release of Postgres95 the code was made to
completely adhere to ANSI C and the size was reduced by 25%.
David J.
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2023-05-23 20:52 Typo PG Doc comments form <noreply@postgresql.org>
2023-05-23 22:32 ` Re: Typo Michael Paquier <michael@paquier.xyz>
@ 2023-05-24 04:02 ` Laurenz Albe <laurenz.albe@cybertec.at>
2023-05-24 04:25 ` Re: Typo Tom Lane <tgl@sss.pgh.pa.us>
1 sibling, 1 reply; 43+ messages in thread
From: Laurenz Albe @ 2023-05-24 04:02 UTC (permalink / raw)
To: Michael Paquier <michael@paquier.xyz>; pspung@northcarolina.edu; pgsql-docs@lists.postgresql.org
On Wed, 2023-05-24 at 07:32 +0900, Michael Paquier wrote:
> On Tue, May 23, 2023 at 08:52:25PM +0000, PG Doc comments form wrote:
> > There appears to be a typo, here:
> > https://www.postgresql.org/docs/current/history.html#:~:text=Postgres95%20code%20was%20completely%20....
> > A word or two should be added between 'completely' and 'ANSI C', such as
> > 're-written in', or 're-coded using', or some such.
>
> This is the current sentence, and it sounds kind of OK to me, FWIW:
> "Postgres95 code was completely ANSI C and trimmed in size by 25%.
That uses "ANSI C" as an adjective, which I think is sloppy wording
(even though English is somewhat relaxed about the distinction between
classes of words).
How about: "... was written completely in ANSI C ..."
Yours,
Laurenz Albe
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2023-05-23 20:52 Typo PG Doc comments form <noreply@postgresql.org>
2023-05-23 22:32 ` Re: Typo Michael Paquier <michael@paquier.xyz>
2023-05-24 04:02 ` Re: Typo Laurenz Albe <laurenz.albe@cybertec.at>
@ 2023-05-24 04:25 ` Tom Lane <tgl@sss.pgh.pa.us>
2023-05-24 04:35 ` Re: Typo David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 1 reply; 43+ messages in thread
From: Tom Lane @ 2023-05-24 04:25 UTC (permalink / raw)
To: Laurenz Albe <laurenz.albe@cybertec.at>; +Cc: Michael Paquier <michael@paquier.xyz>; pspung@northcarolina.edu; pgsql-docs@lists.postgresql.org
Laurenz Albe <laurenz.albe@cybertec.at> writes:
> On Wed, 2023-05-24 at 07:32 +0900, Michael Paquier wrote:
>> This is the current sentence, and it sounds kind of OK to me, FWIW:
>> "Postgres95 code was completely ANSI C and trimmed in size by 25%.
> That uses "ANSI C" as an adjective, which I think is sloppy wording
> (even though English is somewhat relaxed about the distinction between
> classes of words).
Yeah, it's not great English, but it's not awful English either;
just a rather telegraphic (abbreviated) style.
Here's the thing: at this point, this documentation is itself a
historical artifact. git excavation dates the current wording to
8baa8fcf4 of 1999-06-21, and that was just a small adjustment of
c8cfb0cea of 1998-03-01, and it seems likely that that was pulled
verbatim from some older source.
So I'm disinclined to change it on grounds of "I think the grammar
is a bit shaky". It is what it is.
regards, tom lane
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2023-05-23 20:52 Typo PG Doc comments form <noreply@postgresql.org>
2023-05-23 22:32 ` Re: Typo Michael Paquier <michael@paquier.xyz>
2023-05-24 04:02 ` Re: Typo Laurenz Albe <laurenz.albe@cybertec.at>
2023-05-24 04:25 ` Re: Typo Tom Lane <tgl@sss.pgh.pa.us>
@ 2023-05-24 04:35 ` David G. Johnston <david.g.johnston@gmail.com>
0 siblings, 0 replies; 43+ messages in thread
From: David G. Johnston @ 2023-05-24 04:35 UTC (permalink / raw)
To: Tom Lane <tgl@sss.pgh.pa.us>; +Cc: Laurenz Albe <laurenz.albe@cybertec.at>; Michael Paquier <michael@paquier.xyz>; pspung@northcarolina.edu <pspung@northcarolina.edu>; pgsql-docs@lists.postgresql.org <pgsql-docs@lists.postgresql.org>
On Tuesday, May 23, 2023, Tom Lane <tgl@sss.pgh.pa.us> wrote:
> Laurenz Albe <laurenz.albe@cybertec.at> writes:
> > On Wed, 2023-05-24 at 07:32 +0900, Michael Paquier wrote:
> >> This is the current sentence, and it sounds kind of OK to me, FWIW:
> >> "Postgres95 code was completely ANSI C and trimmed in size by 25%.
>
> > That uses "ANSI C" as an adjective, which I think is sloppy wording
> > (even though English is somewhat relaxed about the distinction between
> > classes of words).
>
> Yeah, it's not great English, but it's not awful English either;
> just a rather telegraphic (abbreviated) style.
>
> Here's the thing: at this point, this documentation is itself a
> historical artifact. git excavation dates the current wording to
> 8baa8fcf4 of 1999-06-21, and that was just a small adjustment of
> c8cfb0cea of 1998-03-01, and it seems likely that that was pulled
> verbatim from some older source.
>
> So I'm disinclined to change it on grounds of "I think the grammar
> is a bit shaky". It is what it is.
>
>
>
Agreed. Besides, after a couple of more passes it grew on me, once I
filled in the missing “compared to what” sufficiently.
David J.
^ permalink raw reply [nested|flat] 43+ messages in thread
* Typo
@ 2026-02-19 06:57 PG Doc comments form <noreply@postgresql.org>
2026-02-20 14:14 ` Re: Typo Daniel Gustafsson <daniel@yesql.se>
0 siblings, 1 reply; 43+ messages in thread
From: PG Doc comments form @ 2026-02-19 06:57 UTC (permalink / raw)
To: pgsql-docs@lists.postgresql.org; +Cc: timothy.kyadondo@gmail.com
The following documentation comment has been logged on the website:
Page: https://www.postgresql.org/docs/18/indexes-types.html
Description:
There is a typo in the BRIN indexes definition—it says "INdexes" instead of
"indexes."
BRIN indexes (a shorthand for Block Range INdexes)
^ permalink raw reply [nested|flat] 43+ messages in thread
* Re: Typo
2026-02-19 06:57 Typo PG Doc comments form <noreply@postgresql.org>
@ 2026-02-20 14:14 ` Daniel Gustafsson <daniel@yesql.se>
0 siblings, 0 replies; 43+ messages in thread
From: Daniel Gustafsson @ 2026-02-20 14:14 UTC (permalink / raw)
To: timothy.kyadondo@gmail.com; pgsql-docs@lists.postgresql.org
> On 19 Feb 2026, at 07:57, PG Doc comments form <noreply@postgresql.org> wrote:
> There is a typo in the BRIN indexes definition—it says "INdexes" instead of
> "indexes."
>
> BRIN indexes (a shorthand for Block Range INdexes)
It's spelled INdexes in that parenthesis to indicate what the acronym BRIN
stands for.
--
Daniel Gustafsson
^ permalink raw reply [nested|flat] 43+ messages in thread
end of thread, other threads:[~2026-02-20 14:14 UTC | newest]
Thread overview: 43+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2016-06-04 07:28 Typo gp0072000@gmail.com
2016-06-07 02:44 ` Michael Paquier <michael.paquier@gmail.com>
2016-06-07 02:56 ` Tom Lane <tgl@sss.pgh.pa.us>
2016-06-07 11:26 Typo. Dmitry Igrishin <dmitigr@gmail.com>
2016-06-07 12:08 ` Re: Typo. Dmitry Igrishin <dmitigr@gmail.com>
2016-06-07 12:44 ` Re: Typo. Kevin Grittner <kgrittn@gmail.com>
2016-06-07 13:22 ` Re: Typo. Dmitry Igrishin <dmitigr@gmail.com>
2016-06-07 13:37 ` Re: Typo. Kevin Grittner <kgrittn@gmail.com>
2016-06-07 13:47 ` Re: Typo. Tom Lane <tgl@sss.pgh.pa.us>
2016-06-07 14:20 ` Re: Typo. Dmitry Igrishin <dmitigr@gmail.com>
2017-05-17 13:13 typo cyril.auburtin@gmail.com
2017-05-17 21:47 ` Re: typo David G. Johnston <david.g.johnston@gmail.com>
2017-10-23 08:41 Typo juergen@purtz.de
2017-10-23 09:13 ` Erik Rijkers <er@xs4all.nl>
2017-12-12 12:02 Typo blaz@merela.org
2017-12-12 16:26 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2017-12-18 21:14 ` Peter Eisentraut <peter.eisentraut@2ndquadrant.com>
2018-11-26 00:47 typo PG Doc comments form <noreply@postgresql.org>
2018-11-26 06:56 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 07:03 ` Re: typo Magnus Hagander <magnus@hagander.net>
2018-11-26 07:17 ` Re: typo Vik Fearing <vik.fearing@2ndquadrant.com>
2018-11-26 07:42 ` Re: typo Michael Paquier <michael@paquier.xyz>
2018-11-26 09:35 ` Re: typo Magnus Hagander <magnus@hagander.net>
2018-11-26 14:14 ` Re: typo Tom Lane <tgl@sss.pgh.pa.us>
2018-11-26 14:29 ` Re: typo Vik Fearing <vik.fearing@2ndquadrant.com>
2018-11-26 14:34 ` Re: typo Erik Rijkers <er@xs4all.nl>
2018-11-27 01:24 ` RE: typo Ahmed, Nawaz <Nawaz@fast.au.fujitsu.com>
2018-11-27 01:35 ` Re: typo Michael Paquier <michael@paquier.xyz>
2019-04-10 16:30 Typo PG Doc comments form <noreply@postgresql.org>
2019-04-10 19:11 ` Jonathan S. Katz <jkatz@postgresql.org>
2020-01-29 07:36 Typo PG Doc comments form <noreply@postgresql.org>
2020-01-29 08:57 ` Magnus Hagander <magnus@hagander.net>
2021-01-13 03:59 Typo PG Doc comments form <noreply@postgresql.org>
2021-01-13 04:11 ` Michael Vastola <mike@vasto.la>
2021-01-13 10:10 ` Magnus Hagander <magnus@hagander.net>
2023-05-23 20:52 Typo PG Doc comments form <noreply@postgresql.org>
2023-05-23 22:32 ` Michael Paquier <michael@paquier.xyz>
2023-05-23 23:44 ` David G. Johnston <david.g.johnston@gmail.com>
2023-05-24 04:02 ` Laurenz Albe <laurenz.albe@cybertec.at>
2023-05-24 04:25 ` Tom Lane <tgl@sss.pgh.pa.us>
2023-05-24 04:35 ` David G. Johnston <david.g.johnston@gmail.com>
2026-02-19 06:57 Typo PG Doc comments form <noreply@postgresql.org>
2026-02-20 14:14 ` Daniel Gustafsson <daniel@yesql.se>
This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox