public inbox for [email protected]  
help / color / mirror / Atom feed
Blanks in the first line before the first word in the code boxes
18+ messages / 6 participants
[nested] [flat]

* Blanks in the first line before the first word in the code boxes
@ 2018-03-23 12:56  Daniel Westermann <[email protected]>
  0 siblings, 1 reply; 18+ messages in thread

From: Daniel Westermann @ 2018-03-23 12:56 UTC (permalink / raw)
  To: pgsql-docs

Hi, 

is it only me who sees blanks before the first word in the first line of the code boxes, e.g. here: 

[ https://www.postgresql.org/docs/9.6/static/sql-createtable.html | https://www.postgresql.org/docs/9.6/static/sql-createtable.html ] 
[ https://www.postgresql.org/docs/10/static/sql-createtable.html | https://www.postgresql.org/docs/10/static/sql-createtable.html ] 

For the devel documentation it is fine: 
[ https://www.postgresql.org/docs/devel/static/sql-createtable.html | https://www.postgresql.org/docs/devel/static/sql-createtable.html ] 

Tested in Firefox and Chrome. 

Regards 
Daniel 


^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-03-29 01:30  Peter Eisentraut <[email protected]>
  parent: Daniel Westermann <[email protected]>
  0 siblings, 1 reply; 18+ messages in thread

From: Peter Eisentraut @ 2018-03-29 01:30 UTC (permalink / raw)
  To: Daniel Westermann <[email protected]>; pgsql-docs

On 3/23/18 08:56, Daniel Westermann wrote:
> is it only me who sees blanks before the first word in the first line of
> the code boxes, e.g. here:
> 
> https://www.postgresql.org/docs/9.6/static/sql-createtable.html
> https://www.postgresql.org/docs/10/static/sql-createtable.html
> 
> For the devel documentation it is fine:
> https://www.postgresql.org/docs/devel/static/sql-createtable.html
> 
> Tested in Firefox and Chrome.

Yeah, that looks weird.  I'll look into it.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-03-29 01:32  Peter Eisentraut <[email protected]>
  parent: Peter Eisentraut <[email protected]>
  0 siblings, 1 reply; 18+ messages in thread

From: Peter Eisentraut @ 2018-03-29 01:32 UTC (permalink / raw)
  To: Daniel Westermann <[email protected]>; pgsql-docs

On 3/28/18 21:30, Peter Eisentraut wrote:
> On 3/23/18 08:56, Daniel Westermann wrote:
>> is it only me who sees blanks before the first word in the first line of
>> the code boxes, e.g. here:
>>
>> https://www.postgresql.org/docs/9.6/static/sql-createtable.html
>> https://www.postgresql.org/docs/10/static/sql-createtable.html
>>
>> For the devel documentation it is fine:
>> https://www.postgresql.org/docs/devel/static/sql-createtable.html
>>
>> Tested in Firefox and Chrome.
> 
> Yeah, that looks weird.  I'll look into it.

Just looking at a nearby thread ... something is quite whacky with the
web site stylesheet.  It didn't use to look like this.  Check this out:
https://www.postgresql.org/docs/10/static/pgcrypto.html#id-1.11.7.35.5

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-03-29 01:36  Jonathan S. Katz <[email protected]>
  parent: Peter Eisentraut <[email protected]>
  0 siblings, 1 reply; 18+ messages in thread

From: Jonathan S. Katz @ 2018-03-29 01:36 UTC (permalink / raw)
  To: Peter Eisentraut <[email protected]>; +Cc: Daniel Westermann <[email protected]>; pgsql-docs


> On Mar 28, 2018, at 9:32 PM, Peter Eisentraut <[email protected]> wrote:
> 
> On 3/28/18 21:30, Peter Eisentraut wrote:
>> On 3/23/18 08:56, Daniel Westermann wrote:
>>> is it only me who sees blanks before the first word in the first line of
>>> the code boxes, e.g. here:
>>> 
>>> https://www.postgresql.org/docs/9.6/static/sql-createtable.html
>>> https://www.postgresql.org/docs/10/static/sql-createtable.html
>>> 
>>> For the devel documentation it is fine:
>>> https://www.postgresql.org/docs/devel/static/sql-createtable.html
>>> 
>>> Tested in Firefox and Chrome.
>> 
>> Yeah, that looks weird.  I'll look into it.
> 
> Just looking at a nearby thread ... something is quite whacky with the
> web site stylesheet.  It didn't use to look like this.  Check this out:
> https://www.postgresql.org/docs/10/static/pgcrypto.html#id-1.11.7.35.5 <https://www.postgresql.org/docs/10/static/pgcrypto.html#id-1.11.7.35.5;
Something is adding spaces - it’s within the “<pre>” tag, which causes browsers
to interpret each space literally.

For the case of the “digest” function, the outputted HTML shows the first digest
function indented, the second one at the start of the new line.

Jonathan



^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-03-29 01:47  Peter Eisentraut <[email protected]>
  parent: Jonathan S. Katz <[email protected]>
  0 siblings, 1 reply; 18+ messages in thread

From: Peter Eisentraut @ 2018-03-29 01:47 UTC (permalink / raw)
  To: Jonathan S. Katz <[email protected]>; +Cc: Daniel Westermann <[email protected]>; pgsql-docs

On 3/28/18 21:36, Jonathan S. Katz wrote:
> 
>> On Mar 28, 2018, at 9:32 PM, Peter Eisentraut
>> <[email protected]
>> <mailto:[email protected]>> wrote:
>>> Yeah, that looks weird.  I'll look into it.
>>
>> Just looking at a nearby thread ... something is quite whacky with the
>> web site stylesheet.  It didn't use to look like this.  Check this out:
>> https://www.postgresql.org/docs/10/static/pgcrypto.html#id-1.11.7.35.5
> 
> Something is adding spaces - it’s within the “<pre>” tag, which causes
> browsers
> to interpret each space literally.
> 
> For the case of the “digest” function, the outputted HTML shows the
> first digest
> function indented, the second one at the start of the new line.

Yeah, the spaces are in the source, so it's not a CSS issue.  But it
doesn't come out like that if you build the docs locally.  So it's
something in the web site code.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-03-29 02:02  Jonathan S. Katz <[email protected]>
  parent: Peter Eisentraut <[email protected]>
  0 siblings, 1 reply; 18+ messages in thread

From: Jonathan S. Katz @ 2018-03-29 02:02 UTC (permalink / raw)
  To: Peter Eisentraut <[email protected]>; +Cc: Daniel Westermann <[email protected]>; pgsql-docs; Magnus Hagander <[email protected]>


> On Mar 28, 2018, at 9:47 PM, Peter Eisentraut <[email protected]> wrote:
> 
> On 3/28/18 21:36, Jonathan S. Katz wrote:
>> 
>>> On Mar 28, 2018, at 9:32 PM, Peter Eisentraut
>>> <[email protected]
>>> <mailto:[email protected]>> wrote:
>>>> Yeah, that looks weird.  I'll look into it.
>>> 
>>> Just looking at a nearby thread ... something is quite whacky with the
>>> web site stylesheet.  It didn't use to look like this.  Check this out:
>>> https://www.postgresql.org/docs/10/static/pgcrypto.html#id-1.11.7.35.5
>> 
>> Something is adding spaces - it’s within the “<pre>” tag, which causes
>> browsers
>> to interpret each space literally.
>> 
>> For the case of the “digest” function, the outputted HTML shows the
>> first digest
>> function indented, the second one at the start of the new line.
> 
> Yeah, the spaces are in the source, so it's not a CSS issue.  But it
> doesn't come out like that if you build the docs locally.  So it's
> something in the web site code.

If I traced the code correctly, the line I suspect is such:

	s = tidy.parseString(contents.encode('utf-8'), **tidyopts)

I know that the web infrastructure recently updated to the Django 1.11
series, I’m not sure if libtidy or the like were also updated with that. I’ll
defer to Magnus on that.

Jonathan





^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-03-29 10:14  Magnus Hagander <[email protected]>
  parent: Jonathan S. Katz <[email protected]>
  0 siblings, 1 reply; 18+ messages in thread

From: Magnus Hagander @ 2018-03-29 10:14 UTC (permalink / raw)
  To: Jonathan S. Katz <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; Daniel Westermann <[email protected]>; pgsql-docs

On Thu, Mar 29, 2018 at 4:02 AM, Jonathan S. Katz <[email protected]>
wrote:

>
> > On Mar 28, 2018, at 9:47 PM, Peter Eisentraut <
> [email protected]> wrote:
> >
> > On 3/28/18 21:36, Jonathan S. Katz wrote:
> >>
> >>> On Mar 28, 2018, at 9:32 PM, Peter Eisentraut
> >>> <[email protected]
> >>> <mailto:[email protected]>> wrote:
> >>>> Yeah, that looks weird.  I'll look into it.
> >>>
> >>> Just looking at a nearby thread ... something is quite whacky with the
> >>> web site stylesheet.  It didn't use to look like this.  Check this out:
> >>> https://www.postgresql.org/docs/10/static/pgcrypto.html#id-1.11.7.35.5
> >>
> >> Something is adding spaces - it’s within the “<pre>” tag, which causes
> >> browsers
> >> to interpret each space literally.
> >>
> >> For the case of the “digest” function, the outputted HTML shows the
> >> first digest
> >> function indented, the second one at the start of the new line.
> >
> > Yeah, the spaces are in the source, so it's not a CSS issue.  But it
> > doesn't come out like that if you build the docs locally.  So it's
> > something in the web site code.
>
> If I traced the code correctly, the line I suspect is such:
>
>         s = tidy.parseString(contents.encode('utf-8'), **tidyopts)
>
> I know that the web infrastructure recently updated to the Django 1.11
> series, I’m not sure if libtidy or the like were also updated with that.
> I’ll
> defer to Magnus on that.
>

This would not change with the change to Django 1.11 -- the actual script
that loads the docs runs outside of Django.

Now, the entire machine was upgraded to a new Debian meaning new python,
new tidy etc some time ago. But this was done the first week of February.

Is it possible that this issue actually showed up around 4-5 February, but
just has gone unnoticed since?

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;


^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-03-29 13:40  Tom Lane <[email protected]>
  parent: Magnus Hagander <[email protected]>
  0 siblings, 2 replies; 18+ messages in thread

From: Tom Lane @ 2018-03-29 13:40 UTC (permalink / raw)
  To: Magnus Hagander <[email protected]>; +Cc: Jonathan S. Katz <[email protected]>; Peter Eisentraut <[email protected]>; Daniel Westermann <[email protected]>; pgsql-docs

Magnus Hagander <[email protected]> writes:
> Is it possible that this issue actually showed up around 4-5 February, but
> just has gone unnoticed since?

It's been there a few weeks, anyway --- I remember somebody complaining
before this particular thread started.  I wouldn't be a bit surprised
if it broke then.

			regards, tom lane




^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-03-29 14:01  David G. Johnston <[email protected]>
  parent: Tom Lane <[email protected]>
  1 sibling, 0 replies; 18+ messages in thread

From: David G. Johnston @ 2018-03-29 14:01 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Magnus Hagander <[email protected]>; Jonathan S. Katz <[email protected]>; Peter Eisentraut <[email protected]>; Daniel Westermann <[email protected]>; pgsql-docs

On Thu, Mar 29, 2018 at 6:40 AM, Tom Lane <[email protected]> wrote:

> Magnus Hagander <[email protected]> writes:
> > Is it possible that this issue actually showed up around 4-5 February,
> but
> > just has gone unnoticed since?
>
> It's been there a few weeks, anyway --- I remember somebody complaining
> before this particular thread started.  I wouldn't be a bit surprised
> if it broke then.
>

​First report that both Tom and I responded to, Tom by cc'ing www, was on
the Feb 26th,

https://www.postgresql.org/message-id/151965261562.21248.6807023085541361264%40wrigleys.postgresql.o...

David J.


^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-04-01 15:55  Magnus Hagander <[email protected]>
  parent: Tom Lane <[email protected]>
  1 sibling, 2 replies; 18+ messages in thread

From: Magnus Hagander @ 2018-04-01 15:55 UTC (permalink / raw)
  To: Tom Lane <[email protected]>; +Cc: Jonathan S. Katz <[email protected]>; Peter Eisentraut <[email protected]>; Daniel Westermann <[email protected]>; pgsql-docs

On Thu, Mar 29, 2018 at 3:40 PM, Tom Lane <[email protected]> wrote:

> Magnus Hagander <[email protected]> writes:
> > Is it possible that this issue actually showed up around 4-5 February,
> but
> > just has gone unnoticed since?
>
> It's been there a few weeks, anyway --- I remember somebody complaining
> before this particular thread started.  I wouldn't be a bit surprised
> if it broke then.
>

Yeah, it's quite likely that it got broken by the OS upgrade and nobody
picked up on it before then. This can probably be because the backbranch
documentation is only updated when we make actual releases.

However, why does devel work fine when the others are broken. It's the
exact same code that's run to load the docs. The *input* to the loader must
also be different at some point.

-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;


^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-04-01 16:02  Tom Lane <[email protected]>
  parent: Magnus Hagander <[email protected]>
  1 sibling, 0 replies; 18+ messages in thread

From: Tom Lane @ 2018-04-01 16:02 UTC (permalink / raw)
  To: Magnus Hagander <[email protected]>; +Cc: Jonathan S. Katz <[email protected]>; Peter Eisentraut <[email protected]>; Daniel Westermann <[email protected]>; pgsql-docs

Magnus Hagander <[email protected]> writes:
> However, why does devel work fine when the others are broken. It's the
> exact same code that's run to load the docs. The *input* to the loader must
> also be different at some point.

HEAD is the only branch building the docs via XML, so it's hardly
unlikely that the input is different.

			regards, tom lane




^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-04-02 15:59  Peter Eisentraut <[email protected]>
  parent: Magnus Hagander <[email protected]>
  1 sibling, 1 reply; 18+ messages in thread

From: Peter Eisentraut @ 2018-04-02 15:59 UTC (permalink / raw)
  To: Magnus Hagander <[email protected]>; Tom Lane <[email protected]>; +Cc: Jonathan S. Katz <[email protected]>; Daniel Westermann <[email protected]>; pgsql-docs

On 4/1/18 11:55, Magnus Hagander wrote:
> However, why does devel work fine when the others are broken. It's the
> exact same code that's run to load the docs. The *input* to the loader
> must also be different at some point.

In devel, the raw HTML output looks like

... <pre class="synopsis">
ALTER FOREIGN TABLE [ IF EXISTS ] [ ONLY ] ...

(with a line break)

but before it looks like

... <pre class="synopsis">ALTER FOREIGN TABLE [ IF EXISTS ] [ ONLY ] ...

(without a line break).

So maybe some part of the processing code thinks it should do some kind
of "indentation" here.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-04-03 13:12  Magnus Hagander <[email protected]>
  parent: Peter Eisentraut <[email protected]>
  0 siblings, 1 reply; 18+ messages in thread

From: Magnus Hagander @ 2018-04-03 13:12 UTC (permalink / raw)
  To: Peter Eisentraut <[email protected]>; +Cc: Tom Lane <[email protected]>; Jonathan S. Katz <[email protected]>; Daniel Westermann <[email protected]>; pgsql-docs

On Mon, Apr 2, 2018 at 5:59 PM, Peter Eisentraut <
[email protected]> wrote:

> On 4/1/18 11:55, Magnus Hagander wrote:
> > However, why does devel work fine when the others are broken. It's the
> > exact same code that's run to load the docs. The *input* to the loader
> > must also be different at some point.
>
> In devel, the raw HTML output looks like
>
> ... <pre class="synopsis">
> ALTER FOREIGN TABLE [ IF EXISTS ] [ ONLY ] ...
>
> (with a line break)
>
> but before it looks like
>
> ... <pre class="synopsis">ALTER FOREIGN TABLE [ IF EXISTS ] [ ONLY ] ...
>
> (without a line break).
>
> So maybe some part of the processing code thinks it should do some kind
> of "indentation" here.
>
>
I think I found the problem, and pushed a fix for it. Basically it turns
off indentation completely on pre-11 versions., I elected to keep indention
on dev because it works there, and it makes debugging any of the formatting
a lot easier.

I've pushed the fix and reloaded the 10 docs. I have not reloaded earlier
branches yet, but I'd be interested in some people reviewing a bunch of
pages in the 10 docs mainly to see if (1) it fixes all the cases, and (2)
it actually breaks some *other* cases.


-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;


^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-04-03 14:55  Peter Eisentraut <[email protected]>
  parent: Magnus Hagander <[email protected]>
  0 siblings, 1 reply; 18+ messages in thread

From: Peter Eisentraut @ 2018-04-03 14:55 UTC (permalink / raw)
  To: Magnus Hagander <[email protected]>; +Cc: Tom Lane <[email protected]>; Jonathan S. Katz <[email protected]>; Daniel Westermann <[email protected]>; pgsql-docs

On 4/3/18 09:12, Magnus Hagander wrote:
> I've pushed the fix and reloaded the 10 docs. I have not reloaded
> earlier branches yet, but I'd be interested in some people reviewing a
> bunch of pages in the 10 docs mainly to see if (1) it fixes all the
> cases, and (2) it actually breaks some *other* cases. 

It looks correct now.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-04-04 13:21  Jonathan S. Katz <[email protected]>
  parent: Peter Eisentraut <[email protected]>
  0 siblings, 2 replies; 18+ messages in thread

From: Jonathan S. Katz @ 2018-04-04 13:21 UTC (permalink / raw)
  To: Peter Eisentraut <[email protected]>; +Cc: Magnus Hagander <[email protected]>; Tom Lane <[email protected]>; Daniel Westermann <[email protected]>; pgsql-docs


> On Apr 3, 2018, at 10:55 AM, Peter Eisentraut <[email protected]> wrote:
> 
> On 4/3/18 09:12, Magnus Hagander wrote:
>> I've pushed the fix and reloaded the 10 docs. I have not reloaded
>> earlier branches yet, but I'd be interested in some people reviewing a
>> bunch of pages in the 10 docs mainly to see if (1) it fixes all the
>> cases, and (2) it actually breaks some *other* cases. 
> 
> It looks correct now.

+1

Did a spot check on known broken pages and chose some others at
random. Viewed the 9.6, 10, and devel versions.  10 and devel both
looked correct, and the 9.6 was broken where expected.

The only thing I saw (and this may be something to look at the SGML
source) was some blocks that looked overly indented, but it was consistent
across all versions.  On

https://www.postgresql.org/docs/current/static/queries-with.html <https://www.postgresql.org/docs/current/static/queries-with.html;

If you search for "WITH RECURSIVE search_graph(id, link, data, depth)”
the expression in the CTE is much more indented than similar CTEs above
it.

IMV I would not let this stop us from reloading the earlier versions as that
indentation is consistent across all versions (including 9.6, where it has the
initial indentation as well).

Jonathan




^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-04-04 20:29  Magnus Hagander <[email protected]>
  parent: Jonathan S. Katz <[email protected]>
  1 sibling, 0 replies; 18+ messages in thread

From: Magnus Hagander @ 2018-04-04 20:29 UTC (permalink / raw)
  To: Jonathan S. Katz <[email protected]>; +Cc: Peter Eisentraut <[email protected]>; Tom Lane <[email protected]>; Daniel Westermann <[email protected]>; pgsql-docs

On Wed, Apr 4, 2018 at 3:21 PM, Jonathan S. Katz <[email protected]>
wrote:

>
> On Apr 3, 2018, at 10:55 AM, Peter Eisentraut <
> [email protected]> wrote:
>
> On 4/3/18 09:12, Magnus Hagander wrote:
>
> I've pushed the fix and reloaded the 10 docs. I have not reloaded
> earlier branches yet, but I'd be interested in some people reviewing a
> bunch of pages in the 10 docs mainly to see if (1) it fixes all the
> cases, and (2) it actually breaks some *other* cases.
>
>
> It looks correct now.
>
>
> +1
>
> Did a spot check on known broken pages and chose some others at
> random. Viewed the 9.6, 10, and devel versions.  10 and devel both
> looked correct, and the 9.6 was broken where expected.
>
> The only thing I saw (and this may be something to look at the SGML
> source) was some blocks that looked overly indented, but it was consistent
> across all versions.  On
>
> https://www.postgresql.org/docs/current/static/queries-with.html
>
> If you search for "WITH RECURSIVE search_graph(id, link, data, depth)”
> the expression in the CTE is much more indented than similar CTEs above
> it.
>
> IMV I would not let this stop us from reloading the earlier versions as
> that
> indentation is consistent across all versions (including 9.6, where it has
> the
> initial indentation as well).
>
>
I've reloaded docs back to 9.3.


-- 
 Magnus Hagander
 Me: https://www.hagander.net/ <http://www.hagander.net/;
 Work: https://www.redpill-linpro.com/ <http://www.redpill-linpro.com/;


^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-04-05 00:59  Peter Eisentraut <[email protected]>
  parent: Jonathan S. Katz <[email protected]>
  1 sibling, 1 reply; 18+ messages in thread

From: Peter Eisentraut @ 2018-04-05 00:59 UTC (permalink / raw)
  To: Jonathan S. Katz <[email protected]>; +Cc: Magnus Hagander <[email protected]>; Tom Lane <[email protected]>; Daniel Westermann <[email protected]>; pgsql-docs

On 4/4/18 09:21, Jonathan S. Katz wrote:
> The only thing I saw (and this may be something to look at the SGML
> source) was some blocks that looked overly indented, but it was consistent
> across all versions.  On
> 
> https://www.postgresql.org/docs/current/static/queries-with.html
> 
> If you search for "WITH RECURSIVE search_graph(id, link, data, depth)”
> the expression in the CTE is much more indented than similar CTEs above
> it.

This was that way in the source.  Probably originally 8-space tabs.
I've fixed it now.

-- 
Peter Eisentraut              http://www.2ndQuadrant.com/
PostgreSQL Development, 24x7 Support, Remote DBA, Training & Services




^ permalink  raw  reply  [nested|flat] 18+ messages in thread

* Re: Blanks in the first line before the first word in the code boxes
@ 2018-04-05 01:10  Jonathan S. Katz <[email protected]>
  parent: Peter Eisentraut <[email protected]>
  0 siblings, 0 replies; 18+ messages in thread

From: Jonathan S. Katz @ 2018-04-05 01:10 UTC (permalink / raw)
  To: Peter Eisentraut <[email protected]>; +Cc: Magnus Hagander <[email protected]>; Tom Lane <[email protected]>; Daniel Westermann <[email protected]>; pgsql-docs


> On Apr 4, 2018, at 8:59 PM, Peter Eisentraut <[email protected]> wrote:
> 
> On 4/4/18 09:21, Jonathan S. Katz wrote:
>> The only thing I saw (and this may be something to look at the SGML
>> source) was some blocks that looked overly indented, but it was consistent
>> across all versions.  On
>> 
>> https://www.postgresql.org/docs/current/static/queries-with.html
>> 
>> If you search for "WITH RECURSIVE search_graph(id, link, data, depth)”
>> the expression in the CTE is much more indented than similar CTEs above
>> it.
> 
> This was that way in the source.  Probably originally 8-space tabs.

That was my hunch, but wanted to be triple-sure.

> I've fixed it now.

Awesome. Thanks!

Jonathan






^ permalink  raw  reply  [nested|flat] 18+ messages in thread


end of thread, other threads:[~2018-04-05 01:10 UTC | newest]

Thread overview: 18+ messages (download: mbox mbox.gz follow: Atom feed)
-- links below jump to the message on this page --
2018-03-23 12:56 Blanks in the first line before the first word in the code boxes Daniel Westermann <[email protected]>
2018-03-29 01:30 ` Peter Eisentraut <[email protected]>
2018-03-29 01:32   ` Peter Eisentraut <[email protected]>
2018-03-29 01:36     ` Jonathan S. Katz <[email protected]>
2018-03-29 01:47       ` Peter Eisentraut <[email protected]>
2018-03-29 02:02         ` Jonathan S. Katz <[email protected]>
2018-03-29 10:14           ` Magnus Hagander <[email protected]>
2018-03-29 13:40             ` Tom Lane <[email protected]>
2018-03-29 14:01               ` David G. Johnston <[email protected]>
2018-04-01 15:55               ` Magnus Hagander <[email protected]>
2018-04-01 16:02                 ` Tom Lane <[email protected]>
2018-04-02 15:59                 ` Peter Eisentraut <[email protected]>
2018-04-03 13:12                   ` Magnus Hagander <[email protected]>
2018-04-03 14:55                     ` Peter Eisentraut <[email protected]>
2018-04-04 13:21                       ` Jonathan S. Katz <[email protected]>
2018-04-04 20:29                         ` Magnus Hagander <[email protected]>
2018-04-05 00:59                         ` Peter Eisentraut <[email protected]>
2018-04-05 01:10                           ` Jonathan S. Katz <[email protected]>

This inbox is served by agora; see mirroring instructions
for how to clone and mirror all data and code used for this inbox